[rfc][icedtea-web]Localized Man Page Script
Andrew Azores
aazores at redhat.com
Tue May 20 18:56:40 UTC 2014
On 05/20/2014 02:41 PM, Jie Kang wrote:
> Hello,
>
> Sorry, I fixed tabs and spaces and included everything in one patch.
>
> Thanks,
> Jie
There's some weird formatting/indentation in the localmanscript.sh.
Also, there are a few things that can be changed in it:
(1) String comparisons.
if [[ "$STR" == "some string" ]]; then
works, but this would be better:
if [ "$STR" = "some string" ]; then
(1)b
[[ "$STR" == "" ]]
can be replaced by
[ -z "$STR" ]
(2) The debug "echo" statement should either be removed, or you can
check for some debugging environment variable before printing perhaps
(3) Add a license header to the file (see html-gen.sh) and maybe a
comment as well explaining the two arguments to the script
Try adding it to the Makefile as well, see if you can get it working. I
think the general approach is fine - we're already doing something quite
similar for html-gen.sh (kicking off a shell script job from the
Makefile), and the approach of the script itself looks fine to me.
Thanks,
--
Andrew A
More information about the distro-pkg-dev
mailing list