/hg/icedtea-web: Properly disconnect all connected http connecti...

[Jiri Vanek]

On 05/21/2014 05:02 PM, Omair Majid wrote:
> * Jiri Vanek <jvanek at redhat.com> [2014-05-21 05:48]:
>> We are a bit deadlocking around usability of comments. Well from where you
>> are looking on it? I got an impression you are looking on them from *code*.
>
> Yes, that's right.
>
>> I think most of your arguments become invalid, when you look to them as on
>> final html file. ANd Imean pure html file without the code. If tose which
>> you wont me to remove will be removed (or when you wont some infomratin to
>> be removed in behalf of somthing else...) then this information is really
>> missing in final html.
>
> I see your point. And I admit that the html "looks" a bit empty when you
> remove redundant comments. I say "looks" because the same information is
> conveyed: for example, do you really need a comment describing the
> parameter's purpose when the name of the parameter makes it obvious?
>
> But even more than that, I am wondering what the point of html docs is.

To be publicly accessible online, and allow browsing. But yes we are not  library (but we can become once!)

> They are nice to have, for sure, but who would be using them? To me,

And I would like to publish them (if they are a bit better :) ) And we are packaging them O:)

> focusing on them means more (on-going) effort without any benefit. In

For IDE? NetBeasn are showing javadoc to each method I'm going to call...

> fact, it means a harder-to-understand system when your comments disagree
> with the code.

Anyway - As you are one of the most honourable persons around, I tried to remove as much "nastynes-for-you" as possible.

Well. The patch grow a bit again :-/

One is the enum you suggested. Not big deal.

I hope we are somewhere in the middle between our opinions. I even hope closer to yours!

Thanx for patience!
   J.


ghmhmh THe patch should become general cleanup... As I told Once Approved I will try to push it in separate changesets (enum, diamond, rest?)

J.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: javadocCleaning3.patch
Type: text/x-patch
Size: 55160 bytes
Desc: not available
URL: <http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20140521/0a6dd710/javadocCleaning3-0001.patch>