[rfc][icedtea-web] PolicyEditor Save As Changes

[Andrew Azores]

On 05/21/2014 03:32 PM, Jie Kang wrote:
> Hi,
>
> Fixed the PolicyEditor's save function, allowing for appropriate saving with respect to file (on-disk) modification and user (in-app) changes. Previously one could not Save As to a new file without any in-app changes. Also previously, one could not save changes to a deleted file properly when no in-app changes were present. These issues are both addressed.
>
> Also removed unused imports in MD5SumWatcher.java.
>
>
> 2014-05-20  Jie Kang  <jkang at redhat.com>
>
>      * netx/net/sourceforge/jnlp/security/policyeditor/PolicyEditor.java
>      (saveAsButtonAction): set changesMade to true to allow savePolicyFile to save
>      (savePolicyFile): no longer immediately returns if changesMade is false
>      (updateMd5WithDialog): use changesMade along with file MD5 sum changes to determine
>      whether to continue saving to disk, also privatized method and renamed method
>      to checkPolicyChangesWithDialog
>      * netx/net/sourceforge/jnlp/util/MD5SumWatcher.java
>      Removed unused imports.
>    
>
> Thanks,

Can you give reproduction steps please? Both things you describe appear 
to work for me without your patch applied.

Thanks,

-- 
Andrew A