[Bug 1802] New: Logic error in checkApplicationLibraryAllowableCodebaseAttribute

[bugzilla-daemon at icedtea.classpath.org]

http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1802

            Bug ID: 1802
           Summary: Logic error in
                    checkApplicationLibraryAllowableCodebaseAttribute
           Product: IcedTea-Web
           Version: hg
          Hardware: x86_64
                OS: Linux
            Status: NEW
          Severity: enhancement
          Priority: P5
         Component: NetX (javaws)
          Assignee: omajid at redhat.com
          Reporter: pdewacht at gmail.com
                CC: unassigned at icedtea.classpath.org

The code that deals with the Application-Library-Allowable-Codebase attribute
does not match the comments. The comment says that either documentBase or
codebase should match, while the code requires both to match (which is only
possible if both are equal). For our site this caused an unnecessary warning.

---
icedtea-web-1.5.orig/netx/net/sourceforge/jnlp/runtime/ManifestAttributesChecker.java
+++
icedtea-web-1.5/netx/net/sourceforge/jnlp/runtime/ManifestAttributesChecker.java
@@ -290,7 +290,7 @@ public class ManifestAttributesChecker {

         if (usedUrls.size() == 1) {
             if (UrlUtils.equalsIgnoreLastSlash(usedUrls.toArray(new
URL[0])[0], codebase)
-                    && UrlUtils.equalsIgnoreLastSlash(usedUrls.toArray(new
URL[0])[0], documentBase)) {
+                    || UrlUtils.equalsIgnoreLastSlash(usedUrls.toArray(new
URL[0])[0], documentBase)) {
                 //all resoources are from codebase or document base. it is ok
to proceeed.
                 OutputController.getLogger().log("All applications resources
(" + usedUrls.toArray(new URL[0])[0] + ") are from codebas/documentbase " +
codebase + "/" + documentBase + ", skipping
Application-Library-Allowable-Codebase Attribute check.");
                 return;

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20140530/9a7cb794/attachment-0001.html>