[rfc][icedtea-web] 1.5.2 release?

Thu Nov 6 09:07:51 UTC 2014

On 11/05/2014 10:25 PM, Lukasz Dracz wrote:
> Hello,
>
> I don't think there is a point to backporting http://icedtea.classpath.org/hg/icedtea-web/rev/d8e057783109
> since I would probably need to backport also: http://icedtea.classpath.org/hg/icedtea-web/rev/e30d71ab91c6 which was the refactor of the cache panel.
> I can do that if you still think it would be worthwhile to be backported.
> All it adds was a tooltip for the spinner, and 1.5 still uses the slider. I could add a tooltip for the slider I guess but they are somewhat different so the Messages would be different.
>

Fair enough. Then do not backport it. ty fir check!

> Sorry for missing the IRC chat I was in a thermostat scrum, then went to lunch without noticing.
> I can do the PL translations, my PL should be good enough if needed. I speak it regularly at home, and attended Polish Saturday School here in Canada from elementary to high school. I do have a good understanding of Polish though I must admit my writing is a little bit rusty with all the Polish grammar rules but I can look stuff up if I am unsure :)
> What do we want translated specifically ?
>
> I translated the two parts from Andrew's patch in the messages.properties
>
> CertWarnHTTPSAcceptTip=Zaakceptuj ten certyfikat i zaufaj połączenie przez HTTPS
> (Accept this certificate and trust a connection via HTTPS)
>
> CertWarnHTTPSRejectTip=Nie akceptuj ten certyfikat i nie buduj połączenie HTTPS
> (Do not Accept this certificate and do not build a HTTPS connection)
> Establish looked/sounded odd to me so I thought build was more natural.
>

Great! ty! This is all :)

Once Andrew pushes his backport, please push thsoe two lines.
(ps: go on wiht transaltor :)
> I have attached the translation, is there anywhere else that needs editing or translating ?
>
> Thank you,
> Lukasz Dracz
>
>
>
> ----- Original Message -----
>> From: "Andrew Azores" <aazores at redhat.com>
>> To: "Jiri Vanek" <jvanek at redhat.com>, "IcedTea Distro List" <distro-pkg-dev at openjdk.java.net>, "Lukasz Dracz"
>> <ldracz at redhat.com>
>> Sent: Wednesday, November 5, 2014 12:25:43 PM
>> Subject: Re: [rfc][icedtea-web] 1.5.2 release?
>>
>> On 11/05/2014 12:22 PM, Jiri Vanek wrote:
>>> On 11/05/2014 06:19 PM, Andrew Azores wrote:
>>>> On 11/04/2014 11:21 AM, Jiri Vanek wrote:
>>>>> On 10/25/2014 05:17 PM, Andrew Azores wrote:
>>>>>> On 10/24/2014 08:55 AM, Jiri Vanek wrote:
>>>>>>> Hi!
>>>>>>>
>>>>>>> There appeared few fixes in head which are maybe worthy to go to
>>>>>>> 1.5 and
>>>>>>> afterward calling for release:
>>>>>>>
>>>>>>> http://icedtea.classpath.org/hg/icedtea-web/rev/99d5407fab4a
>>>>>>> http://icedtea.classpath.org/hg/icedtea-web/rev/dd6be5e03667
>>>>>>> http://icedtea.classpath.org/hg/icedtea-web/rev/df05d1de5af4
>>>>>>> http://icedtea.classpath.org/hg/icedtea-web/rev/c6af2f50a95e
>>>>>>> http://icedtea.classpath.org/hg/icedtea-web/rev/6d62f68fb037
>>>>>>> http://icedtea.classpath.org/hg/icedtea-web/rev/d8e057783109
>>>>>>> http://icedtea.classpath.org/hg/icedtea-web/rev/90faf53bb981
>>>>>>> http://icedtea.classpath.org/hg/icedtea-web/rev/2979fa371add
>>>>>>>
>>>>>>>
>>>>>>> Thoughts?
>>>>>>>
>>>>>>>     J.
>>>>>>
>>>>>> Sounds like a good plan to me.
>>>>>>
>>>>>> Thanks,
>>>>> Hi! I have backported most of them today, except two.
>>>>> "2" is Andrew's and "3" Lukas'
>>>>>
>>>>> "4" is mine, but it is(?) already backported.
>>>>>
>>>>> Guys, please decide whether yours 2 and/or 3 should go to 1.5. If so,
>>>>> please backport. After doing so, and once i got confirmed RH115417
>>>>> 7, I will try to do a release.
>>>>>
>>>>>
>>>>> TY!
>>>>>
>>>>> J.
>>>>
>>>> Attached is the fixed backport for #2.
>>>>
>>>> Thanks,
>>>> --
>>>> Andrew Azores
>>>>
>>>> temporary-permissions-button-npe-fix-backport.patch
>>>>
>>>>
>>>> diff --git a/ChangeLog b/ChangeLog
>>>> --- a/ChangeLog
>>>> +++ b/ChangeLog
>>>> @@ -1,3 +1,18 @@
>>>> +2014-11-05  Andrew Azores<aazores at redhat.com>
>>>> +
>>>> +    * netx/net/sourceforge/jnlp/resources/Messages.properties
>>>> +    (CertWarnHTTPSAcceptTip, CertWarnHTTPSRejectTip): new messages more
>>>> +    applicable for HTTPS cert warning dialogs
>>>> +    * netx/net/sourceforge/jnlp/security/dialogs/CertWarningPane.java:
>>>> +    distinguish between HTTPS cert warnings and signed applet cert
>>>> warnings.
>>>> +    Display appropriate text labels and buttons corresponding to
>>>> either case.
>>>> +    *
>>>> netx/net/sourceforge/jnlp/security/dialogs/TemporaryPermissionsButton.java:
>>>>
>>>> +    If any of file, securityDelegate, or linkedButton are null, simply
>>>> +    disable this component and do not add component listeners
>>>> dependent upon
>>>> +    these fields. Also, do not add multiple groups of permissions,
>>>> and do not
>>>> +    add the permissions to the securityDelegate until the
>>>> linkedButton is
>>>> +    actually clicked (rather than when the menu item is clicked)
>>>> +
>>>>    2014-10-21  Jiri Vanek<jvanek at redhat.com>
>>>>
>>>>        Fixed case when already decoded file is wonted from cache
>>>> (RH1154177)
>>>> diff --git a/netx/net/sourceforge/jnlp/resources/Messages.properties
>>>> b/netx/net/sourceforge/jnlp/resources/Messages.properties
>>>> --- a/netx/net/sourceforge/jnlp/resources/Messages.properties
>>>> +++ b/netx/net/sourceforge/jnlp/resources/Messages.properties
>>>> @@ -25,6 +25,8 @@
>>>>    CertWarnCancelTip=Do not run this applet
>>>>    CertWarnPolicyTip=Advanced sandbox settings
>>>>    CertWarnPolicyEditorItem=Launch PolicyEditor
>>>> +CertWarnHTTPSAcceptTip=Accept this certificate and trust the HTTPS
>>>> connection
>>>> +CertWarnHTTPSRejectTip=Do not accept this certificate and do not
>>>> establish the HTTPS connection
>>>>
>>>
>>>
>>> Hmm. What to do with those two messages? I can supply CZ trasnaltion,
>>> maybe also DE (with help of Severin, Roman or similar :) )  How about
>>> PL? I rembere There was somebody in your surrounding. Wasnt?
>>>
>>> By otherwise - you agree it is ok for 1.5 thsi backport oook?
>>>
>>> Ty!
>>>
>>>     J.
>>>
>>
>> Yup, otherwise the backport looks/sounds fine to me.
>>
>> I do know someone from school who might be able to provide PL
>> translations still. But... what about ldracz? ;) probably easier than
>> pulling in some other "volunteer".
>>
>> Thanks,
>> --
>> Andrew Azores
>>