[rfc][icedtea-web] menu support

[Jiri Vanek]

On 11/14/2014 02:21 PM, Jiri Vanek wrote:
> On 11/13/2014 06:17 PM, Jiri Vanek wrote:
>> On 11/13/2014 05:59 PM, Jiri Vanek wrote:
>>> Hi!
>>>
>>> This is support for XDG menus.
>>>
>>> Work can be divided into two bug parts
>>>   1) additional features to "install desktop icon" dialogue
>>>   2) install the menu item
>>>
>>> 2:
>>> Tested in KDE, Gnome3, mate, xfce. (gnome 2 must-to-do) - see javadoc in XdesktopEntry.java for some
>>> interesting differences. But works surprisingly well.
>>>
>>> 1) our glorious accessdialogue is returning only int. I had to rape it a bit:(  The only other
>>> workaround is to separate desktops's creation to separate class. COnsidering the many logic in
>>> AccessWarningPane I had inclined to those few if lines (anyway there is only small possible
>>> workaroound around this "rape 70,40,30,20,0 codes :-/)
>>>
>>> Happy reading :))
>>>
>>>
>>> J.
>>>
>>> Pleas enote, that [rfc][icedtea-web] ignore npe in pac,a nd fixing --Xoffliner are also part of this
>>> patch. I will remove them in next rounds/before push (As the fixxes were already approved anyway).
>>>
>>>
>>> After this is in/during reviw, I will work on new panel to itweb-settings, which allows removing of
>>> icons and menu entries added by javaws.itweb.
>>>
>>>
>>> General thoughs?
>>>
>>> J.
>>
>> Jsut realized an NPE - in case of ALWAYS_ASK, the information, and getShortcut  may be null...
>>
>>
>> J.
>>
> just adapted to head.. Hei I like this menu +offline support :))


Fixed few messages - thay will go to properties at the end anyway. Also I have chnaged default icon 
from java to javaws. My system dont know javaicon, but knows javaws (wellif you run jnlp you have to 
installe dbooth java, and javaws, but javaws icon is under itw maintainance)

Actually -  I have this line in fedora specfile:
  cp javaws.png $RPM_BUILD_ROOT%{_datadir}/pixmaps

Shouldnt our make install do so? (afaik yes)



J.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: menuSupport_4.diff
Type: text/x-patch
Size: 42265 bytes
Desc: not available
URL: <http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20141114/35881b9c/menuSupport_4-0001.diff>