[rfc][icedtea-web] Remove use of clear cache in PackGZip Tests

[Jiri Vanek]

On 11/21/2014 09:41 PM, Jie Kang wrote:
>
>
> ----- Original Message -----
>> On 11/21/2014 09:31 PM, Jie Kang wrote:
>>> Hello,
>>>
>>>
>>> I just noticed that my push for the PackGZip tests included a mistake where
>>> the test would clear cache in @Setup.
>>>
>>> This patch removes the method call.
>>>
>>> Okay to push?
>>>
>>>
>>> Regards,
>>>
>> Well, why to not clean in @before? It gave sense to me to clear....
>
> Main reason for me is that I don't remember any other reproducer that deletes the whole cache before running. I don't think it's dangerous.

Yes, but no other reproducer is verifying cache content. See eg clear cache reproducer :) It is clearing and filing it all around manytimes...
>
> Note that 'CacheUtil.clearCache' deletes the entire cache. So when you run all the reproducers and it hits the PackGZip reproducer, the cache will be reset to empty...

And it do not hurt.  Better to have cache clean, then have it unpredictable.

I'm +1 for keeping those lines in.


Btw, are you able to reproduce the issue aph hitted?  I'm not....

Thanx, J.
>
>
> Regards,
>
>
>>
>> J.
>>
>