[rfc][icedtea-web] in cae of exisitn human readable form, put url to brackets instead of ignoring human readable form

[Jiri Vanek]

On 10/14/2014 08:34 PM, Lukasz Dracz wrote:
> Hello,
>
> Agreed, the patch is good and the generated docs look better.
> Just a small nit, please just fix the extra spaces.
>
> 3 extra spaces at plus (ManFormatter.java)
> +
>       @Override
>       public String getSeeAlso(String s) {
>           return "  * " + s + getNewLine();
>
> 3 extra spaces at plus (PlainTextFormatter.java)
> +
>       @Override
>       public String getSeeAlso(String s) {
>           return "  * " + s + getNewLine();
>
> 4 extra spaces on the line before the @Override (ReplacingTextFormatter.java)
> +
> +     @Override
> +    public String getUrl(String url, String look) {
> +        if (look == null || look.trim().length() == 0 || url.equals(look)) {
>
> Other than that patch looks good !
>

Thanx both of you! Pushed.

>
> ----- Original Message -----
>> From: "Jie Kang" <jkang at redhat.com>
>> To: "Jiri Vanek" <jvanek at redhat.com>
>> Cc: "IcedTea Distro List" <distro-pkg-dev at openjdk.java.net>
>> Sent: Tuesday, October 14, 2014 2:16:04 PM
>> Subject: Re: [rfc][icedtea-web] in cae of exisitn human readable form, put	url	to brackets instead of ignoring human
>> readable form
>>
>>
>>
>> ----- Original Message -----
>>> This simple patch is trying to fix one of the rebuke  to document generator
>>> impl :
>>>    When <A HREF=URL>text</A> was used in plain/man formater, then it
>>>    translated to URL appearence
>>> only. Which in sentence, which in html looked fine like "text" , appeared
>>> really wrongly.
>>>
>>> After this patch it shoudl appear like "text (url)"
>>>
>>> Small workaround was added for urls with no human-readable-substitution, to
>>> dont have empty brackets
>>> over docs.
>>>
>>>
>>> How do you feel with this?
>>>
>>> I remember Jie liked this approach...O:)
>>>    J.
>>
>>
>> Hello,
>>
>>
>> The patch looks good. I've checked over the generated docs and they look
>> better now. Nice!
>>
>>
>> Cheers,
>>
>>>
>>
>> --
>>
>> Jie Kang
>>