[fyi] [icedtea-web]failing unittest testSetFileNull

[Jie Kang]

----- Original Message -----
> Hello,
> 
> Sorry for the late reply, this seemed to have slipped out of my focus.
> 
> ----- Original Message -----
> > From: "Jie Kang" <jkang at redhat.com>
> > To: "Jiri Vanek" <jvanek at redhat.com>
> > Cc: "Lukasz Dracz" <ldracz at redhat.com>, distro-pkg-dev at openjdk.java.net
> > Sent: Thursday, September 11, 2014 12:08:54 PM
> > Subject: Re: [fyi] [icedtea-web]failing unittest testSetFileNull
> > 
> > No objections from me. Can you check what the behaviour is if an NPE get's
> > thrown? Does the program crash? or does it chain up somewhere and get dealt
> > with safely?
> 
> I've tested it and the program does not crash and just prompts the user to
> input a new file to save.
> 
> > 
> > If necessary maybe a new patch should make sure it can't crash from this
> > null
> > file behaviour. I think it's been coded so null file should never reach
> > those locations but safeguards should still be put in place.
> 
> Yeah it is coded with safeguards, prompting the user to input a new file and
> file destination whenever it
> is null before something that requires/uses the file in PolicyEditor.
> 
> Okay to push ? I know you both said it was good last time, but I figure I
> should check given that some time has passed.

Hello,

+1


Regards,

> 
> Regards,
> Lukasz Dracz
> 
> > 
> > 
> > Regards,
> > 
> > ----- Original Message -----
> > > On 09/11/2014 04:35 PM, Lukasz Dracz wrote:
> > > > Hello,
> > > >
> > > >> No removal.
> > > >>
> > > >>
> > > >> Ensure that it works correctly even with null parameter.
> > > >>
> > > >>
> > > >> There is no similar test.
> > > >>
> > > >> J.
> > > >>
> > > >
> > > > Okay, I made a check to see whether file was set to null. Also added
> > > > two
> > > > tests that test the methods that use file and check that they throw
> > > > NullPointerExceptions when file is set to null.
> > > >
> > > > Regards,
> > > > Lukasz Dracz
> > > >
> > > Sounds ok to me. But ping also Jie if he is ok with that.
> > > 
> > > 
> > > Thanx!
> > > 
> > > J.
> > > 
> > 
> > --
> > 
> > Jie Kang
> > 
> 

-- 

Jie Kang