$(PLUGIN_VERSION)

From bugzilla-daemon at icedtea.classpath.org Mon Sep 1 12:01:17 2014 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Mon, 01 Sep 2014 12:01:17 +0000 Subject: [Bug 1971] New: OpenJDK 64-Bit Server VM (24.65-b04 mixed mode linux-amd64 compressed oops) Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1971 Bug ID: 1971 Summary: OpenJDK 64-Bit Server VM (24.65-b04 mixed mode linux-amd64 compressed oops) Product: IcedTea Version: unspecified Hardware: x86_64 OS: Linux Status: NEW Severity: major Priority: P5 Component: AddVM Assignee: doko at ubuntu.com Reporter: pradeepkiruvale at gmail.com CC: unassigned at icedtea.classpath.org Hi, I was trying to run a tool called eclipseclp, it is a opensource tool based on prolog. After compilation it creates a java interface, I started the tool and pressed some options the following bug came up. # # A fatal error has been detected by the Java Runtime Environment: # # SIGSEGV (0xb) at pc=0x00007f14cace92e4, pid=23011, tid=139728282662720 # # JRE version: OpenJDK Runtime Environment (7.0_65-b32) (build 1.7.0_65-b32) # Java VM: OpenJDK 64-Bit Server VM (24.65-b04 mixed mode linux-amd64 compressed oops) # Problematic frame: # C [libeclipse.so+0x312e4] ec_emulate+0xe0e4 Regards, Pradeep -- You are receiving this mail because: You are on the CC list for the bug. -------------- next part -------------- An HTML attachment was scrubbed... URL: From helpcrypto at gmail.com Mon Sep 1 12:59:58 2014 From: helpcrypto at gmail.com (helpcrypto helpcrypto) Date: Mon, 1 Sep 2014 14:59:58 +0200 Subject: [rfc][icedtea-web][itweb-settings] Improve Icedtea-Web cache disk space In-Reply-To: <540180DB.4050109@gmx.de> References: <319590383.4051363.1404829211485.JavaMail.zimbra@redhat.com> <1222082700.26083069.1409081718997.JavaMail.zimbra@redhat.com> <982339162.26695106.1409162928407.JavaMail.zimbra@redhat.com> <958305698.27235425.1409240834908.JavaMail.zimbra@redhat.com> <1885159478.27899833.1409329251634.JavaMail.zimbra@redhat.com> <540180DB.4050109@gmx.de> Message-ID: On Sat, Aug 30, 2014 at 9:44 AM, Jacob Wisor wrote: > No no, do not start playing around with visible and hidden UI components. > It is even worse when they change their layout or start jumping around like > it is now. Generally, there is never any need to hide UI components. If > there seems to be, then either there is something wrong with the basic > design of a window or dialog, or you should have very good reasons to do > so. And, in this case there is surely *no* reason to hide any components > dynamically at all. Again, stick to disabling components. This should be > enough. > > @helpcrypto > Yes, it is against basic UI design principles to have hiding UI > components, unless there are really good reasons to do so. Can you point a style guide, or a gui-best-practices which advices on that? I have seen several GUIs wich only show the user what he needs to see, and I found them KISS-compliant Please do not start giving advice on something you do not know or have no > experience in. This only confuses young or new developers. > I didn't gave any advice, just gave my opinion (and said that it was only that many times). Unfortunately, because of your attempt to play around with hiding UI > components you have introduced a new bug. When "Limit cache size" is > checked and the spinner is 0 then all components for setting up the cache > location suddenly disappear. Limit checked, value=0->no cache, hence no need of location, compresion level or anything. It's not a bug. The warning under spinner informs about that. > And, as soon as the value becomes greater than 1, they become visible > again. This is very odd, weird, and confusing. Again, do not play around > with hiding UI components. > The reason why i suggested "no cach?" instead of 0. Is all this GUI discussion open (anyway) to discussion? @Lukas: i'll wait for patch update before testing (seems Jacob doesnt like what we did :P). Regards -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnu.andrew at redhat.com Tue Sep 2 04:00:00 2014 From: gnu.andrew at redhat.com (Andrew Hughes) Date: Tue, 2 Sep 2014 00:00:00 -0400 (EDT) Subject: IcedTea 2.5.2 Released: Back in the Groovy! In-Reply-To: <54018991.4080800@redhat.com> References: <20140829232404.GA30397@carrie.the212.com> <54018991.4080800@redhat.com> Message-ID: <1334143567.16378945.1409630400127.JavaMail.zimbra@redhat.com> ----- Original Message ----- > On 30/08/14 00:24, Andrew Hughes wrote: > > With the previous release, a > > number of Java tools and applications, including Groovy, were broken. > > This release should resolve these issues. > > That's interesting. What was this regression, and what was the fix? I > can't tell from the release notes. > > Andrew. > > It's: S8051012 [0], LP1360392 [1]: Regression in verifier for method call from inside of a branch Fix is [2]. [0] https://bugs.openjdk.java.net/browse/JDK-8051012 [1] https://bugs.launchpad.net/bugs/1360392 [2] http://icedtea.classpath.org/hg/icedtea7-forest/hotspot/rev/bad107a5d096 -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: 248BDC07 (https://keys.indymedia.org/) Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07 From bugzilla-daemon at icedtea.classpath.org Tue Sep 2 04:03:25 2014 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Tue, 02 Sep 2014 04:03:25 +0000 Subject: [Bug 1965] [IcedTea8] Allow builds on PaX kernels In-Reply-To: References: Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1965 Andrew John Hughes changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug. -------------- next part -------------- An HTML attachment was scrubbed... URL: From bugzilla-daemon at icedtea.classpath.org Tue Sep 2 04:03:26 2014 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Tue, 02 Sep 2014 04:03:26 +0000 Subject: [Bug 1282] [TRACKER] IcedTea 3.0.0 Release In-Reply-To: References: Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1282 Bug 1282 depends on bug 1965, which changed state. Bug 1965 Summary: [IcedTea8] Allow builds on PaX kernels http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1965 What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug. -------------- next part -------------- An HTML attachment was scrubbed... URL: From bugzilla-daemon at icedtea.classpath.org Tue Sep 2 04:03:41 2014 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Tue, 02 Sep 2014 04:03:41 +0000 Subject: [Bug 1282] [TRACKER] IcedTea 3.0.0 Release In-Reply-To: References: Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1282 Bug 1282 depends on bug 1970, which changed state. Bug 1970 Summary: [IcedTea8] Add AArch64 JIT port http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1970 What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug. -------------- next part -------------- An HTML attachment was scrubbed... URL: From bugzilla-daemon at icedtea.classpath.org Tue Sep 2 04:03:41 2014 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Tue, 02 Sep 2014 04:03:41 +0000 Subject: [Bug 1970] [IcedTea8] Add AArch64 JIT port In-Reply-To: References: Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1970 Andrew John Hughes changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug. -------------- next part -------------- An HTML attachment was scrubbed... URL: From bugzilla-daemon at icedtea.classpath.org Tue Sep 2 04:18:58 2014 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Tue, 02 Sep 2014 04:18:58 +0000 Subject: [Bug 1903] [IcedTea7] [REGRESSION] Bug reports now lack IcedTea version & distribution packaging information In-Reply-To: References: Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1903 Andrew John Hughes changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug. -------------- next part -------------- An HTML attachment was scrubbed... URL: From andrew at icedtea.classpath.org Tue Sep 2 04:20:13 2014 From: andrew at icedtea.classpath.org (andrew at icedtea.classpath.org) Date: Tue, 02 Sep 2014 04:20:13 +0000 Subject: /hg/release/icedtea7-forest-2.5: Added tag icedtea-2.5.2 for cha... Message-ID: changeset dfe93c56a5f6 in /hg/release/icedtea7-forest-2.5 details: http://icedtea.classpath.org/hg/release/icedtea7-forest-2.5?cmd=changeset;node=dfe93c56a5f6 author: andrew date: Fri Aug 29 21:08:27 2014 +0100 Added tag icedtea-2.5.2 for changeset de1fbcb08558 diffstat: .hgtags | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diffs (8 lines): diff -r de1fbcb08558 -r dfe93c56a5f6 .hgtags --- a/.hgtags Wed Jul 16 00:20:25 2014 +0100 +++ b/.hgtags Fri Aug 29 21:08:27 2014 +0100 @@ -486,3 +486,4 @@ fa242615607fa5f6cdd1ae93bc2fb9cc2100c179 jdk7u65-b18 64dbd70735c775bef1faf873e4bec65d73d597cb jdk7u65-b19 483622a291d726960c8ccca5650de9569f269d7a icedtea-2.5.1 +de1fbcb0855887e803b71a8da642c377c85c3780 icedtea-2.5.2 From andrew at icedtea.classpath.org Tue Sep 2 04:20:18 2014 From: andrew at icedtea.classpath.org (andrew at icedtea.classpath.org) Date: Tue, 02 Sep 2014 04:20:18 +0000 Subject: /hg/release/icedtea7-forest-2.5/corba: Added tag icedtea-2.5.2 f... Message-ID: changeset 1d178f96bc11 in /hg/release/icedtea7-forest-2.5/corba details: http://icedtea.classpath.org/hg/release/icedtea7-forest-2.5/corba?cmd=changeset;node=1d178f96bc11 author: andrew date: Fri Aug 29 21:08:14 2014 +0100 Added tag icedtea-2.5.2 for changeset 06663e4cfbbe diffstat: .hgtags | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diffs (8 lines): diff -r 06663e4cfbbe -r 1d178f96bc11 .hgtags --- a/.hgtags Wed Jul 16 00:20:14 2014 +0100 +++ b/.hgtags Fri Aug 29 21:08:14 2014 +0100 @@ -488,3 +488,4 @@ b7f66b9f9e8e099428ed7640a184f6135b77e40d jdk7u65-b18 50ddba8882e7e95150418a30bfc3ee62e3c28c6c jdk7u65-b19 895c6b10499623eaf8897a9ed0d28a34e4cd4a89 icedtea-2.5.1 +06663e4cfbbeade300222eeae55856940b2ffbee icedtea-2.5.2 From andrew at icedtea.classpath.org Tue Sep 2 04:20:25 2014 From: andrew at icedtea.classpath.org (andrew at icedtea.classpath.org) Date: Tue, 02 Sep 2014 04:20:25 +0000 Subject: /hg/release/icedtea7-forest-2.5/jaxp: Added tag icedtea-2.5.2 fo... Message-ID: changeset 771d2a0e90ae in /hg/release/icedtea7-forest-2.5/jaxp details: http://icedtea.classpath.org/hg/release/icedtea7-forest-2.5/jaxp?cmd=changeset;node=771d2a0e90ae author: andrew date: Fri Aug 29 21:08:15 2014 +0100 Added tag icedtea-2.5.2 for changeset d77720c6a36f diffstat: .hgtags | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diffs (8 lines): diff -r d77720c6a36f -r 771d2a0e90ae .hgtags --- a/.hgtags Wed Jul 16 00:20:15 2014 +0100 +++ b/.hgtags Fri Aug 29 21:08:15 2014 +0100 @@ -489,3 +489,4 @@ 45db678253587755df4a00066e42e2fce04bbb71 jdk7u65-b18 4e323af07c47061109fb5f585613b0cc4b4208ca jdk7u65-b19 59a1a3e441089798763016eedfcc066e6f437bd2 icedtea-2.5.1 +d77720c6a36f0b9c995e47badb8efddd0e8f2021 icedtea-2.5.2 From andrew at icedtea.classpath.org Tue Sep 2 04:20:31 2014 From: andrew at icedtea.classpath.org (andrew at icedtea.classpath.org) Date: Tue, 02 Sep 2014 04:20:31 +0000 Subject: /hg/release/icedtea7-forest-2.5/jaxws: Added tag icedtea-2.5.2 f... Message-ID: changeset c46dd3a579f0 in /hg/release/icedtea7-forest-2.5/jaxws details: http://icedtea.classpath.org/hg/release/icedtea7-forest-2.5/jaxws?cmd=changeset;node=c46dd3a579f0 author: andrew date: Fri Aug 29 21:08:17 2014 +0100 Added tag icedtea-2.5.2 for changeset aac78bd724c4 diffstat: .hgtags | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diffs (8 lines): diff -r aac78bd724c4 -r c46dd3a579f0 .hgtags --- a/.hgtags Wed Jul 16 00:20:16 2014 +0100 +++ b/.hgtags Fri Aug 29 21:08:17 2014 +0100 @@ -488,3 +488,4 @@ dedfc93eeb5f4b28ad1a91902a0676aef0937e42 jdk7u65-b18 db4cccbfd72fc265b736a273797963754434a7d2 jdk7u65-b19 b5384b2fb987fc5310167a9524b4a5ee1880f56b icedtea-2.5.1 +aac78bd724c437cefd9ba8abb280df34609ca936 icedtea-2.5.2 From andrew at icedtea.classpath.org Tue Sep 2 04:20:37 2014 From: andrew at icedtea.classpath.org (andrew at icedtea.classpath.org) Date: Tue, 02 Sep 2014 04:20:37 +0000 Subject: /hg/release/icedtea7-forest-2.5/langtools: Added tag icedtea-2.5... Message-ID: changeset fe8926c95af9 in /hg/release/icedtea7-forest-2.5/langtools details: http://icedtea.classpath.org/hg/release/icedtea7-forest-2.5/langtools?cmd=changeset;node=fe8926c95af9 author: andrew date: Fri Aug 29 21:08:26 2014 +0100 Added tag icedtea-2.5.2 for changeset f444e2a77643 diffstat: .hgtags | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diffs (8 lines): diff -r f444e2a77643 -r fe8926c95af9 .hgtags --- a/.hgtags Wed Jul 16 00:20:24 2014 +0100 +++ b/.hgtags Fri Aug 29 21:08:26 2014 +0100 @@ -488,3 +488,4 @@ 0f809f893588548a3b5c8441e28c9e0a62bc13ef jdk7u65-b18 eae289997f58ef6396dc323c3d5b93a56fb43573 jdk7u65-b19 4c827dc3de054b03008402f571ca645cbf7939e6 icedtea-2.5.1 +f444e2a7764393fa62cc1ec9dcaa3a9f7ebbc551 icedtea-2.5.2 From andrew at icedtea.classpath.org Tue Sep 2 04:20:43 2014 From: andrew at icedtea.classpath.org (andrew at icedtea.classpath.org) Date: Tue, 02 Sep 2014 04:20:43 +0000 Subject: /hg/release/icedtea7-forest-2.5/hotspot: 5 new changesets Message-ID: changeset e56036fb0f9e in /hg/release/icedtea7-forest-2.5/hotspot details: http://icedtea.classpath.org/hg/release/icedtea7-forest-2.5/hotspot?cmd=changeset;node=e56036fb0f9e author: andrew date: Thu Aug 28 15:26:22 2014 +0100 RH1015432: java-1.7.0-openjdk: Fails on PPC with StackOverflowError (revised fix for PPC32) Contributed-by: chphilli at redhat.com changeset c7d38df7983b in /hg/release/icedtea7-forest-2.5/hotspot details: http://icedtea.classpath.org/hg/release/icedtea7-forest-2.5/hotspot?cmd=changeset;node=c7d38df7983b author: andrew date: Tue Aug 26 17:14:48 2014 +0100 PR1948: Only try and symlink debuginfo if STRIP_POLICY is other than no_strip changeset 2266438ca53f in /hg/release/icedtea7-forest-2.5/hotspot details: http://icedtea.classpath.org/hg/release/icedtea7-forest-2.5/hotspot?cmd=changeset;node=2266438ca53f author: andrew date: Wed Aug 27 19:47:02 2014 +0100 PR1948: Fix indenting changeset 4ad43b271fd4 in /hg/release/icedtea7-forest-2.5/hotspot details: http://icedtea.classpath.org/hg/release/icedtea7-forest-2.5/hotspot?cmd=changeset;node=4ad43b271fd4 author: hseigel date: Tue Aug 05 23:10:45 2014 -0400 8051012: Regression in verifier for method call from inside of a branch Summary: Fix stackmap matching for branches. Reviewed-by: coleenp, lfoltan, acorn changeset 51c1c024f887 in /hg/release/icedtea7-forest-2.5/hotspot details: http://icedtea.classpath.org/hg/release/icedtea7-forest-2.5/hotspot?cmd=changeset;node=51c1c024f887 author: andrew date: Fri Aug 29 21:08:29 2014 +0100 Added tag icedtea-2.5.2 for changeset 4ad43b271fd4 diffstat: .hgtags | 1 + make/linux/makefiles/vm.make | 32 ++++++++++++++++---------------- src/os/linux/vm/os_linux.cpp | 10 +++++++++- src/share/vm/classfile/stackMapTable.cpp | 23 +++++++++++------------ src/share/vm/classfile/stackMapTable.hpp | 6 +++--- src/share/vm/classfile/verifier.cpp | 13 ++----------- src/share/vm/classfile/verifier.hpp | 16 ---------------- 7 files changed, 42 insertions(+), 59 deletions(-) diffs (262 lines): diff -r f0d8ef4d9f93 -r 51c1c024f887 .hgtags --- a/.hgtags Wed Aug 13 15:49:58 2014 +0100 +++ b/.hgtags Fri Aug 29 21:08:29 2014 +0100 @@ -708,3 +708,4 @@ d006213be74730453cf5c3ce31f1d1d505334419 jdk7u65-b18 1d8226b3e9896656451801393eb3ae394faeb638 jdk7u65-b19 02066294d005e81a81d3a01ec549716ebcc65723 icedtea-2.5.1 +4ad43b271fd439317ec422b5ea35ea3483d40922 icedtea-2.5.2 diff -r f0d8ef4d9f93 -r 51c1c024f887 make/linux/makefiles/vm.make --- a/make/linux/makefiles/vm.make Wed Aug 13 15:49:58 2014 +0100 +++ b/make/linux/makefiles/vm.make Fri Aug 29 21:08:29 2014 +0100 @@ -355,28 +355,28 @@ fi \ } - ifeq ($(ENABLE_FULL_DEBUG_SYMBOLS),1) - ifneq ($(STRIP_POLICY),no_strip) +ifeq ($(ENABLE_FULL_DEBUG_SYMBOLS),1) + ifneq ($(STRIP_POLICY),no_strip) $(QUIETLY) $(OBJCOPY) --only-keep-debug $@ $(LIBJVM_DEBUGINFO) $(QUIETLY) $(OBJCOPY) --add-gnu-debuglink=$(LIBJVM_DEBUGINFO) $@ - endif - ifeq ($(STRIP_POLICY),all_strip) + endif + ifeq ($(STRIP_POLICY),all_strip) $(QUIETLY) $(STRIP) $@ - else - ifeq ($(STRIP_POLICY),min_strip) + else + ifeq ($(STRIP_POLICY),min_strip) $(QUIETLY) $(STRIP) -g $@ - # implied else here is no stripping at all - endif - endif - endif - $(QUIETLY) [ -f $(LIBJVM_G_DEBUGINFO) ] || ln -s $(LIBJVM_DEBUGINFO) $(LIBJVM_G_DEBUGINFO) - ifeq ($(ZIP_DEBUGINFO_FILES),1) - ifneq ($(STRIP_POLICY),no_strip) - $(ZIPEXE) -q -y $(LIBJVM_DIZ) $(LIBJVM_DEBUGINFO) $(LIBJVM_G_DEBUGINFO) + # implied else here is no stripping at all + endif + endif + ifneq ($(STRIP_POLICY),no_strip) + $(QUIETLY) [ -f $(LIBJVM_G_DEBUGINFO) ] || ln -s $(LIBJVM_DEBUGINFO) $(LIBJVM_G_DEBUGINFO) + ifeq ($(ZIP_DEBUGINFO_FILES),1) + $(ZIPEXE) -q -y $(LIBJVM_DIZ) $(LIBJVM_DEBUGINFO) $(LIBJVM_G_DEBUGINFO) $(RM) $(LIBJVM_DEBUGINFO) $(LIBJVM_G_DEBUGINFO) [ -f $(LIBJVM_G_DIZ) ] || { ln -s $(LIBJVM_DIZ) $(LIBJVM_G_DIZ); } - endif - endif + endif + endif +endif DEST_SUBDIR = $(JDK_LIBDIR)/$(VM_SUBDIR) DEST_JVM = $(DEST_SUBDIR)/$(LIBJVM) diff -r f0d8ef4d9f93 -r 51c1c024f887 src/os/linux/vm/os_linux.cpp --- a/src/os/linux/vm/os_linux.cpp Wed Aug 13 15:49:58 2014 +0100 +++ b/src/os/linux/vm/os_linux.cpp Fri Aug 29 21:08:29 2014 +0100 @@ -4843,6 +4843,7 @@ pthread_mutex_init(&dl_mutex, NULL); +NOT_ZERO ( // If the pagesize of the VM is greater than 8K determine the appropriate // number of initial guard pages. The user can change this with the // command line arguments, if needed. @@ -4851,6 +4852,7 @@ StackRedPages = 1; StackShadowPages = round_to((StackShadowPages*Linux::vm_default_page_size()), vm_page_size()) / vm_page_size(); } + ) } // To install functions for atexit system call @@ -4903,10 +4905,16 @@ // size. Add a page for compiler2 recursion in main thread. // Add in 2*BytesPerWord times page size to account for VM stack during // class initialization depending on 32 or 64 bit VM. +NOT_ZERO ( os::Linux::min_stack_allowed = MAX2(os::Linux::min_stack_allowed, (size_t)(StackYellowPages+StackRedPages+StackShadowPages) * Linux::page_size() + (2*BytesPerWord COMPILER2_PRESENT(+1)) * Linux::vm_default_page_size()); - + ) +ZERO_ONLY ( + os::Linux::min_stack_allowed = MAX2(os::Linux::min_stack_allowed, + (size_t)(StackYellowPages+StackRedPages+StackShadowPages+ + 2*BytesPerWord COMPILER2_PRESENT(+1)) * Linux::page_size()); + ) size_t threadStackSizeInBytes = ThreadStackSize * K; if (threadStackSizeInBytes != 0 && threadStackSizeInBytes < os::Linux::min_stack_allowed) { diff -r f0d8ef4d9f93 -r 51c1c024f887 src/share/vm/classfile/stackMapTable.cpp --- a/src/share/vm/classfile/stackMapTable.cpp Wed Aug 13 15:49:58 2014 +0100 +++ b/src/share/vm/classfile/stackMapTable.cpp Fri Aug 29 21:08:29 2014 +0100 @@ -70,24 +70,26 @@ bool StackMapTable::match_stackmap( StackMapFrame* frame, int32_t target, - bool match, bool update, ErrorContext* ctx, TRAPS) const { + bool match, bool update, bool handler, ErrorContext* ctx, TRAPS) const { int index = get_index_from_offset(target); - return match_stackmap(frame, target, index, match, update, ctx, THREAD); + return match_stackmap(frame, target, index, match, update, handler, ctx, THREAD); } // Match and/or update current_frame to the frame in stackmap table with // specified offset and frame index. Return true if the two frames match. +// handler is true if the frame in stackmap_table is for an exception handler. // -// The values of match and update are: _match__update_ +// The values of match and update are: _match__update__handler // -// checking a branch target/exception handler: true false +// checking a branch target: true false false +// checking an exception handler: true false true // linear bytecode verification following an -// unconditional branch: false true +// unconditional branch: false true false // linear bytecode verification not following an -// unconditional branch: true true +// unconditional branch: true true false bool StackMapTable::match_stackmap( StackMapFrame* frame, int32_t target, int32_t frame_index, - bool match, bool update, ErrorContext* ctx, TRAPS) const { + bool match, bool update, bool handler, ErrorContext* ctx, TRAPS) const { if (frame_index < 0 || frame_index >= _frame_count) { *ctx = ErrorContext::missing_stackmap(frame->offset()); frame->verifier()->verify_error( @@ -98,11 +100,9 @@ StackMapFrame *stackmap_frame = _frame_array[frame_index]; bool result = true; if (match) { - // when checking handler target, match == true && update == false - bool is_exception_handler = !update; // Has direct control flow from last instruction, need to match the two // frames. - result = frame->is_assignable_to(stackmap_frame, is_exception_handler, + result = frame->is_assignable_to(stackmap_frame, handler, ctx, CHECK_VERIFY_(frame->verifier(), result)); } if (update) { @@ -126,7 +126,7 @@ StackMapFrame* frame, int32_t target, TRAPS) const { ErrorContext ctx; bool match = match_stackmap( - frame, target, true, false, &ctx, CHECK_VERIFY(frame->verifier())); + frame, target, true, false, false, &ctx, CHECK_VERIFY(frame->verifier())); if (!match || (target < 0 || target >= _code_length)) { frame->verifier()->verify_error(ctx, "Inconsistent stackmap frames at branch target %d", target); @@ -134,7 +134,6 @@ } // check if uninitialized objects exist on backward branches check_new_object(frame, target, CHECK_VERIFY(frame->verifier())); - frame->verifier()->update_furthest_jump(target); } void StackMapTable::check_new_object( diff -r f0d8ef4d9f93 -r 51c1c024f887 src/share/vm/classfile/stackMapTable.hpp --- a/src/share/vm/classfile/stackMapTable.hpp Wed Aug 13 15:49:58 2014 +0100 +++ b/src/share/vm/classfile/stackMapTable.hpp Fri Aug 29 21:08:29 2014 +0100 @@ -1,5 +1,5 @@ /* - * Copyright (c) 2003, 2012, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2003, 2014, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -74,12 +74,12 @@ // specified offset. Return true if the two frames match. bool match_stackmap( StackMapFrame* current_frame, int32_t offset, - bool match, bool update, ErrorContext* ctx, TRAPS) const; + bool match, bool update, bool handler, ErrorContext* ctx, TRAPS) const; // Match and/or update current_frame to the frame in stackmap table with // specified offset and frame index. Return true if the two frames match. bool match_stackmap( StackMapFrame* current_frame, int32_t offset, int32_t frame_index, - bool match, bool update, ErrorContext* ctx, TRAPS) const; + bool match, bool update, bool handler, ErrorContext* ctx, TRAPS) const; // Check jump instructions. Make sure there are no uninitialized // instances on backward branch. diff -r f0d8ef4d9f93 -r 51c1c024f887 src/share/vm/classfile/verifier.cpp --- a/src/share/vm/classfile/verifier.cpp Wed Aug 13 15:49:58 2014 +0100 +++ b/src/share/vm/classfile/verifier.cpp Fri Aug 29 21:08:29 2014 +0100 @@ -630,8 +630,6 @@ // flow from current instruction to the next // instruction in sequence - set_furthest_jump(0); - Bytecodes::Code opcode; while (!bcs.is_last_bytecode()) { // Check for recursive re-verification before each bytecode. @@ -1788,7 +1786,7 @@ // If matched, current_frame will be updated by this method. bool matches = stackmap_table->match_stackmap( current_frame, this_offset, stackmap_index, - !no_control_flow, true, &ctx, CHECK_VERIFY_(this, 0)); + !no_control_flow, true, false, &ctx, CHECK_VERIFY_(this, 0)); if (!matches) { // report type error verify_error(ctx, "Instruction type does not match stack map"); @@ -1835,7 +1833,7 @@ } ErrorContext ctx; bool matches = stackmap_table->match_stackmap( - new_frame, handler_pc, true, false, &ctx, CHECK_VERIFY(this)); + new_frame, handler_pc, true, false, true, &ctx, CHECK_VERIFY(this)); if (!matches) { verify_error(ctx, "Stack map does not match the one at " "exception handler %d", handler_pc); @@ -2243,13 +2241,6 @@ return; } - // Make sure that this call is not jumped over. - if (bci < furthest_jump()) { - verify_error(ErrorContext::bad_code(bci), - "Bad method call from inside of a branch"); - return; - } - // Make sure that this call is not done from within a TRY block because // that can result in returning an incomplete object. Simply checking // (bci >= start_pc) also ensures that this call is not done after a TRY diff -r f0d8ef4d9f93 -r 51c1c024f887 src/share/vm/classfile/verifier.hpp --- a/src/share/vm/classfile/verifier.hpp Wed Aug 13 15:49:58 2014 +0100 +++ b/src/share/vm/classfile/verifier.hpp Fri Aug 29 21:08:29 2014 +0100 @@ -256,9 +256,6 @@ ErrorContext _error_context; // contains information about an error - // Used to detect illegal jumps over calls to super() and this() in ctors. - int32_t _furthest_jump; - void verify_method(methodHandle method, TRAPS); char* generate_code_data(methodHandle m, u4 code_length, TRAPS); void verify_exception_handler_table(u4 code_length, char* code_data, @@ -402,19 +399,6 @@ TypeOrigin ref_ctx(const char* str, TRAPS); - // Keep track of the furthest branch done in a method to make sure that - // there are no branches over calls to super() or this() from inside of - // a constructor. - int32_t furthest_jump() { return _furthest_jump; } - - void set_furthest_jump(int32_t target) { - _furthest_jump = target; - } - - void update_furthest_jump(int32_t target) { - if (target > _furthest_jump) _furthest_jump = target; - } - }; inline int ClassVerifier::change_sig_to_verificationType( From bugzilla-daemon at icedtea.classpath.org Tue Sep 2 04:20:49 2014 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Tue, 02 Sep 2014 04:20:49 +0000 Subject: [Bug 1948] [IcedTea7] Only try and symlink debuginfo if STRIP_POLICY is other than no_strip In-Reply-To: References: Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1948 --- Comment #4 from hg commits --- details: http://icedtea.classpath.org//hg/release/icedtea7-forest-2.5/hotspot?cmd=changeset;node=c7d38df7983b author: andrew date: Tue Aug 26 17:14:48 2014 +0100 PR1948: Only try and symlink debuginfo if STRIP_POLICY is other than no_strip -- You are receiving this mail because: You are on the CC list for the bug. -------------- next part -------------- An HTML attachment was scrubbed... URL: From bugzilla-daemon at icedtea.classpath.org Tue Sep 2 04:21:01 2014 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Tue, 02 Sep 2014 04:21:01 +0000 Subject: [Bug 1948] [IcedTea7] Only try and symlink debuginfo if STRIP_POLICY is other than no_strip In-Reply-To: References: Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1948 --- Comment #5 from hg commits --- details: http://icedtea.classpath.org//hg/release/icedtea7-forest-2.5/hotspot?cmd=changeset;node=2266438ca53f author: andrew date: Wed Aug 27 19:47:02 2014 +0100 PR1948: Fix indenting -- You are receiving this mail because: You are on the CC list for the bug. -------------- next part -------------- An HTML attachment was scrubbed... URL: From andrew at icedtea.classpath.org Tue Sep 2 04:21:09 2014 From: andrew at icedtea.classpath.org (andrew at icedtea.classpath.org) Date: Tue, 02 Sep 2014 04:21:09 +0000 Subject: /hg/release/icedtea7-forest-2.5/jdk: 3 new changesets Message-ID: changeset fe87c474cd59 in /hg/release/icedtea7-forest-2.5/jdk details: http://icedtea.classpath.org/hg/release/icedtea7-forest-2.5/jdk?cmd=changeset;node=fe87c474cd59 author: weijun date: Thu Jul 10 14:25:23 2014 +0800 8049480: Current versions of Java can't verify jars signed and timestamped with Java 9 Reviewed-by: xuelei, mullan changeset 1e6a8564aa34 in /hg/release/icedtea7-forest-2.5/jdk details: http://icedtea.classpath.org/hg/release/icedtea7-forest-2.5/jdk?cmd=changeset;node=1e6a8564aa34 author: andrew date: Fri Aug 29 18:35:06 2014 +0100 Bump package version to 2.5.2 changeset 229136ffcb00 in /hg/release/icedtea7-forest-2.5/jdk details: http://icedtea.classpath.org/hg/release/icedtea7-forest-2.5/jdk?cmd=changeset;node=229136ffcb00 author: andrew date: Fri Aug 29 21:08:23 2014 +0100 Added tag icedtea-2.5.2 for changeset 1e6a8564aa34 diffstat: .hgtags | 1 + make/jdk_generic_profile.sh | 2 +- src/share/classes/com/sun/crypto/provider/OAEPParameters.java | 19 +- src/share/classes/sun/security/pkcs/SignerInfo.java | 20 +- src/share/classes/sun/security/util/SignatureFileVerifier.java | 4 +- src/share/classes/sun/security/x509/AlgorithmId.java | 17 + test/sun/security/tools/jarsigner/TimestampAlg.java | 156 ++++++++++ 7 files changed, 182 insertions(+), 37 deletions(-) diffs (306 lines): diff -r c07c208fe259 -r 229136ffcb00 .hgtags --- a/.hgtags Thu Aug 14 19:44:12 2014 +0100 +++ b/.hgtags Fri Aug 29 21:08:23 2014 +0100 @@ -472,3 +472,4 @@ 7f7430459adfe7b7fb65da8c3fac2ac5e3495ea1 jdk7u65-b18 ba6cef21c369076be97dd8133fd4a158cd486bd8 jdk7u65-b19 d6d4b6c9f5b48254a6dc1430dee9ee85d7f86b97 icedtea-2.5.1 +1e6a8564aa3400fe8f84085c908f55a942d426f0 icedtea-2.5.2 diff -r c07c208fe259 -r 229136ffcb00 make/jdk_generic_profile.sh --- a/make/jdk_generic_profile.sh Thu Aug 14 19:44:12 2014 +0100 +++ b/make/jdk_generic_profile.sh Fri Aug 29 21:08:23 2014 +0100 @@ -573,7 +573,7 @@ # IcedTea versioning export ICEDTEA_NAME="IcedTea" -export PACKAGE_VERSION="2.5.2pre01" +export PACKAGE_VERSION="2.5.2" export DERIVATIVE_ID="${ICEDTEA_NAME} ${PACKAGE_VERSION}" if [ -e ${jdk_topdir} ] ; then diff -r c07c208fe259 -r 229136ffcb00 src/share/classes/com/sun/crypto/provider/OAEPParameters.java --- a/src/share/classes/com/sun/crypto/provider/OAEPParameters.java Thu Aug 14 19:44:12 2014 +0100 +++ b/src/share/classes/com/sun/crypto/provider/OAEPParameters.java Fri Aug 29 21:08:23 2014 +0100 @@ -106,20 +106,6 @@ } } - private static String convertToStandardName(String internalName) { - if (internalName.equals("SHA")) { - return "SHA-1"; - } else if (internalName.equals("SHA256")) { - return "SHA-256"; - } else if (internalName.equals("SHA384")) { - return "SHA-384"; - } else if (internalName.equals("SHA512")) { - return "SHA-512"; - } else { - return internalName; - } - } - protected void engineInit(byte[] encoded) throws IOException { DerInputStream der = new DerInputStream(encoded); @@ -131,7 +117,7 @@ DerValue data = datum[i]; if (data.isContextSpecific((byte) 0x00)) { // hash algid - mdName = convertToStandardName(AlgorithmId.parse + mdName = AlgorithmId.getStandardDigestName(AlgorithmId.parse (data.data.getDerValue()).getName()); } else if (data.isContextSpecific((byte) 0x01)) { // mgf algid @@ -141,7 +127,8 @@ } AlgorithmId params = AlgorithmId.parse( new DerValue(val.getEncodedParams())); - String mgfDigestName = convertToStandardName(params.getName()); + String mgfDigestName = AlgorithmId.getStandardDigestName( + params.getName()); if (mgfDigestName.equals("SHA-1")) { mgfSpec = MGF1ParameterSpec.SHA1; } else if (mgfDigestName.equals("SHA-256")) { diff -r c07c208fe259 -r 229136ffcb00 src/share/classes/sun/security/pkcs/SignerInfo.java --- a/src/share/classes/sun/security/pkcs/SignerInfo.java Thu Aug 14 19:44:12 2014 +0100 +++ b/src/share/classes/sun/security/pkcs/SignerInfo.java Fri Aug 29 21:08:23 2014 +0100 @@ -273,24 +273,6 @@ return certList; } - // Copied from com.sun.crypto.provider.OAEPParameters. - private static String convertToStandardName(String internalName) { - if (internalName.equals("SHA")) { - return "SHA-1"; - } else if (internalName.equals("SHA224")) { - return "SHA-224"; - } else if (internalName.equals("SHA256")) { - return "SHA-256"; - } else if (internalName.equals("SHA384")) { - return "SHA-384"; - } else if (internalName.equals("SHA512")) { - return "SHA-512"; - } else { - return internalName; - } - } - - /* Returns null if verify fails, this signerInfo if verify succeeds. */ SignerInfo verify(PKCS7 block, byte[] data) @@ -330,7 +312,7 @@ return null; MessageDigest md = MessageDigest.getInstance( - convertToStandardName(digestAlgname)); + AlgorithmId.getStandardDigestName(digestAlgname)); byte[] computedMessageDigest = md.digest(data); if (messageDigest.length != computedMessageDigest.length) diff -r c07c208fe259 -r 229136ffcb00 src/share/classes/sun/security/util/SignatureFileVerifier.java --- a/src/share/classes/sun/security/util/SignatureFileVerifier.java Thu Aug 14 19:44:12 2014 +0100 +++ b/src/share/classes/sun/security/util/SignatureFileVerifier.java Fri Aug 29 21:08:23 2014 +0100 @@ -39,6 +39,7 @@ import sun.misc.BASE64Decoder; import sun.security.jca.Providers; +import sun.security.x509.AlgorithmId; public class SignatureFileVerifier { @@ -613,7 +614,8 @@ throws NoSuchAlgorithmException, SignatureException { MessageDigest md = - MessageDigest.getInstance(token.getHashAlgorithm().getName()); + MessageDigest.getInstance(AlgorithmId.getStandardDigestName( + token.getHashAlgorithm().getName())); if (!Arrays.equals(token.getHashedMessage(), md.digest(signature))) { throw new SignatureException("Signature timestamp (#" + diff -r c07c208fe259 -r 229136ffcb00 src/share/classes/sun/security/x509/AlgorithmId.java --- a/src/share/classes/sun/security/x509/AlgorithmId.java Thu Aug 14 19:44:12 2014 +0100 +++ b/src/share/classes/sun/security/x509/AlgorithmId.java Fri Aug 29 21:08:23 2014 +0100 @@ -940,4 +940,21 @@ } return null; } + + // Copied from com.sun.crypto.provider.OAEPParameters.convertToStandardName() + public static String getStandardDigestName(String internalName) { + if (internalName.equals("SHA")) { + return "SHA-1"; + } else if (internalName.equals("SHA224")) { + return "SHA-224"; + } else if (internalName.equals("SHA256")) { + return "SHA-256"; + } else if (internalName.equals("SHA384")) { + return "SHA-384"; + } else if (internalName.equals("SHA512")) { + return "SHA-512"; + } else { + return internalName; + } + } } diff -r c07c208fe259 -r 229136ffcb00 test/sun/security/tools/jarsigner/TimestampAlg.java --- /dev/null Thu Jan 01 00:00:00 1970 +0000 +++ b/test/sun/security/tools/jarsigner/TimestampAlg.java Fri Aug 29 21:08:23 2014 +0100 @@ -0,0 +1,156 @@ +/* + * Copyright (c) 2014, Oracle and/or its affiliates. All rights reserved. + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + * + * This code is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 only, as + * published by the Free Software Foundation. + * + * This code is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * version 2 for more details (a copy is included in the LICENSE file that + * accompanied this code). + * + * You should have received a copy of the GNU General Public License version + * 2 along with this work; if not, write to the Free Software Foundation, + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. + * + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA + * or visit www.oracle.com if you need additional information or have any + * questions. + */ + +/** + * @test + * @bug 8049480 + * @summary Current versions of Java can't verify jars signed and timestamped with Java 9 + */ + +import java.io.InputStream; +import java.nio.file.Files; +import java.nio.file.Paths; +import java.util.jar.JarEntry; +import java.util.jar.JarFile; + +public class TimestampAlg { + + public static void main(String[] args) throws Exception { + // This is a very simple jar file signed by JDK 9 with a timestamp + // using the SHA-256 message digest algorithm. + String var = + "504b0304140008080800c28ee844000000000000000000000000140000004d45" + + "54412d494e462f4d414e49464553542e4d4615cd4d0b82301c80f1fb60df61c7" + + "42666a9928749846f4aa8924745cf9d716b6c59c48df3ebd3e87df73e152d4d0" + + "195a82ee849211716d07a344033750d1f83785d076e830b8be1fb80e15d28096" + + "bca535ef4c058fbe21b34cf3670b2451faab3437a333c708a3947f20220ca362" + + "cfa8e7afe95634e32b22af821df2d6786d5ff637cf3abfe3f05e4190a42779b5" + + "76470532cbd56a798105db4cd01f504b07082c3740c69c000000a6000000504b" + + "0304140008080800c28ee8440000000000000000000000000f0000004d455441" + + "2d494e462f4f4c442e534675cf416f823018c6f13b09dfa1c7ed50575014493c" + + "80bae8a6a091383db6f082955a595b86ecd34fb3db92dd9ed32fff67c74b494d" + + "a300ef41697e9501727ac4b6768b10bbde10cf7809dae03595bcf81d5ce2d018" + + "c5596340072872bdecd02554f17c70f16fc730cfb4a8c6b0ad934fdfb6d0e854" + + "fbb794ecd52eeecbe5e45f394071bd9ef30c34131f87a3e956c561efb0938e56" + + "b7573d5c6cd3599bbe2ddd28acfafe9d992aa006721c758fe2718fe0b6753c6f" + + "e410cca50125a9c005d52607d694e82951341380a657555f1535f7a3cfb6655b" + + "31bd4080c2bf55016a98a8f2512948f7e5968dfbbe495fcca6383bdfe753a467" + + "90ca41a297861544cd270fe807504b0708521a35550201000048010000504b03" + + "04140008080800c28ee844000000000000000000000000100000004d4554412d" + + "494e462f4f4c442e52534185947b38d37d1fc7fdb61923530eb39e688622a77e" + + "5b666ab9939c9544c831ee39d42c9511e576d8c8b9876745b5743b5414268718" + + "b969548e95d61c2224b47423a648393d73dd5d4fe5b9afe7f9f3f3b9deefeff5" + + "bd3e9ff7e7053210ba708476bc55fc6719400292c340a8800cc4460800e06441" + + "1938c23bde0af083c22080b81828fd5d08e430200f4006a41664003772a01000" + + "028145a66e3cba6af9a601a44516246e1d2805873ac1a0f2d093545f70b3920c" + + "ce00248246e04ec20e02e8262a09200e6ff0adfc2f3d0350fbf149d12fa00c40" + + "564cd497823000406cb4ef6571fdec06c95a370fde860e89425861e16e0b19a1" + + "4c6c4f52d6102dd3a6bf45e740d9a0bed342ee5e832885fa1a979dc7e6161253" + + "4c2cda0362e5ec02ae440e44e80c56bffc4ab4f349f3b1f6bddae8c2979fca4b" + + "5e7e46ac2fa529481dd8d750a26dcd7d74deb8dde7fc70c072465af0a1e359af" + + "4cf4b1aaa14fc4238cee096ca3133575d52179a7e7da8990f6ed5da71ca84c37" + + "2d3117c356b1ac2cdde3c8600ead44f8878b2f8f10831f4d5d590a28d95b316c" + + "cf456277a83533e12ea42a14c8fc05da6b2483b74ab7c4e70a2dd60f417d2f97" + + "3359bb233e3d6b5ab60202e7bd7b4fd7f228febd1f0403b0c62f4190b69264bf" + + "72426589ab516d00040a880137b0200654114d4d050943c11490e82d88b38ecd" + + "26a42c027cd749ffe67955e7d9357b81aece4e877d49ee62b8afeed7a755fa9e" + + "786d6edc5d7e5ae3603e5d6e39d0cbc74300c35eb354282842a183159763c67a" + + "35b0b1ac1929e7b8ad510da5aa454d5eb3034cf11d27f594326384873f7c8949" + + "1a7f4a3cfccb892faf873c621292bd597072cdcd732d1ee7490e611ec28c90f9" + + "81bbd71ef0e4b50c4e93869c9af8c9d3d154169bbf8dff7aa706ebac1f6d2589" + + "8078532a9867e31d7f576365bc0c6c132fb7719b58d88ebcf438715768aea361" + + "f7017f614acfaf465e6d794b84e317b2937d66a8f5cea13666d541cce02705a8" + + "cef2d6d2f69b96ac88fec9998228a7c1d96d09c315b29797ecda02250dc7383a" + + "6f2bf75b0f17d48c07afa48c640d3478dd3ad18963c0712003ae27ca3a885a9b" + + "bcef71fef1027e8e228c01885dede0446717674996f8f413f59a5c3f91a001c0" + + "b632f78891424ce58a58df39727a6cc492ea4c94d5f23f6ad1276561d6eb057f" + + "befab3e5baff5dec50224a891fb49c29ab6cd6cab3f7731d097fc3d65e949b33" + + "b7a578f0b379e47a98c0a91b5fb0ce685952a78afc5cfa0e373df4a035c15132" + + "bb62a6387ad8caaadab680b8a169805e49b69e5ad8409de9b7079b6def2af45a" + + "dada5e7cdee4b5359892d1803dfc765dd18849fd0bf44b64866ed654fc117ea6" + + "5e6b1922eff99b73f0c77257e994d307defc9a29cedd1ac7be68a626d6edf96e" + + "c692bdf22ee792369dd535a0dfa7d711396996f692895df223eaaa5f47414f45" + + "b2c3b39d65772575c5cf4a437319b00990011b834b7f1b0c623d048963c07a44" + + "4dfe4f60813d12b5b87f0b16ea0f6e0096e30973075d454238d411260ee2d6a8" + + "61aa68a6bb3119ab837aaa39abd612eab39f9da4665c977e0cff019201a19384" + + "d3222b5a160ffe07340620c10d220998e65d3431411e13916b4e44ae191143fa" + + "be91cb1605ff6d2db96470d220e2af3c40f6ed5d032ee2cfe022bafd240fa1fd" + + "5f6e3567dd9071543e381b57bdd80cb1575a376abcc947495167e61e6e32a1ae" + + "93d416c8bc197b6bda347e6bcc6553839ed0a78d7ac28d57f2f7f8cd857d14e4" + + "497caa1cd34e1829aa7574aa3984ad39934e765598bdf0356c31a8f5c4a316d6" + + "c6beedf3add584c5769a6901a7836d3b32e3a03c58c739a6969e0260a002f463" + + "2773e84174c7faa41086e0d5d0ceaefc4df5a443d4e8af8a462dd67181ce11be" + + "a6ef64ce907252a0d0e6f03ef467e6763c244c48574856017d294607d3f87d5b" + + "0eb9eba2c60dc6c70dddfb837914babf172574ef99a4bb1e361353de4d95c576" + + "c494e1e9bce62d4fd08ad5e731691d1895636525bb79d76b2f1ce07d1604aa95" + + "8d9dfc8b5b6ee01110b3ca2d75181a44c528300ede3c612715c04d7baf786a18" + + "87b5f95861180fa256055b006005b67aa0923a70405c5c022af903f0187b3458" + + "748cc0bdfeac15adcb7029a17883d0f5ef80573caa61574bb66747bc61aae3ca" + + "0c3fe8bcd223d54fd7f5a2270843f9559a99f76aff45d965ba91374fa05a706f" + + "479416999389d4e29eb74a1984a30face935fd2118a580a3cd5a6567c2e21e92" + + "bb358c54822aaa049a8f47712889ee4507ae4ffd150ba50f444f99701c49fa97" + + "72edc44e69cfcda9cffc9f75c49fdb6b28b9699a2567289979dfd42664626232" + + "75b682be2baf3856623e37bb47c15e3e8e084771e4f3e7b53265efbc48e616cd" + + "ed18c4a546de3f5bd793857c9c7a99615161b7cdcca53fa1d4c119a33bb150a4" + + "6e4996450724eed76ae3d2dbc02f147228353241beba27e585a3dd556b8e5c2e" + + "5f4a3328fd214663223ec27d4fb134873a85630026a204ee5e059ee29a807f3f" + + "82ffcd3b2437cc1bf95a6813dec5195b38cd227002c6f5f53dcd1212f7182038" + + "9877b7ddf1ff2c0c65993b9524d3b41eca82ded2b951471c871b741fddd9fdc7" + + "70a79bb91c3d91f3a9aa8f880ec22099418c65654a7e3a25c4d8925e98e1e390" + + "1437e8767c9debf521e5c93ad5026ab8e5ef9696983ba6d0335e17de6ba65747" + + "91a0fb6ecdf20bde55874082a7f19b4332ddbba24d4eb98a9b0e55e4294f37be" + + "edd62a3e3ebccf8ded49f3a029fa76becf3389a386d2d62faca4f85cbb643489" + + "2e2abfd66dbe727f4fe28d8f8d551e0f8f4c8eda346c66d1bc6fa7a68eabdfb7" + + "0d0a34e65910bba73413ad8680dfaa473753ae9e2fd032d8f6cc66d19c57e679" + + "7fcc33cce8df504b0708267c480f1b08000030090000504b0304140008080800" + + "b78ee844000000000000000000000000090004004d4554412d494e462ffeca00" + + "000300504b0708000000000200000000000000504b0304140008080800b78ee8" + + "440000000000000000000000000100000041f3cb2fc9c8cc4be70200504b0708" + + "3c0a34d30a00000008000000504b01021400140008080800c28ee8442c3740c6" + + "9c000000a60000001400000000000000000000000000000000004d4554412d49" + + "4e462f4d414e49464553542e4d46504b01021400140008080800c28ee844521a" + + "355502010000480100000f00000000000000000000000000de0000004d455441" + + "2d494e462f4f4c442e5346504b01021400140008080800c28ee844267c480f1b" + + "0800003009000010000000000000000000000000001d0200004d4554412d494e" + + "462f4f4c442e525341504b01021400140008080800b78ee84400000000020000" + + "00000000000900040000000000000000000000760a00004d4554412d494e462f" + + "feca0000504b01021400140008080800b78ee8443c0a34d30a00000008000000" + + "0100000000000000000000000000b30a000041504b0506000000000500050027" + + "010000ec0a00000000"; + byte[] data = new byte[var.length()/2]; + for (int i=0; i References: Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1948 Andrew John Hughes changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug. -------------- next part -------------- An HTML attachment was scrubbed... URL: From ptisnovs at icedtea.classpath.org Tue Sep 2 09:24:43 2014 From: ptisnovs at icedtea.classpath.org (ptisnovs at icedtea.classpath.org) Date: Tue, 02 Sep 2014 09:24:43 +0000 Subject: /hg/gfx-test: Yet another ten new tests added into BitBltBuffere... Message-ID: changeset bc3ca0c7b1e7 in /hg/gfx-test details: http://icedtea.classpath.org/hg/gfx-test?cmd=changeset;node=bc3ca0c7b1e7 author: Pavel Tisnovsky date: Tue Sep 02 11:25:53 2014 +0200 Yet another ten new tests added into BitBltBufferedImageOp. diffstat: ChangeLog | 5 + src/org/gfxtest/testsuites/BitBltBufferedImageOp.java | 170 ++++++++++++++++++ 2 files changed, 175 insertions(+), 0 deletions(-) diffs (192 lines): diff -r c70c07e559a4 -r bc3ca0c7b1e7 ChangeLog --- a/ChangeLog Tue Aug 26 11:15:55 2014 +0200 +++ b/ChangeLog Tue Sep 02 11:25:53 2014 +0200 @@ -1,3 +1,8 @@ +2014-09-02 Pavel Tisnovsky + + * src/org/gfxtest/testsuites/BitBltBufferedImageOp.java: + Yet another ten new tests added into BitBltBufferedImageOp. + 2014-08-26 Pavel Tisnovsky * src/org/gfxtest/testsuites/BitBltBufferedImageOp.java: diff -r c70c07e559a4 -r bc3ca0c7b1e7 src/org/gfxtest/testsuites/BitBltBufferedImageOp.java --- a/src/org/gfxtest/testsuites/BitBltBufferedImageOp.java Tue Aug 26 11:15:55 2014 +0200 +++ b/src/org/gfxtest/testsuites/BitBltBufferedImageOp.java Tue Sep 02 11:25:53 2014 +0200 @@ -3458,6 +3458,176 @@ } /** + * Test basic BitBlt operation for buffered image with type {@link BufferedImage#TYPE_3BYTE_BGR}. + * + * @param image + * image used as a destination for BitBlt-type operations + * @param graphics2d + * graphics canvas + * @param rasterOp + * selected raster operation + * @return test result status - PASSED, FAILED or ERROR + */ + protected TestResult doBitBltHorizontalRedGradientType3ByteBGR(TestImage image, Graphics2D graphics2d, + BufferedImageOp rasterOp) + { + return CommonBitmapOperations.doBitBltTestWithHorizontalRedGradientImage(image, graphics2d, BufferedImage.TYPE_3BYTE_BGR, rasterOp); + } + + /** + * Test basic BitBlt operation for buffered image with type {@link BufferedImage#TYPE_4BYTE_ABGR}. + * + * @param image + * image used as a destination for BitBlt-type operations + * @param graphics2d + * graphics canvas + * @param rasterOp + * selected raster operation + * @return test result status - PASSED, FAILED or ERROR + */ + protected TestResult doBitBltHorizontalRedGradientType4ByteABGR(TestImage image, Graphics2D graphics2d, + BufferedImageOp rasterOp) + { + return CommonBitmapOperations.doBitBltTestWithHorizontalRedGradientImage(image, graphics2d, BufferedImage.TYPE_4BYTE_ABGR, rasterOp); + } + + /** + * Test basic BitBlt operation for buffered image with type {@link BufferedImage#TYPE_4BYTE_ABGR_PRE}. + * + * @param image + * image used as a destination for BitBlt-type operations + * @param graphics2d + * graphics canvas + * @param rasterOp + * selected raster operation + * @return test result status - PASSED, FAILED or ERROR + */ + protected TestResult doBitBltHorizontalRedGradientType4ByteABGR_Pre(TestImage image, Graphics2D graphics2d, + BufferedImageOp rasterOp) + { + return CommonBitmapOperations.doBitBltTestWithHorizontalRedGradientImage(image, graphics2d, BufferedImage.TYPE_4BYTE_ABGR_PRE, rasterOp); + } + + /** + * Test basic BitBlt operation for buffered image with type {@link BufferedImage#TYPE_BYTE_BINARY}. + * + * @param image + * image used as a destination for BitBlt-type operations + * @param graphics2d + * graphics canvas + * @param rasterOp + * selected raster operation + * @return test result status - PASSED, FAILED or ERROR + */ + protected TestResult doBitBltHorizontalRedGradientTypeByteBinary(TestImage image, Graphics2D graphics2d, + BufferedImageOp rasterOp) + { + return CommonBitmapOperations.doBitBltTestWithHorizontalRedGradientImage(image, graphics2d, BufferedImage.TYPE_BYTE_BINARY, rasterOp); + } + + /** + * Test basic BitBlt operation for buffered image with type {@link BufferedImage#TYPE_BYTE_INDEXED}. + * + * @param image + * image used as a destination for BitBlt-type operations + * @param graphics2d + * graphics canvas + * @param rasterOp + * selected raster operation + * @return test result status - PASSED, FAILED or ERROR + */ + protected TestResult doBitBltHorizontalRedGradientTypeByteIndexed(TestImage image, Graphics2D graphics2d, + BufferedImageOp rasterOp) + { + return CommonBitmapOperations.doBitBltTestWithHorizontalRedGradientImage(image, graphics2d, BufferedImage.TYPE_BYTE_INDEXED, rasterOp); + } + + /** + * Test basic BitBlt operation for buffered image with type {@link BufferedImage#TYPE_BYTE_GRAY}. + * + * @param image + * image used as a destination for BitBlt-type operations + * @param graphics2d + * graphics canvas + * @param rasterOp + * selected raster operation + * @return test result status - PASSED, FAILED or ERROR + */ + protected TestResult doBitBltHorizontalRedGradientTypeByteGray(TestImage image, Graphics2D graphics2d, + BufferedImageOp rasterOp) + { + return CommonBitmapOperations.doBitBltTestWithHorizontalRedGradientImage(image, graphics2d, BufferedImage.TYPE_BYTE_GRAY, rasterOp); + } + + /** + * Test basic BitBlt operation for buffered image with type {@link BufferedImage#TYPE_INT_BGR}. + * + * @param image + * image used as a destination for BitBlt-type operations + * @param graphics2d + * graphics canvas + * @param rasterOp + * selected raster operation + * @return test result status - PASSED, FAILED or ERROR + */ + protected TestResult doBitBltHorizontalRedGradientTypeIntBGR(TestImage image, Graphics2D graphics2d, + BufferedImageOp rasterOp) + { + return CommonBitmapOperations.doBitBltTestWithHorizontalRedGradientImage(image, graphics2d, BufferedImage.TYPE_INT_BGR, rasterOp); + } + + /** + * Test basic BitBlt operation for buffered image with type {@link BufferedImage#TYPE_INT_RGB}. + * + * @param image + * image used as a destination for BitBlt-type operations + * @param graphics2d + * graphics canvas + * @param rasterOp + * selected raster operation + * @return test result status - PASSED, FAILED or ERROR + */ + protected TestResult doBitBltHorizontalRedGradientTypeIntRGB(TestImage image, Graphics2D graphics2d, + BufferedImageOp rasterOp) + { + return CommonBitmapOperations.doBitBltTestWithHorizontalRedGradientImage(image, graphics2d, BufferedImage.TYPE_INT_RGB, rasterOp); + } + + /** + * Test basic BitBlt operation for buffered image with type {@link BufferedImage#TYPE_INT_ARGB}. + * + * @param image + * image used as a destination for BitBlt-type operations + * @param graphics2d + * graphics canvas + * @param rasterOp + * selected raster operation + * @return test result status - PASSED, FAILED or ERROR + */ + protected TestResult doBitBltHorizontalRedGradientTypeIntARGB(TestImage image, Graphics2D graphics2d, + BufferedImageOp rasterOp) + { + return CommonBitmapOperations.doBitBltTestWithHorizontalRedGradientImage(image, graphics2d, BufferedImage.TYPE_INT_ARGB, rasterOp); + } + + /** + * Test basic BitBlt operation for buffered image with type {@link BufferedImage#TYPE_INT_ARGB_PRE}. + * + * @param image + * image used as a destination for BitBlt-type operations + * @param graphics2d + * graphics canvas + * @param rasterOp + * selected raster operation + * @return test result status - PASSED, FAILED or ERROR + */ + protected TestResult doBitBltHorizontalRedGradientTypeIntARGB_Pre(TestImage image, Graphics2D graphics2d, + BufferedImageOp rasterOp) + { + return CommonBitmapOperations.doBitBltTestWithHorizontalRedGradientImage(image, graphics2d, BufferedImage.TYPE_INT_ARGB_PRE, rasterOp); + } + + /** * Entry point to the test suite. * * @param args not used in this case From bugzilla-daemon at icedtea.classpath.org Tue Sep 2 14:07:59 2014 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Tue, 02 Sep 2014 14:07:59 +0000 Subject: [Bug 1972] New: Don't compil on arm Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1972 Bug ID: 1972 Summary: Don't compil on arm Product: IcedTea Version: 7-hg Hardware: arm OS: Linux Status: NEW Severity: major Priority: P5 Component: IcedTea Assignee: gnu.andrew at redhat.com Reporter: alpha_one_x86 at first-world.info CC: unassigned at icedtea.classpath.org Created attachment 1157 --> http://icedtea.classpath.org/bugzilla/attachment.cgi?id=1157&action=edit error at compilation Hello, I have compiled from gcj the version 6.1.13.3, then now I try upgrate to 7.2.4.7, I'm on arm. I use the gentoo official ebuild, and I have: Attached file is the error and system info. Cheers, -- You are receiving this mail because: You are on the CC list for the bug. -------------- next part -------------- An HTML attachment was scrubbed... URL: From bugzilla-daemon at icedtea.classpath.org Tue Sep 2 14:11:11 2014 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Tue, 02 Sep 2014 14:11:11 +0000 Subject: [Bug 1972] Don't compil on arm In-Reply-To: References: Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1972 --- Comment #1 from BRULE Herman --- Created attachment 1158 --> http://icedtea.classpath.org/bugzilla/attachment.cgi?id=1158&action=edit system info -- You are receiving this mail because: You are on the CC list for the bug. -------------- next part -------------- An HTML attachment was scrubbed... URL: From jkang at icedtea.classpath.org Tue Sep 2 15:46:25 2014 From: jkang at icedtea.classpath.org (jkang at icedtea.classpath.org) Date: Tue, 02 Sep 2014 15:46:25 +0000 Subject: /hg/icedtea-web: Fixed CacheUtil clearCache to also remove LRU e... Message-ID: changeset 2979fa371add in /hg/icedtea-web details: http://icedtea.classpath.org/hg/icedtea-web?cmd=changeset;node=2979fa371add author: Jie Kang date: Tue Sep 02 11:46:09 2014 -0400 Fixed CacheUtil clearCache to also remove LRU entries. 2014-09-02 Jie Kang Fixed CacheUtils clearCache method to also clear the Least Recently Used entries. * netx/net/sourceforge/jnlp/cache/CacheUtil.java diffstat: ChangeLog | 6 ++++++ netx/net/sourceforge/jnlp/cache/CacheUtil.java | 5 +++++ 2 files changed, 11 insertions(+), 0 deletions(-) diffs (34 lines): diff -r c45cd47e962b -r 2979fa371add ChangeLog --- a/ChangeLog Wed Aug 20 15:49:58 2014 -0400 +++ b/ChangeLog Tue Sep 02 11:46:09 2014 -0400 @@ -1,3 +1,9 @@ +2014-09-02 Jie Kang + + Fixed CacheUtils clearCache method to also clear the Least Recently Used + entries. + * netx/net/sourceforge/jnlp/cache/CacheUtil.java: + 2014-08-20 Jie Kang Improved CacheEntry locking system to respect threads and processes. diff -r c45cd47e962b -r 2979fa371add netx/net/sourceforge/jnlp/cache/CacheUtil.java --- a/netx/net/sourceforge/jnlp/cache/CacheUtil.java Wed Aug 20 15:49:58 2014 -0400 +++ b/netx/net/sourceforge/jnlp/cache/CacheUtil.java Tue Sep 02 11:46:09 2014 -0400 @@ -134,12 +134,17 @@ } OutputController.getLogger().log(OutputController.Level.ERROR_DEBUG, "Clearing cache directory: " + cacheDir); + lruHandler.lock(); try { cacheDir = cacheDir.getCanonicalFile(); FileUtils.recursiveDelete(cacheDir, cacheDir); cacheDir.mkdir(); + lruHandler.clearLRUSortedEntries(); + lruHandler.store(); } catch (IOException e) { throw new RuntimeException(e); + } finally { + lruHandler.unlock(); } return true; } From bugzilla-daemon at icedtea.classpath.org Tue Sep 2 16:13:11 2014 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Tue, 02 Sep 2014 16:13:11 +0000 Subject: [Bug 1730] javaws launcher cannot handle ampersand in Client.Security.sessionCookieNames In-Reply-To: References: Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1730 --- Comment #1 from Omair Majid --- Please be aware that your file is in fact incorrect. "The JNLP file is an XML document" [1]. An XML document must encode entities, including '&', correctly. What you have is a JNLP file that violates the specification. The easiest way to fix the problem is fix the file. If you rely on behaviour that is specific to the implemenation (and specifically violates the standard), it's not really sensible to expect that to work elsewhere. Anyway, this bug should be fixed in IcedTea-Web 1.5. We have switched to an html-like parser that should accept malfromed JNLP files. Can you please test it with that? [1] http://docs.oracle.com/javase/8/docs/technotes/guides/javaws/developersguide/syntax.html -- You are receiving this mail because: You are on the CC list for the bug. -------------- next part -------------- An HTML attachment was scrubbed... URL: From bugzilla-daemon at icedtea.classpath.org Tue Sep 2 16:19:09 2014 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Tue, 02 Sep 2014 16:19:09 +0000 Subject: [Bug 1676] enhance the list of secure jnlp properties to support useLegacyMergeSort In-Reply-To: References: Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1676 Omair Majid changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #2 from Omair Majid --- Fixed in HEAD. -- You are receiving this mail because: You are on the CC list for the bug. -------------- next part -------------- An HTML attachment was scrubbed... URL: From bugzilla-daemon at icedtea.classpath.org Tue Sep 2 16:20:14 2014 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Tue, 02 Sep 2014 16:20:14 +0000 Subject: [Bug 1614] javaws fails on special character in jnlp In-Reply-To: References: Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1614 --- Comment #4 from Omair Majid --- Can you try this with icedtea-web 1.5? The tagsoup-based parser should handle this better. -- You are receiving this mail because: You are on the CC list for the bug. -------------- next part -------------- An HTML attachment was scrubbed... URL: From bugzilla-daemon at icedtea.classpath.org Tue Sep 2 16:35:20 2014 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Tue, 02 Sep 2014 16:35:20 +0000 Subject: [Bug 1973] New: Make configuration files easier to use Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1973 Bug ID: 1973 Summary: Make configuration files easier to use Product: Thermostat Version: hg Hardware: all OS: Linux Status: NEW Severity: enhancement Priority: P5 Component: Thermostat Assignee: unassigned at icedtea.classpath.org Reporter: omajid at redhat.com CC: thermostat at icedtea.classpath.org >From [1]: """ Aside (some food for thought for 2.0): The number of thermostat configuration files tends to grow. From a sys-admin point of view this is hard to maintain. One needs to remember where the config file is, what it's name is and various properties files seem to use different casing/syntax. It would be nice to unify thermostat configuration somehow. Perhaps have one file in THERMOSTAT_HOME and another in USER_THERMOSTAT_HOME. How a suitable format of such a file could look like I'd leave up for discussion for the time being :) """ I agree with the assesment of the issue. We have too many config files. They all with their own syntax (or at least, style). They have different meanings and usage. They use different parsers. [1] http://icedtea.classpath.org/pipermail/thermostat/2014-September/010630.html -- You are receiving this mail because: You are the assignee for the bug. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnu.andrew at redhat.com Tue Sep 2 16:39:10 2014 From: gnu.andrew at redhat.com (Andrew Hughes) Date: Tue, 2 Sep 2014 12:39:10 -0400 (EDT) Subject: [IcedTea-Web] Fwd: hs err_pid2237/ 2356 /2624/2765 /3275 /3372 /3390/ 5803/ 6979.log In-Reply-To: <5405F19A.7010307@yahoo.fr> References: <5405F19A.7010307@yahoo.fr> Message-ID: <511532172.17115956.1409675950308.JavaMail.zimbra@redhat.com> Looks like an IcedTea-Web crash. ----- Forwarded Message ----- > Ref.link > It has been working only a few times.It is important for me.Can you help me > > -- > Jacques glass > > -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: 248BDC07 (https://keys.indymedia.org/) Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07 -------------- next part -------------- A non-text attachment was scrubbed... Name: 01.png Type: image/png Size: 269962 bytes Desc: not available URL: From jkang at redhat.com Tue Sep 2 18:23:10 2014 From: jkang at redhat.com (Jie Kang) Date: Tue, 2 Sep 2014 14:23:10 -0400 (EDT) Subject: [rfc][icedtea-web] ResourceTracker Download Performance Test In-Reply-To: <971492461.21673115.1408116714569.JavaMail.zimbra@redhat.com> References: <971492461.21673115.1408116714569.JavaMail.zimbra@redhat.com> Message-ID: <1257931795.29079856.1409682190254.JavaMail.zimbra@redhat.com> ----- Original Message ----- > Hello, > > > The attached patch adds a single test to ResourceTracker that downloads > multiple resources from a public github repo hosted by myself. The purpose > of this is to test that downloading simple resources works and to see the > performance of our ResourceTracker implementation. > > At the moment it is placed in the unit test file ResourceTrackerTest though I > would not call it a unit test as it does have a non-local dependency on the > repo. Should we consider adding a separate performance or integration test > section to our codebase? I think this is a good idea as there are some > "unit" tests in our codebase that aren't really unit tests and have extra > requirements when run (ie. not really standalone). Hello, Ping; I have improved the test by making it use a temporary cache. However I don't think downloading from a github repo is the best idea. Does anyone have any suggestions? I think having tests for the download functionality is quite important. Thanks, > > > > Regards, > > -- > > Jie Kang > -- Jie Kang -------------- next part -------------- A non-text attachment was scrubbed... Name: itw-rt-download-test-1.patch Type: text/x-patch Size: 3708 bytes Desc: not available URL: From omajid at redhat.com Tue Sep 2 19:32:10 2014 From: omajid at redhat.com (Omair Majid) Date: Tue, 2 Sep 2014 15:32:10 -0400 Subject: [rfc][icedtea-web] ResourceTracker Download Performance Test In-Reply-To: <1257931795.29079856.1409682190254.JavaMail.zimbra@redhat.com> References: <971492461.21673115.1408116714569.JavaMail.zimbra@redhat.com> <1257931795.29079856.1409682190254.JavaMail.zimbra@redhat.com> Message-ID: <20140902193210.GD3151@redhat.com> Hi, * Jie Kang [2014-09-02 14:25]: > I have improved the test by making it use a temporary cache. However I > don't think downloading from a github repo is the best idea. Does > anyone have any suggestions? What capabilities do you need from the download URL? If you just need an alternative to github, you can also use a personal repo at icedtea.classpath.org. Let me know if you decide to use that and I can help you set it up. > I think having tests for the download > functionality is quite important. I agree. Tests to know that thing is working and working fast are great to have. However, these should be moved to integration tests and run using the web server that's part of the test suite. Here are my reasons for this: - The URL is an external resource; unit tests should not require network connectivity. - Since it's a performance test, the results need to be examined by a human to figure out if they are passing. Running it as a unit test (on every build) doesn't really help us. - For anything more complex than a simple http GET, running the test under a server that you can programmatically control to do unexpected things or handle corner cases would be nice to have. And that server is available for integration tests. Thanks, Omair -- PGP Key: 66484681 (http://pgp.mit.edu/) Fingerprint = F072 555B 0A17 3957 4E95 0056 F286 F14F 6648 4681 From jkang at redhat.com Tue Sep 2 20:00:09 2014 From: jkang at redhat.com (Jie Kang) Date: Tue, 2 Sep 2014 16:00:09 -0400 (EDT) Subject: [rfc][icedtea-web] ResourceTracker Download Performance Test In-Reply-To: <20140902193210.GD3151@redhat.com> References: <971492461.21673115.1408116714569.JavaMail.zimbra@redhat.com> <1257931795.29079856.1409682190254.JavaMail.zimbra@redhat.com> <20140902193210.GD3151@redhat.com> Message-ID: <109438506.29117223.1409688009018.JavaMail.zimbra@redhat.com> ----- Original Message ----- > Hi, > > * Jie Kang [2014-09-02 14:25]: > > I have improved the test by making it use a temporary cache. However I > > don't think downloading from a github repo is the best idea. Does > > anyone have any suggestions? > > What capabilities do you need from the download URL? If you just need an > alternative to github, you can also use a personal repo at > icedtea.classpath.org. Let me know if you decide to use that and I can > help you set it up. > > > I think having tests for the download > > functionality is quite important. > > I agree. Tests to know that thing is working and working fast are great > to have. > > However, these should be moved to integration tests and run using the > web server that's part of the test suite. Here are my reasons for this: > > - The URL is an external resource; unit tests should not require network > connectivity. > > - Since it's a performance test, the results need to be examined by a human > to > figure out if they are passing. Running it as a unit test (on every > build) doesn't really help us. > > - For anything more complex than a simple http GET, running the test > under a server that you can programmatically control to do unexpected > things or handle corner cases would be nice to have. And that server > is available for integration tests. Hello, I agree completely that these tests should not be part of the unit test section. Could you elaborate on the integration tests and web server part? Do you mean the dist-test system that we're using for reproducers? Or something else that I'm not aware of; Thanks, > > Thanks, > Omair > > -- > PGP Key: 66484681 (http://pgp.mit.edu/) > Fingerprint = F072 555B 0A17 3957 4E95 0056 F286 F14F 6648 4681 > -- Jie Kang From omajid at redhat.com Tue Sep 2 20:10:07 2014 From: omajid at redhat.com (Omair Majid) Date: Tue, 2 Sep 2014 16:10:07 -0400 Subject: [rfc][icedtea-web] ResourceTracker Download Performance Test In-Reply-To: <109438506.29117223.1409688009018.JavaMail.zimbra@redhat.com> References: <971492461.21673115.1408116714569.JavaMail.zimbra@redhat.com> <1257931795.29079856.1409682190254.JavaMail.zimbra@redhat.com> <20140902193210.GD3151@redhat.com> <109438506.29117223.1409688009018.JavaMail.zimbra@redhat.com> Message-ID: <20140902201005.GF3151@redhat.com> * Jie Kang [2014-09-02 16:00]: > I agree completely that these tests should not be part of the unit > test section. Could you elaborate on the integration tests and web > server part? Do you mean the dist-test system that we're using for > reproducers? Or something else that I'm not aware of; Yes, I meant the tests that get run on 'make run-netx-dist-tests'. You can find them under 'tests/reproducers'. Please see http://icedtea.classpath.org/wiki/Reproducers for much more complete information about these tests and how to write/use them. Cheers, Omair -- PGP Key: 66484681 (http://pgp.mit.edu/) Fingerprint = F072 555B 0A17 3957 4E95 0056 F286 F14F 6648 4681 From bugzilla-daemon at icedtea.classpath.org Tue Sep 2 23:15:55 2014 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Tue, 02 Sep 2014 23:15:55 +0000 Subject: [Bug 1972] Don't compil on arm In-Reply-To: References: Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1972 Andrew John Hughes changed: What |Removed |Added ---------------------------------------------------------------------------- Component|IcedTea |Thumb2 JIT Version|7-hg |2.4.7 Assignee|gnu.andrew at redhat.com |aph at redhat.com Severity|major |normal --- Comment #2 from Andrew John Hughes --- What USE flags are you using? Looking at the ebuild, it seems CACAO should be turned on for this architecture. As it isn't, this looks like a failure in the ARM32 JIT port. Trying with CACAO on may be a better option. Also, you should try with the latest version which is 2.5.2. 2.4.x will not receive any further updates. -- You are receiving this mail because: You are on the CC list for the bug. -------------- next part -------------- An HTML attachment was scrubbed... URL: From bugzilla-daemon at icedtea.classpath.org Wed Sep 3 01:04:32 2014 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Wed, 03 Sep 2014 01:04:32 +0000 Subject: [Bug 1972] Don't compil on arm In-Reply-To: References: Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1972 --- Comment #3 from BRULE Herman --- I have tryied alternate all the flags, I will send the repport with cacao, for this I do: dev-java/icedtea-7.2.4.7:7 [6.1.13.3:6] USE="cacao pax_kernel -X -alsa -cjk -cups -debug -doc -examples -jamvm -javascript -jbootstrap -kerberos -nsplugin -nss -pulseaudio (-selinux) -source {-test} -webstart -zero" During the compilation I have: (null)*(null) Unable to trace static ELF: /lib/ld-linux-armhf.so.3: /lib/ld-linux-armhf.so.3 --verify ./a.out (null)*(null) Unable to trace static ELF: /sbin/ldconfig: ldconfig -n /var/tmp/portage/dev-java/icedtea-7.2.4.7/work/icedtea-2.4.7/cacao/install/lib ... And I'm into hardened profile and kernel. Attached log with cacao -- You are receiving this mail because: You are on the CC list for the bug. -------------- next part -------------- An HTML attachment was scrubbed... URL: From bugzilla-daemon at icedtea.classpath.org Wed Sep 3 01:05:39 2014 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Wed, 03 Sep 2014 01:05:39 +0000 Subject: [Bug 1972] Don't compil on arm In-Reply-To: References: Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1972 --- Comment #4 from BRULE Herman --- Created attachment 1159 --> http://icedtea.classpath.org/bugzilla/attachment.cgi?id=1159&action=edit cacao -- You are receiving this mail because: You are on the CC list for the bug. -------------- next part -------------- An HTML attachment was scrubbed... URL: From jvanek at redhat.com Wed Sep 3 07:15:57 2014 From: jvanek at redhat.com (Jiri Vanek) Date: Wed, 03 Sep 2014 09:15:57 +0200 Subject: [IcedTea-Web] Fwd: hs err_pid2237/ 2356 /2624/2765 /3275 /3372 /3390/ 5803/ 6979.log In-Reply-To: <511532172.17115956.1409675950308.JavaMail.zimbra@redhat.com> References: <5405F19A.7010307@yahoo.fr> <511532172.17115956.1409675950308.JavaMail.zimbra@redhat.com> Message-ID: <5406C02D.8080706@redhat.com> Hi Andrew! Thank you for reporting, unluckily this info is very poor. Not even whole trace is visible:( Where this come from? May you address the person to distro list? Or to me or Andrew A.? Or us to this list? J. On 09/02/2014 06:39 PM, Andrew Hughes wrote: > Looks like an IcedTea-Web crash. The error window is definitely ITW's window :) > > ----- Forwarded Message ----- >> Ref.link >> It has been working only a few times.It is important for me.Can you help me >> >> -- >> Jacques glass >> >> > From jvanek at redhat.com Wed Sep 3 07:18:58 2014 From: jvanek at redhat.com (Jiri Vanek) Date: Wed, 03 Sep 2014 09:18:58 +0200 Subject: [rfc][icedtea-web][itweb-settings] Improve Icedtea-Web cache disk space In-Reply-To: <540180DB.4050109@gmx.de> References: <319590383.4051363.1404829211485.JavaMail.zimbra@redhat.com> <1222082700.26083069.1409081718997.JavaMail.zimbra@redhat.com> <982339162.26695106.1409162928407.JavaMail.zimbra@redhat.com> <958305698.27235425.1409240834908.JavaMail.zimbra@redhat.com> <1885159478.27899833.1409329251634.JavaMail.zimbra@redhat.com> <540180DB.4050109@gmx.de> Message-ID: <5406C0E2.7010309@redhat.com> ... > > No no, do not start playing around with visible and hidden UI components. It is even worse when they > change their layout or start jumping around like it is now. Generally, there is never any need to ... > @helpcrypto > Yes, it is against basic UI design principles to have hiding UI components, unless there are really > good reasons to do so. Please do not start giving advice on something you do not know or have no > experience in. This only confuses young or new developers. > indeed :D https://bugzilla.redhat.com/show_bug.cgi?id=1136192 J:) From ptisnovs at icedtea.classpath.org Wed Sep 3 09:51:47 2014 From: ptisnovs at icedtea.classpath.org (ptisnovs at icedtea.classpath.org) Date: Wed, 03 Sep 2014 09:51:47 +0000 Subject: /hg/gfx-test: Ten new tests added into CAGOperationsOnTwoOverlap... Message-ID: changeset 52d612cf8db6 in /hg/gfx-test details: http://icedtea.classpath.org/hg/gfx-test?cmd=changeset;node=52d612cf8db6 author: Pavel Tisnovsky date: Wed Sep 03 11:52:58 2014 +0200 Ten new tests added into CAGOperationsOnTwoOverlappingRoundRectangles. diffstat: ChangeLog | 5 + src/org/gfxtest/testsuites/CAGOperationsOnTwoOverlappingRoundRectangles.java | 250 ++++++++++ 2 files changed, 255 insertions(+), 0 deletions(-) diffs (272 lines): diff -r bc3ca0c7b1e7 -r 52d612cf8db6 ChangeLog --- a/ChangeLog Tue Sep 02 11:25:53 2014 +0200 +++ b/ChangeLog Wed Sep 03 11:52:58 2014 +0200 @@ -1,3 +1,8 @@ +2014-09-03 Pavel Tisnovsky + + * src/org/gfxtest/testsuites/CAGOperationsOnTwoOverlappingRoundRectangles.java: + Ten new tests added into CAGOperationsOnTwoOverlappingRoundRectangles. + 2014-09-02 Pavel Tisnovsky * src/org/gfxtest/testsuites/BitBltBufferedImageOp.java: diff -r bc3ca0c7b1e7 -r 52d612cf8db6 src/org/gfxtest/testsuites/CAGOperationsOnTwoOverlappingRoundRectangles.java --- a/src/org/gfxtest/testsuites/CAGOperationsOnTwoOverlappingRoundRectangles.java Tue Sep 02 11:25:53 2014 +0200 +++ b/src/org/gfxtest/testsuites/CAGOperationsOnTwoOverlappingRoundRectangles.java Wed Sep 03 11:52:58 2014 +0200 @@ -306,6 +306,256 @@ return TestResult.PASSED; } + /** + * Checks the process of creating and rendering new geometric shape + * constructed from two rectangles using union operator. The shape is + * rendered using extra wide stroke. + * + * @param image + * image to which area is to be drawn + * @param graphics2d + * graphics canvas + * @return test result status - PASSED, FAILED or ERROR + */ + public TestResult testUnionExtraWideStrokePaint(TestImage image, Graphics2D graphics2d) + { + // set stroke color + CommonRenderingStyles.setStrokeColor(graphics2d); + // set stroke width + CommonRenderingStyles.setStrokeExtraThickWidth(graphics2d); + // create area using union operator + Area area = CommonCAGOperations.createAreaFromTwoOverlappingRoundRectanglesUsingUnionOperator(image); + // draw the area + graphics2d.draw(area); + // test result + return TestResult.PASSED; + } + + /** + * Checks the process of creating and rendering new geometric shape + * constructed from two rectangles using subtract operator. The shape is + * rendered using extra wide stroke. + * + * @param image + * image to which area is to be drawn + * @param graphics2d + * graphics canvas + * @return test result status - PASSED, FAILED or ERROR + */ + public TestResult testSubtractExtraWideStrokePaint(TestImage image, Graphics2D graphics2d) + { + // set stroke color + CommonRenderingStyles.setStrokeColor(graphics2d); + // set stroke width + CommonRenderingStyles.setStrokeExtraThickWidth(graphics2d); + // create area using subtract operator + Area area = CommonCAGOperations.createAreaFromTwoOverlappingRoundRectanglesUsingSubtractOperator(image); + // draw the area + graphics2d.draw(area); + // test result + return TestResult.PASSED; + } + + /** + * Checks the process of creating and rendering new geometric shape + * constructed from two rectangles using inverse subtract operator. The + * shape is rendered using extra wide stroke. + * + * @param image + * image to which area is to be drawn + * @param graphics2d + * graphics canvas + * @return test result status - PASSED, FAILED or ERROR + */ + public TestResult testInverseSubtractExtraWideStrokePaint(TestImage image, Graphics2D graphics2d) + { + // set stroke color + CommonRenderingStyles.setStrokeColor(graphics2d); + // set stroke width + CommonRenderingStyles.setStrokeExtraThickWidth(graphics2d); + // create area using inverse subtract operator + Area area = CommonCAGOperations.createAreaFromTwoOverlappingRoundRectanglesUsingInverseSubtractOperator(image); + // draw the area + graphics2d.draw(area); + // test result + return TestResult.PASSED; + } + + /** + * Checks the process of creating and rendering new geometric shape + * constructed from two rectangles using intersect operator. The + * shape is rendered using extra wide stroke. + * + * @param image + * image to which area is to be drawn + * @param graphics2d + * graphics canvas + * @return test result status - PASSED, FAILED or ERROR + */ + public TestResult testIntersectExtraWideStrokePaint(TestImage image, Graphics2D graphics2d) + { + // set stroke color + CommonRenderingStyles.setStrokeColor(graphics2d); + // set stroke width + CommonRenderingStyles.setStrokeExtraThickWidth(graphics2d); + // create area using intersect operator + Area area = CommonCAGOperations.createAreaFromTwoOverlappingRoundRectanglesUsingIntersectOperator(image); + // draw the area + graphics2d.draw(area); + // test result + return TestResult.PASSED; + } + + /** + * Checks the process of creating and rendering new geometric shape + * constructed from two rectangles using XOR operator. The + * shape is rendered using extra wide stroke. + * + * @param image + * image to which area is to be drawn + * @param graphics2d + * graphics canvas + * @return test result status - PASSED, FAILED or ERROR + */ + public TestResult testXorExtraWideStrokePaint(TestImage image, Graphics2D graphics2d) + { + // set stroke color + CommonRenderingStyles.setStrokeColor(graphics2d); + // set stroke width + CommonRenderingStyles.setStrokeExtraThickWidth(graphics2d); + // create area using XOR operator + Area area = CommonCAGOperations.createAreaFromTwoOverlappingRoundRectanglesUsingXorOperator(image); + // draw the area + graphics2d.draw(area); + // test result + return TestResult.PASSED; + } + + /** + * Checks the process of creating and rendering new geometric shape + * constructed from two overlapping round rectangles using union operator. The shape is rendered + * using zero wide stroke. + * + * @param image + * image to which area is to be drawn + * @param graphics2d + * graphics canvas + * @return test result status - PASSED, FAILED or ERROR + */ + public TestResult testUnionZeroStrokePaint(TestImage image, Graphics2D graphics2d) + { + // set stroke color + CommonRenderingStyles.setStrokeColor(graphics2d); + // set stroke width + CommonRenderingStyles.setStrokeZeroThick(graphics2d); + // create area using union operator + Area area = CommonCAGOperations.createAreaFromTwoOverlappingRoundRectanglesUsingUnionOperator(image); + // draw the area + graphics2d.draw(area); + // test result + return TestResult.PASSED; + } + + /** + * Checks the process of creating and rendering new geometric shape + * constructed from two overlapping round rectangles using subtract operator. The shape is + * rendered using zero stroke. + * + * @param image + * image to which area is to be drawn + * @param graphics2d + * graphics canvas + * @return test result status - PASSED, FAILED or ERROR + */ + public TestResult testSubtractZeroStrokePaint(TestImage image, Graphics2D graphics2d) + { + // set stroke color + CommonRenderingStyles.setStrokeColor(graphics2d); + // set stroke width + CommonRenderingStyles.setStrokeZeroThick(graphics2d); + // create area using subtract operator + Area area = CommonCAGOperations.createAreaFromTwoOverlappingRoundRectanglesUsingSubtractOperator(image); + // draw the area + graphics2d.draw(area); + // test result + return TestResult.PASSED; + } + + /** + * Checks the process of creating and rendering new geometric shape + * constructed from two overlapping round rectangles using inverse subtract operator. The shape + * is rendered using zero stroke. + * + * @param image + * image to which area is to be drawn + * @param graphics2d + * graphics canvas + * @return test result status - PASSED, FAILED or ERROR + */ + public TestResult testInverseSubtractZeroStrokePaint(TestImage image, Graphics2D graphics2d) + { + // set stroke color + CommonRenderingStyles.setStrokeColor(graphics2d); + // set stroke width + CommonRenderingStyles.setStrokeZeroThick(graphics2d); + // create area using subtract operator + Area area = CommonCAGOperations.createAreaFromTwoOverlappingRoundRectanglesUsingInverseSubtractOperator(image); + // draw the area + graphics2d.draw(area); + // test result + return TestResult.PASSED; + } + + /** + * Checks the process of creating and rendering new geometric shape + * constructed from two overlapping round rectangles using intersect operator. The shape is + * rendered using zero stroke. + * + * @param image + * image to which area is to be drawn + * @param graphics2d + * graphics canvas + * @return test result status - PASSED, FAILED or ERROR + */ + public TestResult testIntersectZeroStrokePaint(TestImage image, Graphics2D graphics2d) + { + // set stroke color + CommonRenderingStyles.setStrokeColor(graphics2d); + // set stroke width + CommonRenderingStyles.setStrokeZeroThick(graphics2d); + // create area using intersect operator + Area area = CommonCAGOperations.createAreaFromTwoOverlappingRoundRectanglesUsingIntersectOperator(image); + // draw the area + graphics2d.draw(area); + // test result + return TestResult.PASSED; + } + + /** + * Checks the process of creating and rendering new geometric shape + * constructed from two overlapping round rectangles using XOR operator. The shape is rendered + * using zero stroke. + * + * @param image + * image to which area is to be drawn + * @param graphics2d + * graphics canvas + * @return test result status - PASSED, FAILED or ERROR + */ + public TestResult testXorZeroStrokePaint(TestImage image, Graphics2D graphics2d) + { + // set stroke color + CommonRenderingStyles.setStrokeColor(graphics2d); + // set stroke width + CommonRenderingStyles.setStrokeZeroThick(graphics2d); + // create area using XOR operator + Area area = CommonCAGOperations.createAreaFromTwoOverlappingRoundRectanglesUsingXorOperator(image); + // draw the area + graphics2d.draw(area); + // test result + return TestResult.PASSED; + } + /** * Entry point to the test suite. From bugzilla-daemon at icedtea.classpath.org Wed Sep 3 11:26:32 2014 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Wed, 03 Sep 2014 11:26:32 +0000 Subject: [Bug 1974] New: i just updated my kalilinux , but it cudn't not start armitage. Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1974 Bug ID: 1974 Summary: i just updated my kalilinux ,but it cudn't not start armitage. Product: IcedTea Version: 2.4.0 Hardware: x86 OS: Linux Status: NEW Severity: enhancement Priority: P5 Component: IcedTea Assignee: gnu.andrew at redhat.com Reporter: neo.hilton2009 at gmail.com CC: unassigned at icedtea.classpath.org Created attachment 1160 --> http://icedtea.classpath.org/bugzilla/attachment.cgi?id=1160&action=edit how can it get fixed please i need your help i just updated my kalilinux ,but it cudn't not start armitage. -- You are receiving this mail because: You are on the CC list for the bug. -------------- next part -------------- An HTML attachment was scrubbed... URL: From jvanek at redhat.com Wed Sep 3 12:45:01 2014 From: jvanek at redhat.com (Jiri Vanek) Date: Wed, 03 Sep 2014 14:45:01 +0200 Subject: [rfc][icedtea-web] missing jnlpfile and securtydelegate for TemporaryPermissionsButton calls In-Reply-To: <53FE5CD3.4060602@redhat.com> References: <53FDA41B.4060801@redhat.com> <53FE5CD3.4060602@redhat.com> Message-ID: <54070D4D.70605@redhat.com> On 08/28/2014 12:33 AM, Andrew Azores wrote: > Hi, > > Still on PTO here and preparing to move back into my parents' place while I go back to finish > school, so I haven't really invested any real time into this bug. But... > > On 08/27/2014 05:25 AM, Jiri Vanek wrote: >> Hi! >> >> During testing of https probing, helpcrypto found and interesting issue >> in head. >> >> Under some circumstances calls to TemporaryPermissionsButton have >> jnlpfile and securitydelegate null. > > The SecurityDelegate can be instantiated much earlier in JNLPClassLoader if need be. It can even be > the first thing done after calling the super constructor AFAIK. Since the JNLPClassLoader is also > what eventually causes the security dialog to appear with the Temporary Permissions button on it, > this will probably resolve the null securityDelegate reference part. > >> >> Two things troubles me: >> - both those values are needed only when "tmeporarypermissions" are >> clicked, so they should not affect startup of ITW >> - how come that they are null? I blame >> http://icedtea.classpath.org/hg/icedtea-web/annotate/d87ee4e6e81a/netx/net/sourceforge/jnlp/security/dialogs/TemporaryPermissionsButton.java#78 >> >> >> (looking into Looking to this, >> http://icedtea.classpath.org/hg/icedtea-web/file/b4363c984e1b/netx/net/sourceforge/jnlp/security/dialogs/TemporaryPermissionsButton.java#l79 >> >> ) > > For the null jnlpFile - I can't think off the top of my head what is causing that. It could just be > again that the dialog is being shown before a field has been assigned a value, as it is with the > securityDelegate. If it's simply an ordering issue like this then that isn't *too* concerning. If we > truly just do not have a reference to any JNLPFile or PluginBridge for this applet then there's > something seriously wrong. > >> >> >> Atatched is the nasty workarorund and here is snippet of log >> >> Securitymanager=net.sourceforge.jnlp.runtime.JNLPSecurityManager at 19f17b1 >> Registering priority for string reference 2 >> Registering priority for reference 2 >> Returning value:0 >> Setting value:0 >> Setting value:null >> dummy string null, null, javax.swing.JButton[,0,0,0x0,inva...snip... >> plugin_in_pipe_callback return >> plugin_send_message_to_appletviewer return >> PIPE: plugin wrote(?): plugin PluginProxyInfo reference 1 DIRECT >> plugin_send_message_to_appletviewer >> Proxy info: plugin PluginProxyInfo reference 1 DIRECT >> >> >> >> Without the workarround itw dies: >> >> ITNP_SetWindow return >> ITNP_SetWindow: window already exists. >> ITNP_SetWindow >> at java.lang.Thread.run(Thread.java:745) >> at >> net.sourceforge.jnlp.security.SecurityDialogMessageHandler.run(SecurityDialogMessageHandler.java:81) >> >> at >> net.sourceforge.jnlp.security.SecurityDialogMessageHandler.handleMessage(SecurityDialogMessageHandler.java:102) >> >> >> at net.sourceforge.jnlp.security.SecurityDialog. >> (SecurityDialog.java:129) >> at >> net.sourceforge.jnlp.security.SecurityDialog.initDialog(SecurityDialog.java:255) >> >> at >> net.sourceforge.jnlp.security.SecurityDialog.installPanel(SecurityDialog.java:307) >> >> at net.sourceforge.jnlp.security.dialogs.CertWarningPane. >> (CertWarningPane.java:116) >> at >> net.sourceforge.jnlp.security.dialogs.CertWarningPane.addComponents(CertWarningPane.java:124) >> >> at >> net.sourceforge.jnlp.security.dialogs.CertWarningPane.addButtons(CertWarningPane.java:242) >> >> at >> net.sourceforge.jnlp.security.dialogs.TemporaryPermissionsButton. >> (TemporaryPermissionsButton.java:79) >> at java.util.Objects.requireNonNull(Objects.java:201) >> Exception in thread "NetxSecurityThread" java.lang.NullPointerException >> plugin_in_pipe_callback return >> plugin_send_message_to_appletviewer return >> PIPE: plugin wrote(?): plugin PluginProxyInfo reference 1 DIRECT >> plugin_send_message_to_appletviewer >> Proxy info: plugin PluginProxyInfo reference 1 DIRECT >> >> >> >> I think the AssertNotNUll are really really invasive here. But at least >> they cought probably more serious issue - to early call to the dialogue >> with tmppermissions button.... >> >> >> J. > > Yup. The PolicyEditor can't be sensibly launched if the jnlpFile is null (your nasty workaround > really is nasty - assigning the new permissions to all applets rather than only ones on the current > applet's codebase!), and the securityDelegate is needed if this button is to function at all. So > there's no sensible thing to do if either of those fields come up null. Perhaps rather than outright > failing to launch ITW we could have the button indicate a failure somehow and have the dialog simply > not install the button, however. Just another option for Lukasz or whomever to look into. If this > still hasn't been fixed by the time I come off PTO then I'll gladly take ownership of the bug. > Andrew have made some investigations, and this is moreover conclusion - its a bug - the tmp permissions dialogue is shared among javaws and applets, and in applets lifecycle can happen this NPE - however, the fix will take some time Even after it may be some cases, when this NPE will rise. We agreed that disabling the button n this case is probably best solution. The attache dpatch do so, Two nits : - is really the SecurityDelegate suddenly useless? - Why all apps reproducing this issue suddenly started to work? ( I mean without this patch) Still I think it is good thing to get rid of assers and disable button. J. -------------- next part -------------- A non-text attachment was scrubbed... Name: npe.patch Type: text/x-patch Size: 1966 bytes Desc: not available URL: From gitne at gmx.de Wed Sep 3 13:41:30 2014 From: gitne at gmx.de (Jacob Wisor) Date: Wed, 03 Sep 2014 15:41:30 +0200 Subject: [rfc][icedtea-web][itweb-settings] Improve Icedtea-Web cache disk space In-Reply-To: References: <319590383.4051363.1404829211485.JavaMail.zimbra@redhat.com> <1222082700.26083069.1409081718997.JavaMail.zimbra@redhat.com> <982339162.26695106.1409162928407.JavaMail.zimbra@redhat.com> <958305698.27235425.1409240834908.JavaMail.zimbra@redhat.com> <1885159478.27899833.1409329251634.JavaMail.zimbra@redhat.com> <540180DB.4050109@gmx.de> Message-ID: <54071A8A.9050202@gmx.de> On 09/01/2014 at 02:59 PM, helpcrypto helpcrypto wrote: > On Sat, Aug 30, 2014 at 9:44 AM, Jacob Wisor wrote: > >> No no, do not start playing around with visible and hidden UI components. >> It is even worse when they change their layout or start jumping around like >> it is now. Generally, there is never any need to hide UI components. If >> there seems to be, then either there is something wrong with the basic >> design of a window or dialog, or you should have very good reasons to do >> so. And, in this case there is surely *no* reason to hide any components >> dynamically at all. Again, stick to disabling components. This should be >> enough. >> >> @helpcrypto >> Yes, it is against basic UI design principles to have hiding UI >> components, unless there are really good reasons to do so. > > Can you point a style guide, or a gui-best-practices which advices on that? Well, there are multiple guidelines available, depending on OS, window managers and/or desktop managers. It is difficult to point to a specific one in the case of SWT and Java because it is platform independent. But, I suppose one could take Microsoft's UI guidelines as a basis because of it's undeniable bread adoption. It also shares a large set of rules with other UI guidelines form other vendors. > I have seen several GUIs wich only show the user what he needs to see, and > I found them KISS-compliant I think you are mixing to concepts here. KISS is about technical solutions, that is how things should be solved in order for other engineers to comprehend the work of the original authors, and generally assumes that simple technical solutions are usually the most effective or efficient ones. UI design guidelines employ a similar concept but not exactly KISS. Good UI designs should not be overloaded with UI components and only display the right amount of components required to accomplish the current task at hand. Hence, users should not be overburdened with overloaded UIs. But, most importantly UIs must not be confusing to users, and their behavior must be intuitively and naturally predictable. Hiding and jumping UI controls feel absolutely unnatural and inorganic. This is indeed bad behavior for UI controls. I will give you a simple example why your way of thinking is flawed here. Take for example a dialog with a list view and an edit button to edit the list view items. Now, if no list view item would be selected then according to your reasoning the edit button should be hidden because the user can take no editing action while no list view item is selected. This is absolutely confusing to the user. The user is supposed to be able to see and know all the possible actions he can take at all times but should not be able to take invalid actions. This is why the edit button in this example has to stay always visible but not always enabled. Think about it. ;-) >> Unfortunately, because of your attempt to play around with hiding UI >> components you have introduced a new bug. When "Limit cache size" is >> checked and the spinner is 0 then all components for setting up the cache >> location suddenly disappear. > > Limit checked, value=0->no cache, hence no need of location, compression > level or anything. It's not a bug. > The warning under spinner informs about that. This is logically correct but it is against basic UI design guidelines. It is inorganic. >> And, as soon as the value becomes greater than 1, they become visible >> again. This is very odd, weird, and confusing. Again, do not play around >> with hiding UI components. >> > The reason why i suggested "no cach?" instead of 0. As mentioned before, the UI components handling the cache's location should simply be disabled in this case. No real reason to hide them. Jacob From jvanek at redhat.com Wed Sep 3 14:04:25 2014 From: jvanek at redhat.com (Jiri Vanek) Date: Wed, 03 Sep 2014 16:04:25 +0200 Subject: [rfc][icedtea-web] https probing In-Reply-To: <53FC3C79.5040208@gmx.de> References: <53E3B68B.1090806@redhat.com> <53E3D58D.5030609@gmx.de> <53E48C38.30802@redhat.com> <53E8EB49.8000209@gmx.de> <20140818184605.GA2383@redhat.com> <53F3C0AD.5030400@gmx.de> <53F4E95B.30507@redhat.com> <53FC3461.5030401@redhat.com> <53FC3C79.5040208@gmx.de> Message-ID: <54071FE9.2000309@redhat.com> On 08/26/2014 09:51 AM, Jacob Wisor wrote: > On 08/26/2014 09:16 AM, Jiri Vanek wrote: >> ping? >> >> On 08/20/2014 08:30 PM, Jiri Vanek wrote: >>> On 08/19/2014 11:25 PM, Jacob Wisor wrote: >>>> On 08/18/2014 08:46 PM, Omair Majid wrote: >>>>> Hi, >>>>> >>>>> >>>>> * Jacob Wisor [2014-08-11 12:12]: >>>>>> On 08/08/2014 10:37 AM, Jiri Vanek wrote: >>>>>>> Unluckily this fix patch is not helping obscure servers to do exists. >>>>>>> It really fixes bugs. >>>>>>> >>>>>>> First part of fix is delivered to be able handle SSLv2 handshake, Those >>>>>>> servers >>>>>>> do exists, and have no reason nor need to update or patch or whatever. We are >>>>>>> wrong by not allowing it right now. >>>>>>> See System.setProperty("https.protocols", "SSLv3,SSLv2Hello"); in code. >>>>>> >>>>>> Oh yes they do need fixing. SSLv2 is insecure and has been revoked by the >>>>>> IETF, period. Nobody should be using it. Even SSL 3.0 is deemed by the IETF >>>>>> as historic (https://datatracker.ietf.org/doc/rfc6101) although it is >>>>>> largely identical to TLS 1.0. Nevertheless, nobody should be using it >>>>>> either. Just one of many reasons is that it does not even support such a >>>>>> common hash algorithm as SHA1 (which by the way has been deprecated by NIST >>>>>> in favor of SHA256 too). Everybody should really upgrade to at least TLS >>>>>> 1.0, even though possible security leaks have been discovered in TLS 1.0 on >>>>>> specific configuration settings permutations. >>>>>> >>>>>> DO NOT use SSL anymore and DO NOT promote them in your software. Upgrade to >>>>>> TLS. >>>>> >>>>> This isn't SSv2, though. It's a SSLv2 hello packet wrapping an SSLv3 >>>>> packet: http://bugs.java.com/bugdatabase/view_bug.do?bug_id=4915862 >>>>> >>>>> It's actually part of the TLS 1.0 spec: >>>>> https://www.ietf.org/rfc/rfc2246.txt, Appendix E. >>>> >>>> This part describes backward compatibility of TLS 1.0 clients to SSL 3.0 and >>>> SSL 2.0 servers (and >>>> vice versa). >>>> >>>> "TLS 1.0 clients that support SSL Version 2.0 servers must send SSL >>>> Version 2.0 client hello messages [SSL2]. TLS servers should accept >>>> either client hello format if they wish to support SSL 2.0 clients on >>>> the same connection port. The only deviations from the Version 2.0 >>>> specification are the ability to specify a version with a value of >>>> three and the support for more ciphering types in the CipherSpec." >>>> >>>> Currently, IcedTea-Web is a TLS 1.0 or SSL 3.0 client. According to this >>>> paragraph, TLS 1.0 clients >>>> send SSL 2.0 client hello messages in order to connect to SSL 2.0 servers, >>>> that is, to negotiate a >>>> SSL 2.0 connection. So no, SSL 2.0 servers do not upgrade automagically to >>>> TLS 1.0 when they receive >>>> SSL 2.0 client hello messages from TLS 1.0 clients. Pure old SSL 2.0 servers >>>> will never speak >>>> anything later than SSL 2.0. >>>> >>>> One reason behind this paragraph was for TLS 1.0 clients to allow probing SSL >>>> 2.0 servers with >>>> cipher specifications in SSL 2.0 and those introduced in TLS 1.0. In >>>> practice, SSL 2.0 servers will >>>> _never_ negotiate to a cipher specification introduced since TLS 1.0 because >>>> they were simply not >>>> built for that. >>>> >>>> Another reason for this paragraph back in 1999 (!) was to allow implementors >>>> of TLS 1.0 to ease >>>> transition from SSL to TLS and to give them the option to merge TLS into >>>> their existing SSL >>>> libraries (or as much as possible build on top of them). Again, this has >>>> nothing to do with >>>> automagically upgrading SSL 2.0 servers to TLS. It is just a description of >>>> how TLS 1.0 clients >>>> could fallback to SSL 2.0, if they wish to. >>>> And, I am most certain nobody should want this, unless one has no clue what >>>> transport security is >>>> all about or is a complete lunatic. >>>> >>>> The next paragraph says it all: >>>> >>>> " Warning: The ability to send Version 2.0 client hello messages will be >>>> phased out with all due haste. Implementors should make every >>>> effort to move forward as quickly as possible. Version 3.0 >>>> provides better mechanisms for moving to newer versions." >>>> >>>> So, the Java API should have got rid of the option to fallback to SSL 2.0 >>>> years before. It's a shame >>>> that J2SE still supports SSL 2.0 connections in 2014. Why? Because this has >>>> nothing to do with >>>> compatibility but with *security*. >>>> >>> >>> Ok. Thank you for patience with me. (really!) >>> >>> So there is another approach. >>> >>> Now the ssl2 is tested as last attempt, and if it is possible to connect like >>> that, then the user is >>> warned and error is thrown (which leads to skipping resource from that >>> >>> >>> The not-checking certificate now can be allowed or forbidden by properties. By >>> default it asks user >>> by every such invalid certs its found. How to deal with human intraction is todo. >>> >>> >>> The reason for this message is to get verbose logical error emsssage, not only >>> "itw do not work again" >>> >>> >>> What do you think now? >>> >>> J. > > > > + DeploymentConfiguration.KEY_HTTPS_PROBINGALOWED, > > [...] > > + public static final String KEY_HTTPS_PROBINGALOWED = > > "deployment.security.https.probing.alowed"; > > [...] > > + public void disconect(URLConnection conn) { > > [...] > > + public synchronized void disconectHttps(HttpsURLConnection conn) { > > [...] > > + private final boolean unsecure; > > + > > + private HttpsSettings(boolean ssl2, boolean unsecure) { > > [...] > > + public static URLConnection openConnection(URL url, boolean ssl2, > > boolean unsecure) throws IOException { > > I am not testing this unless you have fixed your typos. > For god's sake, your are a programmer, right? You should know best that exact spelling is important. > Obviously, I am just talking till I am blue in the face. Noooo. I moreover overlooked :( Sorry. Now it should be as good as I'm able to do so without third party attendance. > > Also, please replace all occurrences of "ssl2" in text strings with "SSL2" (or "SSL 2.0" as used in > the specification). Acronyms of names are always upper case in English. > ok! > Here is updated version. Sorry for delay, I was hacking the documentation generator. Now its one (discussing with Lukas concurrently edited code), ad I think you will like it :) J. -------------- next part -------------- A non-text attachment was scrubbed... Name: httpsSolution_05.patch Type: text/x-patch Size: 39993 bytes Desc: not available URL: From andrew at icedtea.classpath.org Wed Sep 3 14:34:39 2014 From: andrew at icedtea.classpath.org (andrew at icedtea.classpath.org) Date: Wed, 03 Sep 2014 14:34:39 +0000 Subject: /hg/release/icedtea7-forest-2.5/jdk: Start 2.5.3 release cycle Message-ID: changeset eb70b48e4211 in /hg/release/icedtea7-forest-2.5/jdk details: http://icedtea.classpath.org/hg/release/icedtea7-forest-2.5/jdk?cmd=changeset;node=eb70b48e4211 author: andrew date: Wed Sep 03 15:34:29 2014 +0100 Start 2.5.3 release cycle diffstat: make/jdk_generic_profile.sh | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diffs (12 lines): diff -r 229136ffcb00 -r eb70b48e4211 make/jdk_generic_profile.sh --- a/make/jdk_generic_profile.sh Fri Aug 29 21:08:23 2014 +0100 +++ b/make/jdk_generic_profile.sh Wed Sep 03 15:34:29 2014 +0100 @@ -573,7 +573,7 @@ # IcedTea versioning export ICEDTEA_NAME="IcedTea" -export PACKAGE_VERSION="2.5.2" +export PACKAGE_VERSION="2.5.3pre00" export DERIVATIVE_ID="${ICEDTEA_NAME} ${PACKAGE_VERSION}" if [ -e ${jdk_topdir} ] ; then From andrew at icedtea.classpath.org Wed Sep 3 14:34:57 2014 From: andrew at icedtea.classpath.org (andrew at icedtea.classpath.org) Date: Wed, 03 Sep 2014 14:34:57 +0000 Subject: /hg/release/icedtea7-2.5: 3 new changesets Message-ID: changeset 7a5b620a054a in /hg/release/icedtea7-2.5 details: http://icedtea.classpath.org/hg/release/icedtea7-2.5?cmd=changeset;node=7a5b620a054a author: Andrew John Hughes date: Fri Aug 29 21:45:13 2014 +0100 Prepare for 2.5.2 release. 2014-08-29 Andrew John Hughes * NEWS: Set release date for 2.5.2. changeset 07567fde7651 in /hg/release/icedtea7-2.5 details: http://icedtea.classpath.org/hg/release/icedtea7-2.5?cmd=changeset;node=07567fde7651 author: Andrew John Hughes date: Tue Sep 02 05:18:16 2014 +0100 Added tag icedtea-2.5.2 for changeset 7a5b620a054a changeset 00016055e63f in /hg/release/icedtea7-2.5 details: http://icedtea.classpath.org/hg/release/icedtea7-2.5?cmd=changeset;node=00016055e63f author: Andrew John Hughes date: Wed Sep 03 15:33:40 2014 +0100 Start 2.5.3 release cycle. 2014-09-03 Andrew John Hughes * configure.ac: Set to 2.5.3pre00. * NEWS: Add release section for 2.5.3. diffstat: .hgtags | 1 + ChangeLog | 9 +++++++++ NEWS | 4 +++- configure.ac | 2 +- 4 files changed, 14 insertions(+), 2 deletions(-) diffs (47 lines): diff -r 6e9490f61562 -r 00016055e63f .hgtags --- a/.hgtags Fri Aug 29 21:14:22 2014 +0100 +++ b/.hgtags Wed Sep 03 15:33:40 2014 +0100 @@ -38,3 +38,4 @@ b3eb30a2db9022bf34c51794ebe66f623c359d4c icedtea-2.5-branchpoint 81ffee9f8143a9ced4e3c418924f2641ed72b2cc icedtea-2.5.0 a2d9b45d7491a9c84afb33a457533817a7f3e600 icedtea-2.5.1 +7a5b620a054a6276333c4b3009d1a0dd5248a7f3 icedtea-2.5.2 diff -r 6e9490f61562 -r 00016055e63f ChangeLog --- a/ChangeLog Fri Aug 29 21:14:22 2014 +0100 +++ b/ChangeLog Wed Sep 03 15:33:40 2014 +0100 @@ -1,3 +1,12 @@ +2014-09-03 Andrew John Hughes + + * configure.ac: Set to 2.5.3pre00. + * NEWS: Add release section for 2.5.3. + +2014-08-29 Andrew John Hughes + + * NEWS: Set release date for 2.5.2. + 2014-08-29 Andrew John Hughes * NEWS: Update OpenJDK bug URL. diff -r 6e9490f61562 -r 00016055e63f NEWS --- a/NEWS Fri Aug 29 21:14:22 2014 +0100 +++ b/NEWS Wed Sep 03 15:33:40 2014 +0100 @@ -12,7 +12,9 @@ CVE-XXXX-YYYY: http://www.cve.mitre.org/cgi-bin/cvename.cgi?name=XXXX-YYYY -New in release 2.5.2 (2014-10-XX): +New in release 2.5.3 (2014-10-XX): + +New in release 2.5.2 (2014-08-29): * Backports - S8049480: Current versions of Java can't verify jars signed and timestamped with Java 9 diff -r 6e9490f61562 -r 00016055e63f configure.ac --- a/configure.ac Fri Aug 29 21:14:22 2014 +0100 +++ b/configure.ac Wed Sep 03 15:33:40 2014 +0100 @@ -1,4 +1,4 @@ -AC_INIT([icedtea], [2.5.2], [distro-pkg-dev at openjdk.java.net]) +AC_INIT([icedtea], [2.5.3pre00], [distro-pkg-dev at openjdk.java.net]) AM_INIT_AUTOMAKE([1.9 tar-pax foreign]) AM_MAINTAINER_MODE([enable]) AC_CONFIG_FILES([Makefile]) From andrew at icedtea.classpath.org Wed Sep 3 14:37:32 2014 From: andrew at icedtea.classpath.org (andrew at icedtea.classpath.org) Date: Wed, 03 Sep 2014 14:37:32 +0000 Subject: /hg/icedtea7: Add 2.5.2 release notes. Message-ID: changeset 941db1268ae7 in /hg/icedtea7 details: http://icedtea.classpath.org/hg/icedtea7?cmd=changeset;node=941db1268ae7 author: Andrew John Hughes date: Wed Sep 03 15:37:20 2014 +0100 Add 2.5.2 release notes. 2014-09-03 Andrew John Hughes * NEWS: Add 2.5.2 release notes. diffstat: ChangeLog | 4 ++++ NEWS | 11 +++++++++-- 2 files changed, 13 insertions(+), 2 deletions(-) diffs (48 lines): diff -r 864ddd2fd71e -r 941db1268ae7 ChangeLog --- a/ChangeLog Fri Aug 29 21:57:28 2014 +0100 +++ b/ChangeLog Wed Sep 03 15:37:20 2014 +0100 @@ -1,3 +1,7 @@ +2014-09-03 Andrew John Hughes + + * NEWS: Add 2.5.2 release notes. + 2014-08-29 Andrew John Hughes * NEWS: Update OpenJDK bug URL. diff -r 864ddd2fd71e -r 941db1268ae7 NEWS --- a/NEWS Fri Aug 29 21:57:28 2014 +0100 +++ b/NEWS Wed Sep 03 15:37:20 2014 +0100 @@ -180,14 +180,12 @@ - S8048506: [macosx] javax.swing.PopupFactory issue with null owner - S8048887: SortingFocusTraversalPolicy throws IllegalArgumentException from the sort method - S8049250: Need a flag to invert the Card.disconnect(reset) argument - - S8049480: Current versions of Java can't verify jars signed and timestamped with Java 9 - S8049514: FEATURE_SECURE_PROCESSING can not be turned off on a validator through SchemaFactory - S8049542: C2: assert(size_in_words <= (julong)max_jint) failed: no overflow - S8050165: linux-sparcv9: NMT detail causes assert((intptr_t*)younger_sp[FP->sp_offset_in_saved_window()] == (intptr_t*)((intptr_t)sp - STACK_BIAS)) failed: younger_sp must be valid - S8050167: linux-sparcv9: hs_err file does not show any stack information - S8050386: javac, follow-up of fix for JDK-8049305 - S8051004: javac, incorrect bug id in tests for JDK-8050386 - - S8051012: Regression in verifier for method call from inside of a branch - S8051844: BootstrapMethods attribute cannot be empty again - S8052159: TEST_BUG: javax/swing/JTextField/8036819/bug8036819.java fails to compile - S8054841: (process) ProcessBuilder leaks native memory @@ -198,9 +196,18 @@ - PR1786: Allow x86 build to occur on x86_64 using a previously built x86_64 build - PR1846: Build fails when using IcedTea7 as bootstrap JDK with native ecj - PR1847: Synchronise javac.in with IcedTea6 + +New in release 2.5.2 (2014-08-29): + +* Backports + - S8049480: Current versions of Java can't verify jars signed and timestamped with Java 9 + - S8051012, LP1360392: Regression in verifier for method call from inside of a branch +* Bug fixes - PR1903: [REGRESSION] Bug reports now lack IcedTea version & distribution packaging information - PR1948: Only try and symlink debuginfo if STRIP_POLICY is other than no_strip - PR1948: Fix indenting + - PR1966: Move to new OpenJDK bug URL format + - RH1015432: java-1.7.0-openjdk: Fails on PPC with StackOverflowError (revised fix for PPC32) * PPC & AIX port - Adapt AIX port to 5049299: (process) Use posix_spawn, not fork, on S10 to avoid swap exhaustion - Adapt aix to 8022507 From andrew at icedtea.classpath.org Wed Sep 3 14:57:43 2014 From: andrew at icedtea.classpath.org (andrew at icedtea.classpath.org) Date: Wed, 03 Sep 2014 14:57:43 +0000 Subject: /hg/icedtea7-forest/hotspot: RH1015432: java-1.7.0-openjdk: Fail... Message-ID: changeset 304c66cf5010 in /hg/icedtea7-forest/hotspot details: http://icedtea.classpath.org/hg/icedtea7-forest/hotspot?cmd=changeset;node=304c66cf5010 author: andrew date: Thu Aug 28 15:26:22 2014 +0100 RH1015432: java-1.7.0-openjdk: Fails on PPC with StackOverflowError (revised fix for PPC32) Contributed-by: chphilli at redhat.com diffstat: src/os/linux/vm/os_linux.cpp | 10 +++++++++- 1 files changed, 9 insertions(+), 1 deletions(-) diffs (37 lines): diff -r 69d9f2195369 -r 304c66cf5010 src/os/linux/vm/os_linux.cpp --- a/src/os/linux/vm/os_linux.cpp Wed Aug 27 23:07:43 2014 +0100 +++ b/src/os/linux/vm/os_linux.cpp Thu Aug 28 15:26:22 2014 +0100 @@ -4854,6 +4854,7 @@ pthread_mutex_init(&dl_mutex, NULL); +NOT_ZERO ( // If the pagesize of the VM is greater than 8K determine the appropriate // number of initial guard pages. The user can change this with the // command line arguments, if needed. @@ -4862,6 +4863,7 @@ StackRedPages = 1; StackShadowPages = round_to((StackShadowPages*Linux::vm_default_page_size()), vm_page_size()) / vm_page_size(); } + ) } // To install functions for atexit system call @@ -4914,10 +4916,16 @@ // size. Add a page for compiler2 recursion in main thread. // Add in 2*BytesPerWord times page size to account for VM stack during // class initialization depending on 32 or 64 bit VM. +NOT_ZERO ( os::Linux::min_stack_allowed = MAX2(os::Linux::min_stack_allowed, (size_t)(StackYellowPages+StackRedPages+StackShadowPages) * Linux::page_size() + (2*BytesPerWord COMPILER2_PRESENT(+1)) * Linux::vm_default_page_size()); - + ) +ZERO_ONLY ( + os::Linux::min_stack_allowed = MAX2(os::Linux::min_stack_allowed, + (size_t)(StackYellowPages+StackRedPages+StackShadowPages+ + 2*BytesPerWord COMPILER2_PRESENT(+1)) * Linux::page_size()); + ) size_t threadStackSizeInBytes = ThreadStackSize * K; if (threadStackSizeInBytes != 0 && threadStackSizeInBytes < os::Linux::min_stack_allowed) { From andrew at icedtea.classpath.org Wed Sep 3 15:32:51 2014 From: andrew at icedtea.classpath.org (andrew at icedtea.classpath.org) Date: Wed, 03 Sep 2014 15:32:51 +0000 Subject: /hg/icedtea: PR1367: Support using the system installation of LCMS Message-ID: changeset 3680c74438e9 in /hg/icedtea details: http://icedtea.classpath.org/hg/icedtea?cmd=changeset;node=3680c74438e9 author: Andrew John Hughes date: Wed Sep 03 16:32:44 2014 +0100 PR1367: Support using the system installation of LCMS 2014-09-03 Andrew John Hughes * NEWS: Add bug reference for system LCMS support. diffstat: ChangeLog | 4 ++++ NEWS | 1 + 2 files changed, 5 insertions(+), 0 deletions(-) diffs (22 lines): diff -r 715fa1507f8d -r 3680c74438e9 ChangeLog --- a/ChangeLog Fri Aug 29 19:20:28 2014 +0100 +++ b/ChangeLog Wed Sep 03 16:32:44 2014 +0100 @@ -1,3 +1,7 @@ +2014-09-03 Andrew John Hughes + + * NEWS: Add bug reference for system LCMS support. + 2014-08-29 Andrew John Hughes * NEWS: Add bug reference for AArch64 import. diff -r 715fa1507f8d -r 3680c74438e9 NEWS --- a/NEWS Fri Aug 29 19:20:28 2014 +0100 +++ b/NEWS Wed Sep 03 16:32:44 2014 +0100 @@ -32,6 +32,7 @@ - PR1357: Make XRender mandatory - PR1359: Check for /usr/lib64 JVMs and generic JPackage alternative - PR1364: Replace hgforest support + - PR1367: Support using the system installation of LCMS - PR1379: Add build support for Zero AArch64 - PR1766: Expand architecture support - PR1774: Support GIF lib v5 From bugzilla-daemon at icedtea.classpath.org Wed Sep 3 15:33:00 2014 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Wed, 03 Sep 2014 15:33:00 +0000 Subject: [Bug 1367] [IcedTea8] Support using the system installation of LCMS In-Reply-To: References: Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1367 --- Comment #1 from hg commits --- details: http://icedtea.classpath.org//hg/icedtea?cmd=changeset;node=3680c74438e9 author: Andrew John Hughes date: Wed Sep 03 16:32:44 2014 +0100 PR1367: Support using the system installation of LCMS 2014-09-03 Andrew John Hughes * NEWS: Add bug reference for system LCMS support. -- You are receiving this mail because: You are on the CC list for the bug. -------------- next part -------------- An HTML attachment was scrubbed... URL: From bugzilla-daemon at icedtea.classpath.org Wed Sep 3 15:58:16 2014 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Wed, 03 Sep 2014 15:58:16 +0000 Subject: [Bug 1282] [TRACKER] IcedTea 3.0.0 Release In-Reply-To: References: Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1282 Bug 1282 depends on bug 1367, which changed state. Bug 1367 Summary: [IcedTea8] Support using the system installation of LCMS http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1367 What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug. -------------- next part -------------- An HTML attachment was scrubbed... URL: From bugzilla-daemon at icedtea.classpath.org Wed Sep 3 15:58:16 2014 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Wed, 03 Sep 2014 15:58:16 +0000 Subject: [Bug 1367] [IcedTea8] Support using the system installation of LCMS In-Reply-To: References: Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1367 Andrew John Hughes changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug. -------------- next part -------------- An HTML attachment was scrubbed... URL: From bugzilla-daemon at icedtea.classpath.org Wed Sep 3 15:59:58 2014 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Wed, 03 Sep 2014 15:59:58 +0000 Subject: [Bug 1975] New: [IcedTea8] Add garbage collection probes for SystemTap Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1975 Bug ID: 1975 Summary: [IcedTea8] Add garbage collection probes for SystemTap Product: IcedTea Version: 8-hg Hardware: all OS: All Status: NEW Severity: normal Priority: P5 Component: IcedTea Assignee: gnu.andrew at redhat.com Reporter: gnu.andrew at redhat.com CC: unassigned at icedtea.classpath.org -- You are receiving this mail because: You are on the CC list for the bug. -------------- next part -------------- An HTML attachment was scrubbed... URL: From bugzilla-daemon at icedtea.classpath.org Wed Sep 3 16:00:41 2014 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Wed, 03 Sep 2014 16:00:41 +0000 Subject: [Bug 1975] [IcedTea8] Add garbage collection probes for SystemTap In-Reply-To: References: Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1975 Andrew John Hughes changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Blocks| |1282 Target Milestone|--- |3.0.0 --- Comment #1 from Andrew John Hughes --- No file /home/andrew/build/icedtea8/tapset/hotspot_gc.stp -- You are receiving this mail because: You are on the CC list for the bug. -------------- next part -------------- An HTML attachment was scrubbed... URL: From bugzilla-daemon at icedtea.classpath.org Wed Sep 3 16:00:41 2014 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Wed, 03 Sep 2014 16:00:41 +0000 Subject: [Bug 1282] [TRACKER] IcedTea 3.0.0 Release In-Reply-To: References: Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1282 Andrew John Hughes changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |1975 -- You are receiving this mail because: You are on the CC list for the bug. -------------- next part -------------- An HTML attachment was scrubbed... URL: From bugzilla-daemon at icedtea.classpath.org Wed Sep 3 16:02:57 2014 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Wed, 03 Sep 2014 16:02:57 +0000 Subject: [Bug 1976] New: [IcedTea8] Support using the system installation of Glib/GIO Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1976 Bug ID: 1976 Summary: [IcedTea8] Support using the system installation of Glib/GIO Product: IcedTea Version: 8-hg Hardware: all OS: All Status: NEW Severity: normal Priority: P5 Component: IcedTea Assignee: gnu.andrew at redhat.com Reporter: gnu.andrew at redhat.com CC: unassigned at icedtea.classpath.org Comparing /home/andrew/build/icedtea7/jre/lib/amd64/libsctp.so and /home/andrew/build/icedtea8/jre/lib/amd64/libsctp.so linkage --- /tmp/.private/andrew/ld1 2014-09-03 16:50:39.080959765 +0100 +++ /tmp/.private/andrew/ld2 2014-09-03 16:50:39.092959935 +0100 @@ -1,11 +1,6 @@ /lib64/ld-linux-x86-64.so.2 libc.so.6 libdl.so.2 - libffi.so.6 - libgio-2.0.so.0 - libglib-2.0.so.0 - libgmodule-2.0.so.0 - libgobject-2.0.so.0 libjava.so libjvm.so libjvm.so Comparing /home/andrew/build/icedtea7/jre/lib/amd64/libnio.so and /home/andrew/build/icedtea8/jre/lib/amd64/libnio.so linkage --- /tmp/.private/andrew/ld1 2014-09-03 16:50:39.224961826 +0100 +++ /tmp/.private/andrew/ld2 2014-09-03 16:50:39.232961940 +0100 @@ -1,18 +1,11 @@ /lib64/ld-linux-x86-64.so.2 libc.so.6 libdl.so.2 - libffi.so.6 - libgio-2.0.so.0 - libglib-2.0.so.0 - libgmodule-2.0.so.0 - libgobject-2.0.so.0 Comparing /home/andrew/build/icedtea7/jre/lib/amd64/libnet.so and /home/andrew/build/icedtea8/jre/lib/amd64/libnet.so linkage --- /tmp/.private/andrew/ld1 2014-09-03 16:50:39.444964975 +0100 +++ /tmp/.private/andrew/ld2 2014-09-03 16:50:39.456965146 +0100 @@ -1,17 +1,10 @@ /lib64/ld-linux-x86-64.so.2 libc.so.6 libdl.so.2 - libffi.so.6 - libgio-2.0.so.0 - libglib-2.0.so.0 - libgmodule-2.0.so.0 - libgobject-2.0.so.0 -- You are receiving this mail because: You are on the CC list for the bug. -------------- next part -------------- An HTML attachment was scrubbed... URL: From bugzilla-daemon at icedtea.classpath.org Wed Sep 3 16:03:17 2014 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Wed, 03 Sep 2014 16:03:17 +0000 Subject: [Bug 1282] [TRACKER] IcedTea 3.0.0 Release In-Reply-To: References: Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1282 Andrew John Hughes changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |1976 -- You are receiving this mail because: You are on the CC list for the bug. -------------- next part -------------- An HTML attachment was scrubbed... URL: From bugzilla-daemon at icedtea.classpath.org Wed Sep 3 16:03:17 2014 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Wed, 03 Sep 2014 16:03:17 +0000 Subject: [Bug 1976] [IcedTea8] Support using the system installation of Glib/GIO In-Reply-To: References: Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1976 Andrew John Hughes changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Blocks| |1282 Target Milestone|--- |3.0.0 -- You are receiving this mail because: You are on the CC list for the bug. -------------- next part -------------- An HTML attachment was scrubbed... URL: From bugzilla-daemon at icedtea.classpath.org Wed Sep 3 16:06:09 2014 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Wed, 03 Sep 2014 16:06:09 +0000 Subject: [Bug 1977] New: [IcedTea8] Support using the system installation of Zlib Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1977 Bug ID: 1977 Summary: [IcedTea8] Support using the system installation of Zlib Product: IcedTea Version: 8-hg Hardware: all OS: All Status: NEW Severity: normal Priority: P5 Component: IcedTea Assignee: gnu.andrew at redhat.com Reporter: gnu.andrew at redhat.com CC: unassigned at icedtea.classpath.org - libz.so.1 in libnet.so, libsctp.so, libnio.so. -- You are receiving this mail because: You are on the CC list for the bug. -------------- next part -------------- An HTML attachment was scrubbed... URL: From bugzilla-daemon at icedtea.classpath.org Wed Sep 3 16:07:57 2014 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Wed, 03 Sep 2014 16:07:57 +0000 Subject: [Bug 1282] [TRACKER] IcedTea 3.0.0 Release In-Reply-To: References: Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1282 Andrew John Hughes changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |1977 -- You are receiving this mail because: You are on the CC list for the bug. -------------- next part -------------- An HTML attachment was scrubbed... URL: From bugzilla-daemon at icedtea.classpath.org Wed Sep 3 16:07:57 2014 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Wed, 03 Sep 2014 16:07:57 +0000 Subject: [Bug 1977] [IcedTea8] Support using the system installation of Zlib In-Reply-To: References: Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1977 Andrew John Hughes changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Blocks| |1282 Target Milestone|--- |3.0.0 --- Comment #1 from Andrew John Hughes --- Actually seems to be already using the system version and this missing libz linkage is perhaps down to PR1976 system libGIO/Glib. -- You are receiving this mail because: You are on the CC list for the bug. -------------- next part -------------- An HTML attachment was scrubbed... URL: From bugzilla-daemon at icedtea.classpath.org Wed Sep 3 16:10:24 2014 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Wed, 03 Sep 2014 16:10:24 +0000 Subject: [Bug 1281] [IcedTea8] Shared class data archive should be generated post-build on architectures with the client VM In-Reply-To: References: Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1281 --- Comment #2 from Andrew John Hughes --- No file /home/andrew/build/icedtea8/jre/lib/amd64/server/classes.jsa -- You are receiving this mail because: You are on the CC list for the bug. -------------- next part -------------- An HTML attachment was scrubbed... URL: From bugzilla-daemon at icedtea.classpath.org Wed Sep 3 16:11:54 2014 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Wed, 03 Sep 2014 16:11:54 +0000 Subject: [Bug 1978] New: [IcedTea8] Support using the system installation of libpcsclite Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1978 Bug ID: 1978 Summary: [IcedTea8] Support using the system installation of libpcsclite Product: IcedTea Version: 8-hg Hardware: all OS: All Status: NEW Severity: major Priority: P5 Component: IcedTea Assignee: gnu.andrew at redhat.com Reporter: gnu.andrew at redhat.com CC: unassigned at icedtea.classpath.org 8 version of PR1660. Comparing /home/andrew/build/icedtea7/jre/lib/amd64/libj2pcsc.so and /home/andrew/build/icedtea8/jre/lib/amd64/libj2pcsc.so linkage --- /tmp/.private/andrew/ld1 2014-09-03 17:04:15.400590652 +0100 +++ /tmp/.private/andrew/ld2 2014-09-03 17:04:15.408590764 +0100 @@ -1,5 +1,4 @@ /lib64/ld-linux-x86-64.so.2 libc.so.6 - libpcsclite.so.1 - libpthread.so.0 + libdl.so.2 linux-vdso.so.1 -- You are receiving this mail because: You are on the CC list for the bug. -------------- next part -------------- An HTML attachment was scrubbed... URL: From bugzilla-daemon at icedtea.classpath.org Wed Sep 3 16:12:09 2014 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Wed, 03 Sep 2014 16:12:09 +0000 Subject: [Bug 1978] [IcedTea8] Support using the system installation of libpcsclite In-Reply-To: References: Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1978 Andrew John Hughes changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Blocks| |1282 Target Milestone|--- |3.0.0 -- You are receiving this mail because: You are on the CC list for the bug. -------------- next part -------------- An HTML attachment was scrubbed... URL: From bugzilla-daemon at icedtea.classpath.org Wed Sep 3 16:12:09 2014 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Wed, 03 Sep 2014 16:12:09 +0000 Subject: [Bug 1282] [TRACKER] IcedTea 3.0.0 Release In-Reply-To: References: Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1282 Andrew John Hughes changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |1978 -- You are receiving this mail because: You are on the CC list for the bug. -------------- next part -------------- An HTML attachment was scrubbed... URL: From bugzilla-daemon at icedtea.classpath.org Wed Sep 3 16:12:27 2014 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Wed, 03 Sep 2014 16:12:27 +0000 Subject: [Bug 1537] [IcedTea8] Allow use of system Kerberos to obtain cache location In-Reply-To: References: Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1537 --- Comment #1 from Andrew John Hughes --- No file /home/andrew/build/icedtea8/jre/lib/amd64/libj2krb5.so -- You are receiving this mail because: You are on the CC list for the bug. -------------- next part -------------- An HTML attachment was scrubbed... URL: From bugzilla-daemon at icedtea.classpath.org Wed Sep 3 16:13:17 2014 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Wed, 03 Sep 2014 16:13:17 +0000 Subject: [Bug 1979] New: [IcedTea8] Support using the system installation of libjpeg Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1979 Bug ID: 1979 Summary: [IcedTea8] Support using the system installation of libjpeg Product: IcedTea Version: 8-hg Hardware: all OS: All Status: NEW Severity: normal Priority: P5 Component: IcedTea Assignee: gnu.andrew at redhat.com Reporter: gnu.andrew at redhat.com CC: unassigned at icedtea.classpath.org Comparing /home/andrew/build/icedtea7/jre/lib/amd64/libjavajpeg.so and /home/andrew/build/icedtea8/jre/lib/amd64/libjavajpeg.so linkage --- /tmp/.private/andrew/ld1 2014-09-03 17:04:15.524592400 +0100 +++ /tmp/.private/andrew/ld2 2014-09-03 17:04:15.536592569 +0100 @@ -2,7 +2,6 @@ libc.so.6 libdl.so.2 libjava.so - libjpeg.so.62 libjvm.so libjvm.so libjvm.so -- You are receiving this mail because: You are on the CC list for the bug. -------------- next part -------------- An HTML attachment was scrubbed... URL: From bugzilla-daemon at icedtea.classpath.org Wed Sep 3 16:14:27 2014 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Wed, 03 Sep 2014 16:14:27 +0000 Subject: [Bug 1979] [IcedTea8] Support using the system installation of libjpeg In-Reply-To: References: Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1979 Andrew John Hughes changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED URL| |https://bugs.openjdk.java.n | |et/browse/JDK-8043805 Blocks| |1282 Target Milestone|--- |3.0.0 --- Comment #1 from Andrew John Hughes --- changeset: 10013:03f9102db2c0 tag: icedtea-3.0.0pre02 user: omajid date: Fri May 23 11:04:37 2014 -0400 summary: 8043805: Allow using a system-installed libjpeg -- You are receiving this mail because: You are on the CC list for the bug. -------------- next part -------------- An HTML attachment was scrubbed... URL: From bugzilla-daemon at icedtea.classpath.org Wed Sep 3 16:14:27 2014 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Wed, 03 Sep 2014 16:14:27 +0000 Subject: [Bug 1282] [TRACKER] IcedTea 3.0.0 Release In-Reply-To: References: Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1282 Andrew John Hughes changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |1979 -- You are receiving this mail because: You are on the CC list for the bug. -------------- next part -------------- An HTML attachment was scrubbed... URL: From bugzilla-daemon at icedtea.classpath.org Wed Sep 3 16:15:37 2014 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Wed, 03 Sep 2014 16:15:37 +0000 Subject: [Bug 1980] New: [IcedTea8] Support using the system installation of giflib Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1980 Bug ID: 1980 Summary: [IcedTea8] Support using the system installation of giflib Product: IcedTea Version: 8-hg Hardware: all OS: All Status: NEW Severity: normal Priority: P5 Component: IcedTea Assignee: gnu.andrew at redhat.com Reporter: gnu.andrew at redhat.com CC: unassigned at icedtea.classpath.org Comparing /home/andrew/build/icedtea7/jre/lib/amd64/libsplashscreen.so and /home/andrew/build/icedtea8/jre/lib/amd64/libsplashscreen.so linkage --- /tmp/.private/andrew/ld1 2014-09-03 17:04:15.628593866 +0100 +++ /tmp/.private/andrew/ld2 2014-09-03 17:04:15.644594091 +0100 @@ -1,10 +1,7 @@ /lib64/ld-linux-x86-64.so.2 libc.so.6 libdl.so.2 - libgif.so.6 -- You are receiving this mail because: You are on the CC list for the bug. -------------- next part -------------- An HTML attachment was scrubbed... URL: From bugzilla-daemon at icedtea.classpath.org Wed Sep 3 16:17:22 2014 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Wed, 03 Sep 2014 16:17:22 +0000 Subject: [Bug 1980] [IcedTea8] Support using the system installation of giflib In-Reply-To: References: Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1980 Andrew John Hughes changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED URL| |https://bugs.openjdk.java.n | |et/browse/JDK-8011278 Blocks| |1282 Target Milestone|--- |3.0.0 --- Comment #1 from Andrew John Hughes --- changeset: 7011:9c76ea43d491 user: omajid date: Tue Apr 02 14:13:13 2013 -0400 summary: 8011278: Allow using a system-installed giflib -- You are receiving this mail because: You are on the CC list for the bug. -------------- next part -------------- An HTML attachment was scrubbed... URL: From bugzilla-daemon at icedtea.classpath.org Wed Sep 3 16:17:22 2014 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Wed, 03 Sep 2014 16:17:22 +0000 Subject: [Bug 1282] [TRACKER] IcedTea 3.0.0 Release In-Reply-To: References: Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1282 Andrew John Hughes changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |1980 -- You are receiving this mail because: You are on the CC list for the bug. -------------- next part -------------- An HTML attachment was scrubbed... URL: From bugzilla-daemon at icedtea.classpath.org Wed Sep 3 16:18:22 2014 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Wed, 03 Sep 2014 16:18:22 +0000 Subject: [Bug 1981] New: [IcedTea8] Support using the system installation of libpng Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1981 Bug ID: 1981 Summary: [IcedTea8] Support using the system installation of libpng Product: IcedTea Version: 8-hg Hardware: all OS: All Status: NEW Severity: normal Priority: P5 Component: IcedTea Assignee: gnu.andrew at redhat.com Reporter: gnu.andrew at redhat.com CC: unassigned at icedtea.classpath.org Comparing /home/andrew/build/icedtea7/jre/lib/amd64/libsplashscreen.so and /home/andrew/build/icedtea8/jre/lib/amd64/libsplashscreen.so linkage --- /tmp/.private/andrew/ld1 2014-09-03 17:04:15.628593866 +0100 +++ /tmp/.private/andrew/ld2 2014-09-03 17:04:15.644594091 +0100 @@ -1,10 +1,7 @@ /lib64/ld-linux-x86-64.so.2 libc.so.6 libdl.so.2 - libgif.so.6 - libjpeg.so.62 libm.so.6 - libpng16.so.16 libpthread.so.0 libX11.so.6 libXau.so.6 -- You are receiving this mail because: You are on the CC list for the bug. -------------- next part -------------- An HTML attachment was scrubbed... URL: From bugzilla-daemon at icedtea.classpath.org Wed Sep 3 16:19:02 2014 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Wed, 03 Sep 2014 16:19:02 +0000 Subject: [Bug 1981] [IcedTea8] Support using the system installation of libpng In-Reply-To: References: Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1981 Andrew John Hughes changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED URL| |https://bugs.openjdk.java.n | |et/browse/JDK-8035341 Blocks| |1282 Target Milestone|--- |3.0.0 --- Comment #1 from Andrew John Hughes --- changeset: 9620:f1d3a9182ff9 user: omajid date: Thu Feb 20 10:07:54 2014 -0500 summary: 8035341: Allow using a system installed libpng -- You are receiving this mail because: You are on the CC list for the bug. -------------- next part -------------- An HTML attachment was scrubbed... URL: From bugzilla-daemon at icedtea.classpath.org Wed Sep 3 16:19:02 2014 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Wed, 03 Sep 2014 16:19:02 +0000 Subject: [Bug 1282] [TRACKER] IcedTea 3.0.0 Release In-Reply-To: References: Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1282 Andrew John Hughes changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |1981 -- You are receiving this mail because: You are on the CC list for the bug. -------------- next part -------------- An HTML attachment was scrubbed... URL: From bugzilla-daemon at icedtea.classpath.org Wed Sep 3 16:20:01 2014 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Wed, 03 Sep 2014 16:20:01 +0000 Subject: [Bug 1982] New: [IcedTea8] Support using the system installation of Gtk+ Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1982 Bug ID: 1982 Summary: [IcedTea8] Support using the system installation of Gtk+ Product: IcedTea Version: 8-hg Hardware: all OS: All Status: NEW Severity: normal Priority: P5 Component: IcedTea Assignee: gnu.andrew at redhat.com Reporter: gnu.andrew at redhat.com CC: unassigned at icedtea.classpath.org No file /home/andrew/build/icedtea8/jre/lib/amd64/libjavagtk.so -- You are receiving this mail because: You are on the CC list for the bug. -------------- next part -------------- An HTML attachment was scrubbed... URL: From bugzilla-daemon at icedtea.classpath.org Wed Sep 3 16:20:14 2014 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Wed, 03 Sep 2014 16:20:14 +0000 Subject: [Bug 1982] [IcedTea8] Support using the system installation of Gtk+ In-Reply-To: References: Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1982 Andrew John Hughes changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Blocks| |1282 Target Milestone|--- |3.0.0 -- You are receiving this mail because: You are on the CC list for the bug. -------------- next part -------------- An HTML attachment was scrubbed... URL: From bugzilla-daemon at icedtea.classpath.org Wed Sep 3 16:20:14 2014 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Wed, 03 Sep 2014 16:20:14 +0000 Subject: [Bug 1282] [TRACKER] IcedTea 3.0.0 Release In-Reply-To: References: Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1282 Andrew John Hughes changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |1982 -- You are receiving this mail because: You are on the CC list for the bug. -------------- next part -------------- An HTML attachment was scrubbed... URL: From bugzilla-daemon at icedtea.classpath.org Wed Sep 3 16:25:06 2014 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Wed, 03 Sep 2014 16:25:06 +0000 Subject: [Bug 1983] New: [IcedTea8] Support using the system installation of NSS with the SunEC provider Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1983 Bug ID: 1983 Summary: [IcedTea8] Support using the system installation of NSS with the SunEC provider Product: IcedTea Version: 8-hg Hardware: all OS: All Status: NEW Severity: normal Priority: P5 Component: IcedTea Assignee: gnu.andrew at redhat.com Reporter: gnu.andrew at redhat.com CC: unassigned at icedtea.classpath.org See PR1699 and PR1742 for IcedTea 2.x -- You are receiving this mail because: You are on the CC list for the bug. -------------- next part -------------- An HTML attachment was scrubbed... URL: From bugzilla-daemon at icedtea.classpath.org Wed Sep 3 16:25:23 2014 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Wed, 03 Sep 2014 16:25:23 +0000 Subject: [Bug 1983] [IcedTea8] Support using the system installation of NSS with the SunEC provider In-Reply-To: References: Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1983 Andrew John Hughes changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Blocks| |1282 Target Milestone|--- |3.0.0 -- You are receiving this mail because: You are on the CC list for the bug. -------------- next part -------------- An HTML attachment was scrubbed... URL: From bugzilla-daemon at icedtea.classpath.org Wed Sep 3 16:25:23 2014 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Wed, 03 Sep 2014 16:25:23 +0000 Subject: [Bug 1282] [TRACKER] IcedTea 3.0.0 Release In-Reply-To: References: Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1282 Andrew John Hughes changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |1983 -- You are receiving this mail because: You are on the CC list for the bug. -------------- next part -------------- An HTML attachment was scrubbed... URL: From bugzilla-daemon at icedtea.classpath.org Wed Sep 3 16:27:17 2014 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Wed, 03 Sep 2014 16:27:17 +0000 Subject: [Bug 1368] [IcedTea8] Ensure debug data is available for all libraries and binaries without redundant files In-Reply-To: References: Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1368 --- Comment #5 from Andrew John Hughes --- No file /home/andrew/build/icedtea7/jre/lib/amd64/libjsig.diz No file /home/andrew/build/icedtea7/jre/lib/amd64/libjsdt.diz No file /home/andrew/build/icedtea7/jre/lib/amd64/libmlib_image.diz No file /home/andrew/build/icedtea7/jre/lib/amd64/libattach.diz No file /home/andrew/build/icedtea7/jre/lib/amd64/jli/libjli.diz No file /home/andrew/build/icedtea7/jre/lib/amd64/libjavajpeg.diz No file /home/andrew/build/icedtea7/jre/lib/amd64/libsunec.diz No file /home/andrew/build/icedtea7/jre/lib/amd64/libjava_crw_demo.diz No file /home/andrew/build/icedtea7/jre/lib/amd64/libsplashscreen.diz No file /home/andrew/build/icedtea7/jre/lib/amd64/libhprof.diz No file /home/andrew/build/icedtea7/jre/lib/amd64/libj2pcsc.diz No file /home/andrew/build/icedtea7/jre/lib/amd64/libinstrument.diz No file /home/andrew/build/icedtea7/jre/lib/amd64/libsctp.diz No file /home/andrew/build/icedtea7/jre/lib/amd64/libsaproc.diz No file /home/andrew/build/icedtea7/jre/lib/amd64/libawt_headless.diz No file /home/andrew/build/icedtea7/jre/lib/amd64/libjaas_unix.diz No file /home/andrew/build/icedtea7/jre/lib/amd64/libfontmanager.diz No file /home/andrew/build/icedtea7/jre/lib/amd64/libnpt.diz No file /home/andrew/build/icedtea7/jre/lib/amd64/libjava.diz No file /home/andrew/build/icedtea7/jre/lib/amd64/libawt_xawt.diz No file /home/andrew/build/icedtea7/jre/lib/amd64/libzip.diz No file /home/andrew/build/icedtea7/jre/lib/amd64/libunpack.diz No file /home/andrew/build/icedtea7/jre/lib/amd64/server/libjsig.diz No file /home/andrew/build/icedtea7/jre/lib/amd64/server/libjvm.diz No file /home/andrew/build/icedtea7/jre/lib/amd64/liblcms.diz No file /home/andrew/build/icedtea7/jre/lib/amd64/libnet.diz No file /home/andrew/build/icedtea7/jre/lib/amd64/libmanagement.diz No file /home/andrew/build/icedtea7/jre/lib/amd64/libdt_socket.diz No file /home/andrew/build/icedtea7/jre/lib/amd64/libjsound.diz No file /home/andrew/build/icedtea7/jre/lib/amd64/libsunec.so No file /home/andrew/build/icedtea7/jre/lib/amd64/libj2pkcs11.diz No file /home/andrew/build/icedtea7/jre/lib/amd64/libj2gss.diz No file /home/andrew/build/icedtea7/jre/lib/amd64/libverify.diz No file /home/andrew/build/icedtea7/jre/lib/amd64/libjdwp.diz No file /home/andrew/build/icedtea7/jre/lib/amd64/libjawt.diz No file /home/andrew/build/icedtea7/jre/lib/amd64/libawt.diz No file /home/andrew/build/icedtea7/jre/lib/amd64/libjsoundalsa.diz No file /home/andrew/build/icedtea7/jre/lib/amd64/libnio.diz No file /home/andrew/build/icedtea7/jre/lib/jexec.diz -- You are receiving this mail because: You are on the CC list for the bug. -------------- next part -------------- An HTML attachment was scrubbed... URL: From helpcrypto at gmail.com Wed Sep 3 16:28:26 2014 From: helpcrypto at gmail.com (helpcrypto helpcrypto) Date: Wed, 3 Sep 2014 18:28:26 +0200 Subject: [rfc][icedtea-web][itweb-settings] Improve Icedtea-Web cache disk space In-Reply-To: <54071A8A.9050202@gmx.de> References: <319590383.4051363.1404829211485.JavaMail.zimbra@redhat.com> <1222082700.26083069.1409081718997.JavaMail.zimbra@redhat.com> <982339162.26695106.1409162928407.JavaMail.zimbra@redhat.com> <958305698.27235425.1409240834908.JavaMail.zimbra@redhat.com> <1885159478.27899833.1409329251634.JavaMail.zimbra@redhat.com> <540180DB.4050109@gmx.de> <54071A8A.9050202@gmx.de> Message-ID: I'll wait for a hidding patch then. On Wed, Sep 3, 2014 at 3:41 PM, Jacob Wisor wrote: > On 09/01/2014 at 02:59 PM, helpcrypto helpcrypto wrote: > >> On Sat, Aug 30, 2014 at 9:44 AM, Jacob Wisor wrote: >> >> No no, do not start playing around with visible and hidden UI components. >>> It is even worse when they change their layout or start jumping around >>> like >>> it is now. Generally, there is never any need to hide UI components. If >>> there seems to be, then either there is something wrong with the basic >>> design of a window or dialog, or you should have very good reasons to do >>> so. And, in this case there is surely *no* reason to hide any components >>> dynamically at all. Again, stick to disabling components. This should be >>> enough. >>> >>> @helpcrypto >>> Yes, it is against basic UI design principles to have hiding UI >>> components, unless there are really good reasons to do so. >>> >> >> Can you point a style guide, or a gui-best-practices which advices on >> that? >> > > Well, there are multiple guidelines available, depending on OS, window > managers and/or desktop managers. It is difficult to point to a specific > one in the case of SWT and Java because it is platform independent. But, I > suppose one could take Microsoft's UI guidelines as a basis because of it's > undeniable bread adoption. It also shares a large set of rules with other > UI guidelines form other vendors. > > > I have seen several GUIs wich only show the user what he needs to see, and >> I found them KISS-compliant >> > > I think you are mixing to concepts here. KISS is about technical > solutions, that is how things should be solved in order for other engineers > to comprehend the work of the original authors, and generally assumes that > simple technical solutions are usually the most effective or efficient ones. > > UI design guidelines employ a similar concept but not exactly KISS. Good > UI designs should not be overloaded with UI components and only display the > right amount of components required to accomplish the current task at hand. > Hence, users should not be overburdened with overloaded UIs. But, most > importantly UIs must not be confusing to users, and their behavior must be > intuitively and naturally predictable. Hiding and jumping UI controls feel > absolutely unnatural and inorganic. This is indeed bad behavior for UI > controls. > > I will give you a simple example why your way of thinking is flawed here. > Take for example a dialog with a list view and an edit button to edit the > list view items. Now, if no list view item would be selected then according > to your reasoning the edit button should be hidden because the user can > take no editing action while no list view item is selected. This is > absolutely confusing to the user. The user is supposed to be able to see > and know all the possible actions he can take at all times but should not > be able to take invalid actions. This is why the edit button in this > example has to stay always visible but not always enabled. Think about it. > ;-) > > Unfortunately, because of your attempt to play around with hiding UI >>> components you have introduced a new bug. When "Limit cache size" is >>> checked and the spinner is 0 then all components for setting up the cache >>> location suddenly disappear. >>> >> >> Limit checked, value=0->no cache, hence no need of location, compression >> >> level or anything. It's not a bug. >> The warning under spinner informs about that. >> > > This is logically correct but it is against basic UI design guidelines. It > is inorganic. > > > And, as soon as the value becomes greater than 1, they become visible >>> again. This is very odd, weird, and confusing. Again, do not play around >>> with hiding UI components. >>> >>> The reason why i suggested "no cach?" instead of 0. >> > > As mentioned before, the UI components handling the cache's location > should simply be disabled in this case. No real reason to hide them. > > Jacob > -------------- next part -------------- An HTML attachment was scrubbed... URL: From jkang at redhat.com Wed Sep 3 18:00:04 2014 From: jkang at redhat.com (Jie Kang) Date: Wed, 3 Sep 2014 14:00:04 -0400 (EDT) Subject: [rfc][icedtea-web][itweb-settings] Improve Icedtea-Web cache disk space In-Reply-To: References: <319590383.4051363.1404829211485.JavaMail.zimbra@redhat.com> <958305698.27235425.1409240834908.JavaMail.zimbra@redhat.com> <1885159478.27899833.1409329251634.JavaMail.zimbra@redhat.com> <540180DB.4050109@gmx.de> <54071A8A.9050202@gmx.de> Message-ID: <52819644.29735325.1409767204437.JavaMail.zimbra@redhat.com> Hello, My two cents: In terms of this particular patch I believe that compared to hiding/showing UI elements, disabling UI elements is slightly more user-friendly and much more developer-friendly (in regards to Swing and Java). There are numerous other tasks that need to be done and I think we should consider pushing a working version of this improvement quickly, and then updating over that if necessary. In regards to UI design philosophy and KISS (keep it simple stupid), I think we can argue over it all day long but rather than point to basic design guidelines or philosophies (since it all comes down to opinion), I think there are some simple rules that we can state and agree on such as, but not limited to: UI must work : There are a set of actions that can be performed and the UI must support these actions. UI must be simple : There are a set of actions that must be supported and the UI should support said actions with minimal effort on the part of the developer in creating this support, and on the user in accessing these actions. When it comes to minimal effort for the user, hiding/showing versus disabling to me is a neutral difference. It is not harder for the user to perform all actions when UI is shown/hidden based on when an action can be performed, but it is also not harder for the user to perform all actions when the UI is disabled/enabled based on when an action can be performed. However I think that hidden UI is more difficult for a user to learn about than disabled UI which is why I prefer enabling/disabling if necessary. Regards, ----- Original Message ----- > I'll wait for a hidding patch then. > > On Wed, Sep 3, 2014 at 3:41 PM, Jacob Wisor wrote: > > > On 09/01/2014 at 02:59 PM, helpcrypto helpcrypto wrote: > > > >> On Sat, Aug 30, 2014 at 9:44 AM, Jacob Wisor wrote: > >> > >> No no, do not start playing around with visible and hidden UI components. > >>> It is even worse when they change their layout or start jumping around > >>> like > >>> it is now. Generally, there is never any need to hide UI components. If > >>> there seems to be, then either there is something wrong with the basic > >>> design of a window or dialog, or you should have very good reasons to do > >>> so. And, in this case there is surely *no* reason to hide any components > >>> dynamically at all. Again, stick to disabling components. This should be > >>> enough. > >>> > >>> @helpcrypto > >>> Yes, it is against basic UI design principles to have hiding UI > >>> components, unless there are really good reasons to do so. > >>> > >> > >> Can you point a style guide, or a gui-best-practices which advices on > >> that? > >> > > > > Well, there are multiple guidelines available, depending on OS, window > > managers and/or desktop managers. It is difficult to point to a specific > > one in the case of SWT and Java because it is platform independent. But, I > > suppose one could take Microsoft's UI guidelines as a basis because of it's > > undeniable bread adoption. It also shares a large set of rules with other > > UI guidelines form other vendors. > > > > > > I have seen several GUIs wich only show the user what he needs to see, and > >> I found them KISS-compliant > >> > > > > I think you are mixing to concepts here. KISS is about technical > > solutions, that is how things should be solved in order for other engineers > > to comprehend the work of the original authors, and generally assumes that > > simple technical solutions are usually the most effective or efficient > > ones. > > > > UI design guidelines employ a similar concept but not exactly KISS. Good > > UI designs should not be overloaded with UI components and only display the > > right amount of components required to accomplish the current task at hand. > > Hence, users should not be overburdened with overloaded UIs. But, most > > importantly UIs must not be confusing to users, and their behavior must be > > intuitively and naturally predictable. Hiding and jumping UI controls feel > > absolutely unnatural and inorganic. This is indeed bad behavior for UI > > controls. > > > > I will give you a simple example why your way of thinking is flawed here. > > Take for example a dialog with a list view and an edit button to edit the > > list view items. Now, if no list view item would be selected then according > > to your reasoning the edit button should be hidden because the user can > > take no editing action while no list view item is selected. This is > > absolutely confusing to the user. The user is supposed to be able to see > > and know all the possible actions he can take at all times but should not > > be able to take invalid actions. This is why the edit button in this > > example has to stay always visible but not always enabled. Think about it. > > ;-) > > > > Unfortunately, because of your attempt to play around with hiding UI > >>> components you have introduced a new bug. When "Limit cache size" is > >>> checked and the spinner is 0 then all components for setting up the cache > >>> location suddenly disappear. > >>> > >> > >> Limit checked, value=0->no cache, hence no need of location, compression > >> > >> level or anything. It's not a bug. > >> The warning under spinner informs about that. > >> > > > > This is logically correct but it is against basic UI design guidelines. It > > is inorganic. > > > > > > And, as soon as the value becomes greater than 1, they become visible > >>> again. This is very odd, weird, and confusing. Again, do not play around > >>> with hiding UI components. > >>> > >>> The reason why i suggested "no cach?" instead of 0. > >> > > > > As mentioned before, the UI components handling the cache's location > > should simply be disabled in this case. No real reason to hide them. > > > > Jacob > > > -- Jie Kang From helpcrypto at gmail.com Thu Sep 4 06:33:32 2014 From: helpcrypto at gmail.com (helpcrypto helpcrypto) Date: Thu, 4 Sep 2014 08:33:32 +0200 Subject: [rfc][icedtea-web][itweb-settings] Improve Icedtea-Web cache disk space In-Reply-To: <52819644.29735325.1409767204437.JavaMail.zimbra@redhat.com> References: <319590383.4051363.1404829211485.JavaMail.zimbra@redhat.com> <958305698.27235425.1409240834908.JavaMail.zimbra@redhat.com> <1885159478.27899833.1409329251634.JavaMail.zimbra@redhat.com> <540180DB.4050109@gmx.de> <54071A8A.9050202@gmx.de> <52819644.29735325.1409767204437.JavaMail.zimbra@redhat.com> Message-ID: On Wed, Sep 3, 2014 at 8:00 PM, Jie Kang wrote: > There are numerous other tasks that need to be done and I think we should > consider pushing a working version of this improvement quickly, and then > updating over that if necessary. > > In regards to UI design philosophy and KISS (keep it simple stupid), I > think we can argue over it all day long > Both of these reasons made me say: > I'll wait for a *disabling* patch then. ;) -------------- next part -------------- An HTML attachment was scrubbed... URL: From ptisnovs at icedtea.classpath.org Thu Sep 4 08:22:32 2014 From: ptisnovs at icedtea.classpath.org (ptisnovs at icedtea.classpath.org) Date: Thu, 04 Sep 2014 08:22:32 +0000 Subject: /hg/gfx-test: Ten new tests added into CAGOperationsOnTwoOverlap... Message-ID: changeset 9f7b40fa8ca1 in /hg/gfx-test details: http://icedtea.classpath.org/hg/gfx-test?cmd=changeset;node=9f7b40fa8ca1 author: Pavel Tisnovsky date: Thu Sep 04 10:23:42 2014 +0200 Ten new tests added into CAGOperationsOnTwoOverlappingCircles. diffstat: ChangeLog | 5 + src/org/gfxtest/testsuites/CAGOperationsOnTwoOverlappingCircles.java | 251 ++++++++++ 2 files changed, 256 insertions(+), 0 deletions(-) diffs (280 lines): diff -r 52d612cf8db6 -r 9f7b40fa8ca1 ChangeLog --- a/ChangeLog Wed Sep 03 11:52:58 2014 +0200 +++ b/ChangeLog Thu Sep 04 10:23:42 2014 +0200 @@ -1,3 +1,8 @@ +2014-09-04 Pavel Tisnovsky + + * src/org/gfxtest/testsuites/CAGOperationsOnTwoOverlappingCircles.java: + Ten new tests added into CAGOperationsOnTwoOverlappingCircles. + 2014-09-03 Pavel Tisnovsky * src/org/gfxtest/testsuites/CAGOperationsOnTwoOverlappingRoundRectangles.java: diff -r 52d612cf8db6 -r 9f7b40fa8ca1 src/org/gfxtest/testsuites/CAGOperationsOnTwoOverlappingCircles.java --- a/src/org/gfxtest/testsuites/CAGOperationsOnTwoOverlappingCircles.java Wed Sep 03 11:52:58 2014 +0200 +++ b/src/org/gfxtest/testsuites/CAGOperationsOnTwoOverlappingCircles.java Thu Sep 04 10:23:42 2014 +0200 @@ -1768,6 +1768,256 @@ * graphics canvas * @return test result status - PASSED, FAILED or ERROR */ + public TestResult testIntersectTextureFillUsingHorizontalStripesTexture(TestImage image, Graphics2D graphics2d) + { + // set stroke color + CommonRenderingStyles.setStrokeColor(graphics2d); + // set fill color + CommonRenderingStyles.setTextureFillUsingHorizontalStripesTexture(image, graphics2d); + // create area using Intersect operator + Area area = CommonCAGOperations.createAreaFromTwoOverlappingCirclesUsingIntersectOperator(image); + // draw the area + graphics2d.fill(area); + // test result + return TestResult.PASSED; + } + + /** + * Checks the process of creating and rendering new geometric shape + * constructed from two overlapping circles using Xor operator. The shape is rendered + * using texture paint (fill). + * + * @param image + * image to which area is to be drawn + * @param graphics2d + * graphics canvas + * @return test result status - PASSED, FAILED or ERROR + */ + public TestResult testXorTextureFillUsingHorizontalStripesTexture(TestImage image, Graphics2D graphics2d) + { + // set stroke color + CommonRenderingStyles.setStrokeColor(graphics2d); + // set fill color + CommonRenderingStyles.setTextureFillUsingHorizontalStripesTexture(image, graphics2d); + // create area using Xor operator + Area area = CommonCAGOperations.createAreaFromTwoOverlappingCirclesUsingXorOperator(image); + // draw the area + graphics2d.fill(area); + // test result + return TestResult.PASSED; + } + + /** + * Checks the process of creating and rendering new geometric shape + * constructed from two overlapping circles using union operator. The shape is rendered + * using texture paint (fill). + * + * @param image + * image to which area is to be drawn + * @param graphics2d + * graphics canvas + * @return test result status - PASSED, FAILED or ERROR + */ + public TestResult testUnionTextureFillUsingVerticalStripesTexture(TestImage image, Graphics2D graphics2d) + { + // set stroke color + CommonRenderingStyles.setStrokeColor(graphics2d); + // set fill color + CommonRenderingStyles.setTextureFillUsingVerticalStripesTexture(image, graphics2d); + // create area using union operator + Area area = CommonCAGOperations.createAreaFromTwoOverlappingCirclesUsingUnionOperator(image); + // draw the area + graphics2d.fill(area); + // test result + return TestResult.PASSED; + } + + /** + * Checks the process of creating and rendering new geometric shape + * constructed from two overlapping circles using subtract operator. The shape is rendered + * using texture paint (fill). + * + * @param image + * image to which area is to be drawn + * @param graphics2d + * graphics canvas + * @return test result status - PASSED, FAILED or ERROR + */ + public TestResult testSubtractTextureFillUsingVerticalStripesTexture(TestImage image, Graphics2D graphics2d) + { + // set stroke color + CommonRenderingStyles.setStrokeColor(graphics2d); + // set fill color + CommonRenderingStyles.setTextureFillUsingVerticalStripesTexture(image, graphics2d); + // create area using subtract operator + Area area = CommonCAGOperations.createAreaFromTwoOverlappingCirclesUsingSubtractOperator(image); + // draw the area + graphics2d.fill(area); + // test result + return TestResult.PASSED; + } + + /** + * Checks the process of creating and rendering new geometric shape + * constructed from two overlapping circles using inverse subtract operator. The shape is rendered + * using texture paint (fill). + * + * @param image + * image to which area is to be drawn + * @param graphics2d + * graphics canvas + * @return test result status - PASSED, FAILED or ERROR + */ + public TestResult testInverseSubtractTextureFillUsingVerticalStripesTexture(TestImage image, Graphics2D graphics2d) + { + // set stroke color + CommonRenderingStyles.setStrokeColor(graphics2d); + // set fill color + CommonRenderingStyles.setTextureFillUsingVerticalStripesTexture(image, graphics2d); + // create area using inverse subtract operator + Area area = CommonCAGOperations.createAreaFromTwoOverlappingCirclesUsingInverseSubtractOperator(image); + // draw the area + graphics2d.fill(area); + // test result + return TestResult.PASSED; + } + + /** + * Checks the process of creating and rendering new geometric shape + * constructed from two overlapping circles using Intersect operator. The shape is rendered + * using texture paint (fill). + * + * @param image + * image to which area is to be drawn + * @param graphics2d + * graphics canvas + * @return test result status - PASSED, FAILED or ERROR + */ + public TestResult testIntersectTextureFillUsingVerticalStripesTexture(TestImage image, Graphics2D graphics2d) + { + // set stroke color + CommonRenderingStyles.setStrokeColor(graphics2d); + // set fill color + CommonRenderingStyles.setTextureFillUsingVerticalStripesTexture(image, graphics2d); + // create area using Intersect operator + Area area = CommonCAGOperations.createAreaFromTwoOverlappingCirclesUsingIntersectOperator(image); + // draw the area + graphics2d.fill(area); + // test result + return TestResult.PASSED; + } + + /** + * Checks the process of creating and rendering new geometric shape + * constructed from two overlapping circles using Xor operator. The shape is rendered + * using texture paint (fill). + * + * @param image + * image to which area is to be drawn + * @param graphics2d + * graphics canvas + * @return test result status - PASSED, FAILED or ERROR + */ + public TestResult testXorTextureFillUsingVerticalStripesTexture(TestImage image, Graphics2D graphics2d) + { + // set stroke color + CommonRenderingStyles.setStrokeColor(graphics2d); + // set fill color + CommonRenderingStyles.setTextureFillUsingVerticalStripesTexture(image, graphics2d); + // create area using Xor operator + Area area = CommonCAGOperations.createAreaFromTwoOverlappingCirclesUsingXorOperator(image); + // draw the area + graphics2d.fill(area); + // test result + return TestResult.PASSED; + } + + /** + * Checks the process of creating and rendering new geometric shape + * constructed from two overlapping circles using union operator. The shape is rendered + * using texture paint (fill). + * + * @param image + * image to which area is to be drawn + * @param graphics2d + * graphics canvas + * @return test result status - PASSED, FAILED or ERROR + */ + public TestResult testUnionTextureFillUsingHorizontalColorStripesTexture(TestImage image, Graphics2D graphics2d) + { + // set stroke color + CommonRenderingStyles.setStrokeColor(graphics2d); + // set fill color + CommonRenderingStyles.setTextureFillUsingHorizontalColorStripesTexture(image, graphics2d); + // create area using union operator + Area area = CommonCAGOperations.createAreaFromTwoOverlappingCirclesUsingUnionOperator(image); + // draw the area + graphics2d.fill(area); + // test result + return TestResult.PASSED; + } + + /** + * Checks the process of creating and rendering new geometric shape + * constructed from two overlapping circles using subtract operator. The shape is rendered + * using texture paint (fill). + * + * @param image + * image to which area is to be drawn + * @param graphics2d + * graphics canvas + * @return test result status - PASSED, FAILED or ERROR + */ + public TestResult testSubtractTextureFillUsingHorizontalColorStripesTexture(TestImage image, Graphics2D graphics2d) + { + // set stroke color + CommonRenderingStyles.setStrokeColor(graphics2d); + // set fill color + CommonRenderingStyles.setTextureFillUsingHorizontalColorStripesTexture(image, graphics2d); + // create area using subtract operator + Area area = CommonCAGOperations.createAreaFromTwoOverlappingCirclesUsingSubtractOperator(image); + // draw the area + graphics2d.fill(area); + // test result + return TestResult.PASSED; + } + + /** + * Checks the process of creating and rendering new geometric shape + * constructed from two overlapping circles using inverse subtract operator. The shape is rendered + * using texture paint (fill). + * + * @param image + * image to which area is to be drawn + * @param graphics2d + * graphics canvas + * @return test result status - PASSED, FAILED or ERROR + */ + public TestResult testInverseSubtractTextureFillUsingHorizontalColorStripesTexture(TestImage image, Graphics2D graphics2d) + { + // set stroke color + CommonRenderingStyles.setStrokeColor(graphics2d); + // set fill color + CommonRenderingStyles.setTextureFillUsingHorizontalColorStripesTexture(image, graphics2d); + // create area using inverse subtract operator + Area area = CommonCAGOperations.createAreaFromTwoOverlappingCirclesUsingInverseSubtractOperator(image); + // draw the area + graphics2d.fill(area); + // test result + return TestResult.PASSED; + } + + /** + * Checks the process of creating and rendering new geometric shape + * constructed from two overlapping circles using Intersect operator. The shape is rendered + * using texture paint (fill). + * + * @param image + * image to which area is to be drawn + * @param graphics2d + * graphics canvas + * @return test result status - PASSED, FAILED or ERROR + */ public TestResult testIntersectTextureFillUsingRGBTexture6(TestImage image, Graphics2D graphics2d) { // set stroke color @@ -1807,6 +2057,7 @@ return TestResult.PASSED; } + /** * Entry point to the test suite. * From gitne at gmx.de Thu Sep 4 11:48:50 2014 From: gitne at gmx.de (Jacob Wisor) Date: Thu, 04 Sep 2014 13:48:50 +0200 Subject: [rfc][icedtea-web][itweb-settings] Improve Icedtea-Web cache disk space In-Reply-To: <52819644.29735325.1409767204437.JavaMail.zimbra@redhat.com> References: <319590383.4051363.1404829211485.JavaMail.zimbra@redhat.com> <958305698.27235425.1409240834908.JavaMail.zimbra@redhat.com> <1885159478.27899833.1409329251634.JavaMail.zimbra@redhat.com> <540180DB.4050109@gmx.de> <54071A8A.9050202@gmx.de> <52819644.29735325.1409767204437.JavaMail.zimbra@redhat.com> Message-ID: <540851A2.2080807@gmx.de> On 09/03/2014 at 08:00 PM, Jie Kang wrote: > In regards to UI design philosophy and KISS (keep it simple stupid), I think we can argue over it all day long but rather than point to basic design guidelines or philosophies (since it all comes down to opinion), No, it does not. Scientific studies in social sciences on human-machine interaction have clearly revealed two decades ago already what the basic design principles of UIs should be. And, since science is all about facts and not opinions, I do not think we should open this discussion here. The problem I see here, is that often people recite or refer to scientific results without actually having read them or only picking out one issue that they remember and then filling in the missing parts by resorting to their guts. This is not how professional work is done. Results on scientific studies are not gut feelings but facts. Getting an interpretation on studies right is a different thing. However, time (like 20 years ago) has proven that social sciences on human-machine interaction have gotten the interpretation of their studies quite right, thus the same applies to the UI design guidelines which in turn are based on those interpretations. So, long story short, in this case the design should be disabling/enabling. > I think there are some simple rules that we can state and agree on such as, but not limited to: Yes, we may agree, but as I have already mentioned, it is not about opinion or consensus but about scientific facts. ;-) Of course, anyone is still entitled to their opinion on scientific facts, but then... usually those people have some kind of disorders or are just lunatics. :-D > UI must work : There are a set of actions that can be performed and the UI must support these actions. > UI must be simple : There are a set of actions that must be supported and the UI should support said actions with minimal effort on the part of the developer in creating this support, and on the user in accessing these actions. > > When it comes to minimal effort for the user, hiding/showing versus disabling to me is a neutral difference. It is not harder for the user to perform all actions when UI is shown/hidden based on when an action can be performed, but it is also not harder for the user to perform all actions when the UI is disabled/enabled based on when an action can be performed. However I think that hidden UI is more difficult for a user to learn about than disabled UI which is why I prefer enabling/disabling if necessary. Jacob From bugzilla-daemon at icedtea.classpath.org Thu Sep 4 14:01:49 2014 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Thu, 04 Sep 2014 14:01:49 +0000 Subject: [Bug 1284] [TRACKER] IcedTea 2.5.0 Release In-Reply-To: References: Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1284 Andrew John Hughes changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED --- Comment #1 from Andrew John Hughes --- Released: http://bitly.com/1l7n3Qq -- You are receiving this mail because: You are on the CC list for the bug. -------------- next part -------------- An HTML attachment was scrubbed... URL: From helpcrypto at gmail.com Thu Sep 4 14:07:32 2014 From: helpcrypto at gmail.com (helpcrypto helpcrypto) Date: Thu, 4 Sep 2014 16:07:32 +0200 Subject: [rfc][icedtea-web][itweb-settings] Improve Icedtea-Web cache disk space In-Reply-To: <540851A2.2080807@gmx.de> References: <319590383.4051363.1404829211485.JavaMail.zimbra@redhat.com> <958305698.27235425.1409240834908.JavaMail.zimbra@redhat.com> <1885159478.27899833.1409329251634.JavaMail.zimbra@redhat.com> <540180DB.4050109@gmx.de> <54071A8A.9050202@gmx.de> <52819644.29735325.1409767204437.JavaMail.zimbra@redhat.com> <540851A2.2080807@gmx.de> Message-ID: As I said, I'm waiting for the enabling/disablind patch. ;) -------------- next part -------------- An HTML attachment was scrubbed... URL: From bugzilla-daemon at icedtea.classpath.org Thu Sep 4 15:02:13 2014 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Thu, 04 Sep 2014 15:02:13 +0000 Subject: [Bug 1348] [IcedTea8] java -version output is broken In-Reply-To: References: Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1348 --- Comment #6 from Andrew John Hughes --- Perfect. openjdk version "1.8.0_20" OpenJDK Runtime Environment (IcedTea 3.0.0pre02+rc3b3c0cb05d3+) (Gentoo build 1.8.0_20-b23) OpenJDK 64-Bit Server VM (build 25.20-b22, mixed mode) -- You are receiving this mail because: You are on the CC list for the bug. -------------- next part -------------- An HTML attachment was scrubbed... URL: From andrew at icedtea.classpath.org Thu Sep 4 15:06:10 2014 From: andrew at icedtea.classpath.org (andrew at icedtea.classpath.org) Date: Thu, 04 Sep 2014 15:06:10 +0000 Subject: /hg/icedtea: 2 new changesets Message-ID: changeset c3b3c0cb05d3 in /hg/icedtea details: http://icedtea.classpath.org/hg/icedtea?cmd=changeset;node=c3b3c0cb05d3 author: Andrew John Hughes date: Thu Sep 04 15:22:54 2014 +0100 PR1348: Make versioning variables more obvious and name tarballs better. 2013-09-10 Andrew John Hughes * Makefile.am: (BUILD_VERSION): Renamed from OPENJDK_VERSION. (COMBINED_VERSION): Use BUILD_VERSION. (ICEDTEA_ENV): Likewise. (dist-openjdk): Should really use COMBINED_VERSION. (dist-openjdk-fsg): Likewise. (dist-openjdk-fsg-tz): Additional target which makes an xz tarball instead of a zip (for Jiri ;) changeset b27c53ea4272 in /hg/icedtea details: http://icedtea.classpath.org/hg/icedtea?cmd=changeset;node=b27c53ea4272 author: Andrew John Hughes date: Thu Sep 04 16:05:29 2014 +0100 PR1348: Move version settings to OpenJDK configure from OpenJDK make. 2014-09-04 Andrew John Hughes * Makefile.am: (ICEDTEA_CONFIGURE): Add update version, build number and milestone options. (ICEDTEA_ENV): Drop BUILD_NUMBER, JDK_UPDATE_VERSION, JRE_RELEASE_VERSION and MILESTONE, which appear to be no longer used. diffstat: ChangeLog | 21 +++++++++++++++++++++ Makefile.am | 21 ++++++++++++--------- 2 files changed, 33 insertions(+), 9 deletions(-) diffs (83 lines): diff -r 3680c74438e9 -r b27c53ea4272 ChangeLog --- a/ChangeLog Wed Sep 03 16:32:44 2014 +0100 +++ b/ChangeLog Thu Sep 04 16:05:29 2014 +0100 @@ -1,3 +1,24 @@ +2014-09-04 Andrew John Hughes + + * Makefile.am: + (ICEDTEA_CONFIGURE): Add update version, + build number and milestone options. + (ICEDTEA_ENV): Drop BUILD_NUMBER, + JDK_UPDATE_VERSION, JRE_RELEASE_VERSION + and MILESTONE, which appear to be no + longer used. + +2013-09-10 Andrew John Hughes + + * Makefile.am: + (BUILD_VERSION): Renamed from OPENJDK_VERSION. + (COMBINED_VERSION): Use BUILD_VERSION. + (ICEDTEA_ENV): Likewise. + (dist-openjdk): Should really use COMBINED_VERSION. + (dist-openjdk-fsg): Likewise. + (dist-openjdk-fsg-tz): Additional target which + makes an xz tarball instead of a zip (for Jiri ;) + 2014-09-03 Andrew John Hughes * NEWS: Add bug reference for system LCMS support. diff -r 3680c74438e9 -r b27c53ea4272 Makefile.am --- a/Makefile.am Wed Sep 03 16:32:44 2014 +0100 +++ b/Makefile.am Thu Sep 04 16:05:29 2014 +0100 @@ -1,8 +1,8 @@ # Dependencies -OPENJDK_VERSION = b23 JDK_UPDATE_VERSION = 20 -COMBINED_VERSION = $(JDK_UPDATE_VERSION)-$(OPENJDK_VERSION) +BUILD_VERSION = b23 +COMBINED_VERSION = $(JDK_UPDATE_VERSION)-$(BUILD_VERSION) CORBA_CHANGESET = 83ebbcc0dda5 JAXP_CHANGESET = 888f90c5e7da @@ -273,7 +273,10 @@ --enable-unlimited-crypto \ --with-cacerts-file=$(SYSTEM_JDK_DIR)/jre/lib/security/cacerts \ --with-zlib=system --with-stdc++lib=dynamic \ - --with-boot-jdk=$(BOOT_DIR) + --with-boot-jdk=$(BOOT_DIR) \ + --with-update-version=$(JDK_UPDATE_VERSION) \ + --with-build-number=$(BUILD_VERSION) \ + --with-milestone="fcs" if ENABLE_CACAO ICEDTEA_CONFIGURE += \ @@ -294,10 +297,6 @@ endif ICEDTEA_ENV = \ - BUILD_NUMBER="$(OPENJDK_VERSION)" \ - JDK_UPDATE_VERSION="$(JDK_UPDATE_VERSION)" \ - JRE_RELEASE_VERSION="1.8.0_$(COMBINED_VERSION)" \ - MILESTONE="fcs" \ LANG="C" \ PATH="$(BOOT_DIR)/bin:$(OS_PATH):$$PATH" \ CLASSPATH="" \ @@ -553,11 +552,15 @@ # Creates archive of openjdk. dist-openjdk: stamps/extract-cacao.stamp find openjdk/ -name \\.hg* | xargs rm -rf - $(ZIP) -r openjdk-$(OPENJDK_VERSION) openjdk/ + $(ZIP) -r openjdk-$(COMBINED_VERSION) openjdk/ # Creates archive of openjdk that is compliant with Free Software guidelines. dist-openjdk-fsg: stamps/patch-fsg.stamp - $(ZIP) -r openjdk-fsg-$(OPENJDK_VERSION) openjdk/ + $(ZIP) -r openjdk-fsg-$(COMBINED_VERSION) openjdk/ + +dist-openjdk-fsg-xz: stamps/patch-fsg.stamp + tardir=openjdk/ && $(am__tar) | XZ_OPT=$${XZ_OPT--e} xz -c \ + >openjdk-fsg-$(COMBINED_VERSION).tar.xz # OpenJDK Source Preparation Targets # ================================== From bugzilla-daemon at icedtea.classpath.org Thu Sep 4 15:06:25 2014 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Thu, 04 Sep 2014 15:06:25 +0000 Subject: [Bug 1348] [IcedTea8] java -version output is broken In-Reply-To: References: Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1348 --- Comment #7 from hg commits --- details: http://icedtea.classpath.org//hg/icedtea?cmd=changeset;node=b27c53ea4272 author: Andrew John Hughes date: Thu Sep 04 16:05:29 2014 +0100 PR1348: Move version settings to OpenJDK configure from OpenJDK make. 2014-09-04 Andrew John Hughes * Makefile.am: (ICEDTEA_CONFIGURE): Add update version, build number and milestone options. (ICEDTEA_ENV): Drop BUILD_NUMBER, JDK_UPDATE_VERSION, JRE_RELEASE_VERSION and MILESTONE, which appear to be no longer used. -- You are receiving this mail because: You are on the CC list for the bug. -------------- next part -------------- An HTML attachment was scrubbed... URL: From bugzilla-daemon at icedtea.classpath.org Thu Sep 4 15:07:08 2014 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Thu, 04 Sep 2014 15:07:08 +0000 Subject: [Bug 1348] [IcedTea8] java -version output is broken In-Reply-To: References: Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1348 Andrew John Hughes changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug. -------------- next part -------------- An HTML attachment was scrubbed... URL: From bugzilla-daemon at icedtea.classpath.org Thu Sep 4 15:07:08 2014 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Thu, 04 Sep 2014 15:07:08 +0000 Subject: [Bug 1282] [TRACKER] IcedTea 3.0.0 Release In-Reply-To: References: Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1282 Bug 1282 depends on bug 1348, which changed state. Bug 1348 Summary: [IcedTea8] java -version output is broken http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1348 What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug. -------------- next part -------------- An HTML attachment was scrubbed... URL: From ldracz at redhat.com Thu Sep 4 15:15:33 2014 From: ldracz at redhat.com (Lukasz Dracz) Date: Thu, 4 Sep 2014 11:15:33 -0400 (EDT) Subject: [rfc][icedtea-web] Option Parser In-Reply-To: <53FDB53A.90301@redhat.com> References: <1652694837.24549917.1408718657180.JavaMail.zimbra@redhat.com> <53FB2893.4050303@redhat.com> <53FB2938.6040201@redhat.com> <471810972.25519307.1408998763566.JavaMail.zimbra@redhat.com> <53FDB53A.90301@redhat.com> Message-ID: <374649378.440186.1409843733352.JavaMail.zimbra@redhat.com> Hello, I have taken in as much of your suggestions as I could. I have attached the updated Option Parser. I rewrote how the parser works and changed it from parsing inside a method to parsing in the constructor, as you should only really need to parse once. It stores the options in a Map with Options as Keys and a List of Strings for the values. The getValue(s) methods return based on the option from that map. >> + public String[] getOptionValues(Option option) { >> + List result = new ArrayList(); >> >> + return result.toArray(new String[result.size()]); >> + } >> >Why not just return a `List` instead? In Boot it gets used by being put in a Map which is then passed into the Launcher class. I didn't want to change that up in this patch too. If you want I can add another method that could be used in the future called getListOfValues. >> + public String[] getArgs() { >> + return Arrays.copyOf(args, args.length); >> + } > >Eh? Why expose internal state? Think about what needs to use this, and >if an alternate implementation that does not expose the internals would >be possible and/or better. I looked into what was using this and it was ParserSettings so I redid the method to accept two booleans instead of args which it would then look for the "-strict" and "-xml" tags inside of. This also meant changing the ParserSettingsTest which in my opinion don't make sense in their current state. I plan on looking into Parser and ParserSetting in the future and see how they are used and if it makes sense for them to be changed to incorporate the OptionParser. The OptionsDefinitions Class is a shared class Jiri made that I have helped a bit on, I will update my optionsDefinitions Class with any further changes if required by Jiri. Also will update with the version Jiri sends out to the list. For the parser I tried my best to make it as flexible as possible to cover as many possible various cases of how users might input their commands. For example, the user can use the same tag multiple times and it won't matter command -headless -headless -headless File.jnlp -headless -headless -headless is the same as command -headless File.jnlp also for ones that take multiple inputs you can have the tag multiple times command -arg blue green red -headless File.jnlp -arg yellow purple will have blue, green, red, yellow, purple all under arg Notice however that -headless need to be before File.jnlp since the parser wouldn't know whether File.jnlp was just another arg or the main argument but after -headless which it knows takes no arguments it can be sure that File.jnlp is the main arg. Currently writing a few more unit tests and testing out other cases but wanted to get feedback before I spent too much time on more unit tests. Thank you, Lukasz Dracz -------------- next part -------------- A non-text attachment was scrubbed... Name: optionParser-10.patch Type: text/x-patch Size: 38729 bytes Desc: not available URL: From jvanek at redhat.com Thu Sep 4 15:18:19 2014 From: jvanek at redhat.com (Jiri Vanek) Date: Thu, 04 Sep 2014 17:18:19 +0200 Subject: Fwd: docs generator - prereview In-Reply-To: <5405E4C0.9050909@redhat.com> References: <5405E4C0.9050909@redhat.com> Message-ID: <540882BB.5070100@redhat.com> Hi! Proudly :) presenting... documentation generator for ITW. Lukas Dracz already seen the preversion, because we shares one peace of code - OptionsDefinitions.java - also he was trying to impelmetn first versions of this. Now his patch is built on top of this. Well, it does a lot of things - generates man pages and html doc* and palintext docs** - unified files declarations - unified options declarations * html docs - are usleless in offlien mode (maybe we can publish them on classapth org after each release - but are used (generated in runtime) in help dialogue - which is really really nice. ** plain text docs - even les susefull then html docs, but are used in runtime commandlinehel/and about - which removed all the duplicated string providers. Various files and properties are sorted in javaws pages, have theyrs defaults and for sure none is missing. So finally no duplicated texts in various "about" and "help"! The patch is missing localization - I'm going to do so in some next changeset, and I hope to get rid of RepalcingFormater and its @@ substitution. As for review - anybody, please be specially careful about the files declaration. I hope I did it error-less and complete :( The design is 1docprovider - have 2formater is providing 3output eg: 1 - itw, itw-settings, javaws... 2 - html, plain, man 3 - man pages (generated during build, loclaized), runtime help - both console and "nice" html one. The runtime help have evaluated varibales and properties For runtime help I had to refactor about dialog a bit - only make some parts singletons and added an tab.... make check, install, dist and install form dist and unnstall works. J. -------------- next part -------------- A non-text attachment was scrubbed... Name: docsGenerator_2.diff Type: text/x-patch Size: 189441 bytes Desc: not available URL: From jkang at redhat.com Thu Sep 4 15:31:23 2014 From: jkang at redhat.com (Jie Kang) Date: Thu, 4 Sep 2014 11:31:23 -0400 (EDT) Subject: [rfc][icedtea-web] TeeOutputStream Dependency Fix In-Reply-To: <355049774.398737.1409842794092.JavaMail.zimbra@redhat.com> Message-ID: <674136995.453135.1409844683435.JavaMail.zimbra@redhat.com> Hello, This patch adds a logger dependency injection to TeeOutputStream so that the tests no longer require a protected function in order to run. Thoughts? Regards, -- Jie Kang -------------- next part -------------- A non-text attachment was scrubbed... Name: itw-teeos-dep-1.patch Type: text/x-patch Size: 7324 bytes Desc: not available URL: From jkang at redhat.com Thu Sep 4 18:11:23 2014 From: jkang at redhat.com (Jie Kang) Date: Thu, 4 Sep 2014 14:11:23 -0400 (EDT) Subject: [rfc][icedtea-web] Option Parser In-Reply-To: <374649378.440186.1409843733352.JavaMail.zimbra@redhat.com> References: <1652694837.24549917.1408718657180.JavaMail.zimbra@redhat.com> <53FB2893.4050303@redhat.com> <53FB2938.6040201@redhat.com> <471810972.25519307.1408998763566.JavaMail.zimbra@redhat.com> <53FDB53A.90301@redhat.com> <374649378.440186.1409843733352.JavaMail.zimbra@redhat.com> Message-ID: <1896202438.535479.1409854283129.JavaMail.zimbra@redhat.com> ----- Original Message ----- > Hello, > > I have taken in as much of your suggestions as I could. I have attached the > updated Option Parser. I rewrote how the parser works and changed it from > parsing inside a method to parsing in the constructor, as you should only > really need to parse once. It stores the options in a Map with Options as > Keys and a List of Strings for the values. The getValue(s) methods return > based on the option from that map. > > > >> + public String[] getOptionValues(Option option) { > >> + List result = new ArrayList(); > >> > >> + return result.toArray(new String[result.size()]); > >> + } > >> > >Why not just return a `List` instead? > > In Boot it gets used by being put in a Map which is then > passed into the Launcher class. > I didn't want to change that up in this patch too. If you want I can add > another method that could be used in the future called getListOfValues. > > >> + public String[] getArgs() { > >> + return Arrays.copyOf(args, args.length); > >> + } > > > >Eh? Why expose internal state? Think about what needs to use this, and > >if an alternate implementation that does not expose the internals would > >be possible and/or better. > > I looked into what was using this and it was ParserSettings so I redid the > method to accept two booleans instead of > args which it would then look for the "-strict" and "-xml" tags inside of. > This also meant changing the ParserSettingsTest which in my opinion don't > make sense in their current state. I plan on looking into Parser and > ParserSetting in the future and see how they are used and if it makes sense > for them to be changed to incorporate the OptionParser. > > The OptionsDefinitions Class is a shared class Jiri made that I have helped a > bit on, I will update my optionsDefinitions Class with any further changes > if required by Jiri. Also will update with the version Jiri sends out to the > list. > > For the parser I tried my best to make it as flexible as possible to cover as > many possible various cases of how users might input their commands. > > For example, the user can use the same tag multiple times and it won't matter > > command -headless -headless -headless File.jnlp -headless -headless -headless > > is the same as > > command -headless File.jnlp > > also for ones that take multiple inputs you can have the tag multiple times > > command -arg blue green red -headless File.jnlp -arg yellow purple > > will have blue, green, red, yellow, purple all under arg > Notice however that -headless need to be before File.jnlp since the parser > wouldn't know whether File.jnlp was just another arg or the main argument > but after -headless which it knows takes no arguments it can be sure that > File.jnlp is the main arg. > > Currently writing a few more unit tests and testing out other cases but > wanted to get feedback before I spent too much time on more unit tests. > > Thank you, > Lukasz Dracz Hello, Review in-line with code: +public class OptionParser { + + private String[] args; + private Map> parsedOptions; Please make both args and parsedOptions final as well + private final List possibleOptions; + private final String MAINARG = "mainArg"; + private final OptionsDefinitions.OPTIONS mainArg = null; Not a big fan of using the null key. Please add a comment to clarify that it is meant to be null and what it represents. + private final boolean lookForMainArg; + + public OptionParser(String[] args, List options, boolean lookForMainArg) { + this.args = Arrays.copyOf(args, args.length); + this.possibleOptions = options; + this.lookForMainArg = lookForMainArg; + List result = new ArrayList(); + String lastOption = ""; + parsedOptions = new HashMap<>(); Moving the parsing of arguments into the constructor is fine but please extract it into it's own private function or possibly their own functions and have them called in the constructor. + int i = 0; + while (i < args.length) { + if (isOption(args[i])) { + result.clear(); + if (args[i].contains("=")) { + result.add(args[i].split("=")[1]); + lastOption = args[i].split("=")[0]; + parsedOptions.put(getOption(lastOption), new ArrayList(result)); + } else { + lastOption = args[i]; + if (parsedOptions.keySet().contains(getOption(lastOption))) { + if (getOption(lastOption).hasManyArguments()) { + result = new ArrayList<>(parsedOptions.get(getOption(lastOption))); + } + } + if (getOption(lastOption).hasNoArguments()) { + parsedOptions.put(getOption(lastOption), null); + lastOption = MAINARG; + } + } + } else { + result.add(args[i]); + parsedOptions.put(getOption(lastOption), new ArrayList(result)); + if (getOption(lastOption) != null) { + if (getOption(lastOption).hasOneArgument()) { + lastOption = MAINARG; + result.clear(); + } + } + } + i++; + } + + if(this.lookForMainArg) { + if (!(parsedOptions.keySet().contains(mainArg))) { + i--; This is a style nit but having this 'i--' in here requires more code-reading than say 'i = args.length - 1'. With the latter it's more quickly understood that you are iterating args in reverse. Up to you; + while (i >= 0) { + if (!args[i].startsWith("-")) { + for (OptionsDefinitions.OPTIONS op : parsedOptions.keySet()) { + if (!(parsedOptions.get(op) == null)) { + if (parsedOptions.get(op).contains(args[i])) { + result.clear(); + result.add(args[i]); + parsedOptions.get(op).remove(parsedOptions.get(op).indexOf(args[i])); + break; + } + } + } + parsedOptions.put(mainArg, result); + break; + } + i--; + } + } + } + + } + public String getLocalizedEscription() { typo?; + return R(decriptionKey); + } Regards, -- Jie Kang From omajid at redhat.com Thu Sep 4 18:18:31 2014 From: omajid at redhat.com (Omair Majid) Date: Thu, 4 Sep 2014 14:18:31 -0400 Subject: [rfc][icedtea-web] Option Parser In-Reply-To: <374649378.440186.1409843733352.JavaMail.zimbra@redhat.com> References: <1652694837.24549917.1408718657180.JavaMail.zimbra@redhat.com> <53FB2893.4050303@redhat.com> <53FB2938.6040201@redhat.com> <471810972.25519307.1408998763566.JavaMail.zimbra@redhat.com> <53FDB53A.90301@redhat.com> <374649378.440186.1409843733352.JavaMail.zimbra@redhat.com> Message-ID: <20140904181831.GB3074@redhat.com> * Lukasz Dracz [2014-09-04 11:15]: > I looked into what was using this and it was ParserSettings so I redid > the method to accept two booleans instead of args which it would then > look for the "-strict" and "-xml" tags inside of. This also meant > changing the ParserSettingsTest which in my opinion don't make sense > in their current state. I plan on looking into Parser and > ParserSetting in the future and see how they are used and if it makes > sense for them to be changed to incorporate the OptionParser. Looking quickly through the code, I am a little surprised. It seems like the simple/obvious thing to do is to create a new ParserSettings object based on settings to use for the parser (like, `ParserSettings(boolean strict)`), not from program arguments. I will be perfectly happy if you modified the ParserSettings class to move in this direction. It's fine to do it in a separate patch. Thanks, Omair -- PGP Key: 66484681 (http://pgp.mit.edu/) Fingerprint = F072 555B 0A17 3957 4E95 0056 F286 F14F 6648 4681 From ldracz at redhat.com Thu Sep 4 18:39:48 2014 From: ldracz at redhat.com (Lukasz Dracz) Date: Thu, 4 Sep 2014 14:39:48 -0400 (EDT) Subject: [rfc][icedtea-web][itweb-settings] Improve Icedtea-Web cache disk space In-Reply-To: References: <319590383.4051363.1404829211485.JavaMail.zimbra@redhat.com> <540180DB.4050109@gmx.de> <54071A8A.9050202@gmx.de> <52819644.29735325.1409767204437.JavaMail.zimbra@redhat.com> <540851A2.2080807@gmx.de> Message-ID: <809710797.550417.1409855988786.JavaMail.zimbra@redhat.com> Hello, Okay so this patch, uses disabling/enabling instead of hiding/showing. Also put the "Java stores application ..." description to always be at the top where as the rest of the components will be centered. Also changed from powers of two to increments of 10 but not jumps of 1,10,100,1000,10000 etc. but instead to 0,1,2,3,...,7,8,9,10,20,30...80,90,100,200,300...800,900,1000,2000,3000 etc. I think this way is best as it does not jump to the larger values too quickly. As for my opinion, I think disabling is better than hiding, as it still shows the user the possibilities in the panel even though they are not active. I also liked the powers of two spinner much more personally but from a user's point of view I agree that increments of 10 are more intuitive and easier to understand. Thank you, Lukasz Dracz -------------- next part -------------- A non-text attachment was scrubbed... Name: cacheSizeSpinner-18.patch Type: text/x-patch Size: 22635 bytes Desc: not available URL: From jkang at redhat.com Thu Sep 4 18:55:33 2014 From: jkang at redhat.com (Jie Kang) Date: Thu, 4 Sep 2014 14:55:33 -0400 (EDT) Subject: docs generator - prereview In-Reply-To: <540882BB.5070100@redhat.com> References: <5405E4C0.9050909@redhat.com> <540882BB.5070100@redhat.com> Message-ID: <2127323249.558740.1409856933886.JavaMail.zimbra@redhat.com> ----- Original Message ----- > > Hi! > > > Proudly :) presenting... documentation generator for ITW. > > Lukas Dracz already seen the preversion, because we shares one peace of code > - > OptionsDefinitions.java - also he was trying to impelmetn first versions > of this. > > Now his patch is built on top of this. > > Well, it does a lot of things > - generates man pages and html doc* and palintext docs** > - unified files declarations > - unified options declarations > > * html docs > - are usleless in offlien mode (maybe we can publish them on classapth > org after each release - > but are used (generated in runtime) in help dialogue - which is really really > nice. > > ** plain text docs - even les susefull then html docs, but are used in > runtime commandlinehel/and > about - which removed all the duplicated string providers. > > Various files and properties are sorted in javaws pages, have theyrs defaults > and for sure none is > missing. > > So finally no duplicated texts in various "about" and "help"! > > The patch is missing localization - I'm going to do so in some next > changeset, and I hope to get > rid of RepalcingFormater and its @@ substitution. > > > > As for review - anybody, please be specially careful about the files > declaration. I hope I did it > error-less and complete :( > > > The design is > > 1docprovider - have 2formater is providing 3output > > eg: > 1 - itw, itw-settings, javaws... > 2 - html, plain, man > 3 - man pages (generated during build, loclaized), runtime help - both > console and "nice" html one. > The runtime help have evaluated varibales and properties > > > For runtime help I had to refactor about dialog a bit - only make some parts > singletons and added > an tab.... > > > make check, install, dist and install form dist and unnstall works. > > > > J. Hello, This patch is really large, is there any way you can split this into smaller iterations? For example, maybe have one patch that moves all paths and files into the PathsAndFiles.java, then one patch for the net.sourceforge.jnlp.docprovider addition, and then another patch for the makefile changes to use the docprovider. As well as a patch for refactoring the 'about dialog'. Or something along those lines; One thing as well when you look at doing the localization part. Right now Translator just delegates to JNLPRuntime. e.g: public static String R(String message, Object... params) { return JNLPRuntime.getMessage(message, params); } I think we should move the translating parts from JNLPRuntime into Translator. Thoughts? Regards, > > > > > > -- Jie Kang From ldracz at redhat.com Thu Sep 4 20:22:26 2014 From: ldracz at redhat.com (Lukasz Dracz) Date: Thu, 4 Sep 2014 16:22:26 -0400 (EDT) Subject: [rfc][icedtea-web] Option Parser In-Reply-To: <20140904181831.GB3074@redhat.com> References: <1652694837.24549917.1408718657180.JavaMail.zimbra@redhat.com> <53FB2893.4050303@redhat.com> <53FB2938.6040201@redhat.com> <471810972.25519307.1408998763566.JavaMail.zimbra@redhat.com> <53FDB53A.90301@redhat.com> <374649378.440186.1409843733352.JavaMail.zimbra@redhat.com> <20140904181831.GB3074@redhat.com> Message-ID: <206375438.642458.1409862146911.JavaMail.zimbra@redhat.com> Hello, > Looking quickly through the code, I am a little surprised. It seems like > the simple/obvious thing to do is to create a new ParserSettings object > based on settings to use for the parser (like, `ParserSettings(boolean > strict)`), not from program arguments. I will be perfectly happy if you > modified the ParserSettings class to move in this direction. > > It's fine to do it in a separate patch. > > Thanks, > Omair Alright, hmm ParserSettings already has a constructor with (boolean strict, boolean extensionAllowed, boolean malformedXmlAllowed) as parameters, the one difference between method and the constructor is that it assigns a new ParserSettings to the private static globalParserSettings, I'll look into it and see how this is all setup in a separate patch >Please make both args and parsedOptions final as well Okay >Not a big fan of using the null key. Please add a comment to clarify that it is meant to be null and what it >represents. Sure >Moving the parsing of arguments into the constructor is fine but please extract it into it's own private function >or possibly their own functions and have them called in the constructor. Sounds good >This is a style nit but having this 'i--' in here requires more code-reading than say 'i = args.length - 1'. With >the latter it's more quickly understood that you are iterating args in reverse. Up to you; Yeah I agree that makes it more readable. >+ public String getLocalizedEscription() { >typo?; Yes, I have updated OptionsDescriptions to match the one released in Jiri's patch, some small differences from the one I posted before, which includes Jiri fixing this typo. Thank you, Lukasz Dracz -------------- next part -------------- A non-text attachment was scrubbed... Name: optionParser-11.patch Type: text/x-patch Size: 37258 bytes Desc: not available URL: From aazores at redhat.com Thu Sep 4 20:46:15 2014 From: aazores at redhat.com (Andrew Azores) Date: Thu, 04 Sep 2014 16:46:15 -0400 Subject: [rfc][icedtea-web] missing jnlpfile and securtydelegate for TemporaryPermissionsButton calls In-Reply-To: <54070D4D.70605@redhat.com> References: <53FDA41B.4060801@redhat.com> <53FE5CD3.4060602@redhat.com> <54070D4D.70605@redhat.com> Message-ID: <5408CF97.3030305@redhat.com> On 03/09/14 08:45 AM, Jiri Vanek wrote: > On 08/28/2014 12:33 AM, Andrew Azores wrote: >> Hi, >> >> Still on PTO here and preparing to move back into my parents' place >> while I go back to finish >> school, so I haven't really invested any real time into this bug. But... >> >> On 08/27/2014 05:25 AM, Jiri Vanek wrote: >>> Hi! >>> >>> During testing of https probing, helpcrypto found and interesting issue >>> in head. >>> >>> Under some circumstances calls to TemporaryPermissionsButton have >>> jnlpfile and securitydelegate null. >> >> The SecurityDelegate can be instantiated much earlier in >> JNLPClassLoader if need be. It can even be >> the first thing done after calling the super constructor AFAIK. Since >> the JNLPClassLoader is also >> what eventually causes the security dialog to appear with the >> Temporary Permissions button on it, >> this will probably resolve the null securityDelegate reference part. >> >>> >>> Two things troubles me: >>> - both those values are needed only when "tmeporarypermissions" are >>> clicked, so they should not affect startup of ITW >>> - how come that they are null? I blame >>> http://icedtea.classpath.org/hg/icedtea-web/annotate/d87ee4e6e81a/netx/net/sourceforge/jnlp/security/dialogs/TemporaryPermissionsButton.java#78 >>> >>> >>> >>> (looking into Looking to this, >>> http://icedtea.classpath.org/hg/icedtea-web/file/b4363c984e1b/netx/net/sourceforge/jnlp/security/dialogs/TemporaryPermissionsButton.java#l79 >>> >>> >>> ) >> >> For the null jnlpFile - I can't think off the top of my head what is >> causing that. It could just be >> again that the dialog is being shown before a field has been assigned >> a value, as it is with the >> securityDelegate. If it's simply an ordering issue like this then >> that isn't *too* concerning. If we >> truly just do not have a reference to any JNLPFile or PluginBridge >> for this applet then there's >> something seriously wrong. >> >>> >>> >>> Atatched is the nasty workarorund and here is snippet of log >>> >>> Securitymanager=net.sourceforge.jnlp.runtime.JNLPSecurityManager at 19f17b1 >>> >>> Registering priority for string reference 2 >>> Registering priority for reference 2 >>> Returning value:0 >>> Setting value:0 >>> Setting value:null >>> dummy string null, null, javax.swing.JButton[,0,0,0x0,inva...snip... >>> plugin_in_pipe_callback return >>> plugin_send_message_to_appletviewer return >>> PIPE: plugin wrote(?): plugin PluginProxyInfo reference 1 DIRECT >>> plugin_send_message_to_appletviewer >>> Proxy info: plugin PluginProxyInfo reference 1 DIRECT >>> >>> >>> >>> Without the workarround itw dies: >>> >>> ITNP_SetWindow return >>> ITNP_SetWindow: window already exists. >>> ITNP_SetWindow >>> at java.lang.Thread.run(Thread.java:745) >>> at >>> net.sourceforge.jnlp.security.SecurityDialogMessageHandler.run(SecurityDialogMessageHandler.java:81) >>> >>> >>> at >>> net.sourceforge.jnlp.security.SecurityDialogMessageHandler.handleMessage(SecurityDialogMessageHandler.java:102) >>> >>> >>> >>> at net.sourceforge.jnlp.security.SecurityDialog. >>> (SecurityDialog.java:129) >>> at >>> net.sourceforge.jnlp.security.SecurityDialog.initDialog(SecurityDialog.java:255) >>> >>> >>> at >>> net.sourceforge.jnlp.security.SecurityDialog.installPanel(SecurityDialog.java:307) >>> >>> >>> at net.sourceforge.jnlp.security.dialogs.CertWarningPane. >>> (CertWarningPane.java:116) >>> at >>> net.sourceforge.jnlp.security.dialogs.CertWarningPane.addComponents(CertWarningPane.java:124) >>> >>> >>> at >>> net.sourceforge.jnlp.security.dialogs.CertWarningPane.addButtons(CertWarningPane.java:242) >>> >>> >>> at >>> net.sourceforge.jnlp.security.dialogs.TemporaryPermissionsButton. >>> (TemporaryPermissionsButton.java:79) >>> at java.util.Objects.requireNonNull(Objects.java:201) >>> Exception in thread "NetxSecurityThread" java.lang.NullPointerException >>> plugin_in_pipe_callback return >>> plugin_send_message_to_appletviewer return >>> PIPE: plugin wrote(?): plugin PluginProxyInfo reference 1 DIRECT >>> plugin_send_message_to_appletviewer >>> Proxy info: plugin PluginProxyInfo reference 1 DIRECT >>> >>> >>> >>> I think the AssertNotNUll are really really invasive here. But at least >>> they cought probably more serious issue - to early call to the dialogue >>> with tmppermissions button.... >>> >>> >>> J. >> >> Yup. The PolicyEditor can't be sensibly launched if the jnlpFile is >> null (your nasty workaround >> really is nasty - assigning the new permissions to all applets rather >> than only ones on the current >> applet's codebase!), and the securityDelegate is needed if this >> button is to function at all. So >> there's no sensible thing to do if either of those fields come up >> null. Perhaps rather than outright >> failing to launch ITW we could have the button indicate a failure >> somehow and have the dialog simply >> not install the button, however. Just another option for Lukasz or >> whomever to look into. If this >> still hasn't been fixed by the time I come off PTO then I'll gladly >> take ownership of the bug. >> > > Andrew have made some investigations, and this is moreover conclusion > - its a bug - the tmp permissions dialogue is shared among javaws > and applets, and in applets lifecycle can happen this NPE > - however, the fix will take some time Eh, not necessarily :) see below. > > Even after it may be some cases, when this NPE will rise. We agreed > that disabling the button n this case is probably best solution. > > > The attache dpatch do so, > > Two nits : > - is really the SecurityDelegate suddenly useless? Yes - this NPE bug only occurs when the button is being installed by a CertWarningPane invoked by the VariableX509TrustManager. In other words, it only occurs when the dialog is asking the user whether they trust the certificate presented for the current HTTPS connection, not when the dialog is asking the user if they trust a certificate used to sign an applet. IMO it doesn't make sense to decide to apply sandboxing rules to an applet at this point, based on trusting the HTTPS certificate, although maybe that is something to explore. If we do want this to be an option then the VariableX509TrustManager will have to have some work done so it can carry the extra state of the JNLPFile and SecurityDelegate corresponding to the current applet/application as well. This would take some extra time, but if we don't want to add allowing sandboxing based on the HTTPS certificate trust, then your patch or mine are basically sufficient. > - Why all apps reproducing this issue suddenly started to work? ( I > mean without this patch) Do they? I haven't tried to verify this but that's surprising to me. The only validation currently done by the CertWarningPane is checking if the JNLPFile is null (which is a pretty fragile check - it's been changed to check the type of the CertVerifier instead), and if it is, then the button is not installed into the button panel. This decision is made well after the TemporaryPermissionsButton has been instantiated, which means that the Objects.requireNonNull checks have been performed. And the VariableX509TrustManager is still hard-coded to specifically provide "null" for the "file" and "securityDelegate" parameters... > > > Still I think it is good thing to get rid of assers and disable button. I think it's better to just not show the button (buttonS really, it's the Sandbox as well as Temporary Permissions) in this context, but it's an easy change to make either way. > > > J. > > Attached is my take on the patch. I also corrected the buttons on the dialog so that their labels and tooltips make more sense in the context of trusting an HTTPS certificate rather than an applet certificate. This looks a little messy with all the if statements added, but maybe it's not worth abstracting this class and making two subclasses just to change the labels on the buttons (and ignore two buttons from the button panel). Up to you. I can refactor it into two classes no problem but I know you expressed distaste for this approach on IRC ;) Thanks, -- Andrew A -------------- next part -------------- A non-text attachment was scrubbed... Name: temporarypermissionsbutton-npe-fix.patch Type: text/x-patch Size: 6120 bytes Desc: not available URL: From ptisnovs at icedtea.classpath.org Fri Sep 5 11:26:31 2014 From: ptisnovs at icedtea.classpath.org (ptisnovs at icedtea.classpath.org) Date: Fri, 05 Sep 2014 11:26:31 +0000 Subject: /hg/gfx-test: Ten new tests added into CAGOperationsOnChordAndRe... Message-ID: changeset 6cb398621693 in /hg/gfx-test details: http://icedtea.classpath.org/hg/gfx-test?cmd=changeset;node=6cb398621693 author: Pavel Tisnovsky date: Fri Sep 05 13:27:38 2014 +0200 Ten new tests added into CAGOperationsOnChordAndRectangle. diffstat: ChangeLog | 5 + src/org/gfxtest/testsuites/CAGOperationsOnChordAndRectangle.java | 236 ++++++++++ 2 files changed, 241 insertions(+), 0 deletions(-) diffs (258 lines): diff -r 9f7b40fa8ca1 -r 6cb398621693 ChangeLog --- a/ChangeLog Thu Sep 04 10:23:42 2014 +0200 +++ b/ChangeLog Fri Sep 05 13:27:38 2014 +0200 @@ -1,3 +1,8 @@ +2014-09-05 Pavel Tisnovsky + + * src/org/gfxtest/testsuites/CAGOperationsOnChordAndRectangle.java: + Ten new tests added into CAGOperationsOnChordAndRectangle. + 2014-09-04 Pavel Tisnovsky * src/org/gfxtest/testsuites/CAGOperationsOnTwoOverlappingCircles.java: diff -r 9f7b40fa8ca1 -r 6cb398621693 src/org/gfxtest/testsuites/CAGOperationsOnChordAndRectangle.java --- a/src/org/gfxtest/testsuites/CAGOperationsOnChordAndRectangle.java Thu Sep 04 10:23:42 2014 +0200 +++ b/src/org/gfxtest/testsuites/CAGOperationsOnChordAndRectangle.java Fri Sep 05 13:27:38 2014 +0200 @@ -2250,6 +2250,242 @@ } /** + * Checks the process of creating and rendering new geometric shape + * constructed from chord and rectangle using inverse subtract operator. + * The shape is rendered using wide stroke. + * + * @param image + * image to which area is to be drawn + * @param graphics2d + * graphics canvas + * @return test result status - PASSED, FAILED or ERROR + */ + public TestResult testOverlappingChordAndRectangleInverseSubtractExtraWideStrokePaint(TestImage image, Graphics2D graphics2d) + { + // set stroke color + CommonRenderingStyles.setStrokeColor(graphics2d); + // set extra wide stroke width + CommonRenderingStyles.setStrokeExtraThickWidth(graphics2d); + // create area using inverse subtract operator + Area area = CommonCAGOperations.createAreaFromOverlappingChordAndRectangleUsingInverseSubtractOperator(image); + // draw the area + graphics2d.draw(area); + // test result + return TestResult.PASSED; + } + + /** + * Checks the process of creating and rendering new geometric shape + * constructed from chord and rectangle using intersect operator. The shape + * is rendered using wide stroke. + * + * @param image + * image to which area is to be drawn + * @param graphics2d + * graphics canvas + * @return test result status - PASSED, FAILED or ERROR + */ + public TestResult testOverlappingChordAndRectangleIntersectExtraWideStrokePaint(TestImage image, Graphics2D graphics2d) + { + // set stroke color + CommonRenderingStyles.setStrokeColor(graphics2d); + // set extra wide stroke width + CommonRenderingStyles.setStrokeExtraThickWidth(graphics2d); + // create area using intersect operator + Area area = CommonCAGOperations.createAreaFromOverlappingChordAndRectangleUsingIntersectOperator(image); + // draw the area + graphics2d.draw(area); + // test result + return TestResult.PASSED; + } + + /** + * Checks the process of creating and rendering new geometric shape + * constructed from chord and rectangle using XOR operator. The shape is + * rendered using extra wide stroke. + * + * @param image + * image to which area is to be drawn + * @param graphics2d + * graphics canvas + * @return test result status - PASSED, FAILED or ERROR + */ + public TestResult testOverlappingChordAndRectangleXorExtraWideStrokePaint(TestImage image, Graphics2D graphics2d) + { + // set stroke color + CommonRenderingStyles.setStrokeColor(graphics2d); + // set stroke extra width + CommonRenderingStyles.setStrokeExtraThickWidth(graphics2d); + // create area using XOR operator + Area area = CommonCAGOperations.createAreaFromOverlappingChordAndRectangleUsingXorOperator(image); + // draw the area + graphics2d.draw(area); + // test result + return TestResult.PASSED; + } + + /** + * Checks the process of creating and rendering new geometric shape + * constructed from a chord inside a rectangle using union operator. The shape is + * rendered using color fill. + * + * @param image + * image to which area is to be drawn + * @param graphics2d + * graphics canvas + * @return test result status - PASSED, FAILED or ERROR + */ + public TestResult testOverlappingChordAndRectangleUnionColorPaint(TestImage image, Graphics2D graphics2d) + { + // set fill color + CommonRenderingStyles.setFillColor(graphics2d); + // create area using union operator + Area area = CommonCAGOperations.createAreaFromOverlappingChordAndRectangleUsingUnionOperator(image); + // fill the area + graphics2d.fill(area); + // test result + return TestResult.PASSED; + } + + /** + * Checks the process of creating and rendering new geometric shape + * constructed from a chord inside a rectangle using subtract operator. The shape is + * rendered using color fill. + * + * @param image + * image to which area is to be drawn + * @param graphics2d + * graphics canvas + * @return test result status - PASSED, FAILED or ERROR + */ + public TestResult testOverlappingChordAndRectangleSubtractColorPaint(TestImage image, Graphics2D graphics2d) + { + // set fill color + CommonRenderingStyles.setFillColor(graphics2d); + // create area using subtract operator + Area area = CommonCAGOperations.createAreaFromOverlappingChordAndRectangleUsingSubtractOperator(image); + // fill the area + graphics2d.fill(area); + // test result + return TestResult.PASSED; + } + + /** + * Checks the process of creating and rendering new geometric shape + * constructed from a chord inside a rectangle using inverse subtract operator. + * The shape is rendered using color fill. + * + * @param image + * image to which area is to be drawn + * @param graphics2d + * graphics canvas + * @return test result status - PASSED, FAILED or ERROR + */ + public TestResult testOverlappingChordAndRectangleInverseSubtractColorPaint(TestImage image, Graphics2D graphics2d) + { + // set fill color + CommonRenderingStyles.setFillColor(graphics2d); + // create area using inverse subtract operator + Area area = CommonCAGOperations.createAreaFromOverlappingChordAndRectangleUsingInverseSubtractOperator(image); + // fill the area + graphics2d.fill(area); + // test result + return TestResult.PASSED; + } + + /** + * Checks the process of creating and rendering new geometric shape + * constructed from a chord inside a rectangle using intersect operator. + * The shape is rendered using color fill. + * + * @param image + * image to which area is to be drawn + * @param graphics2d + * graphics canvas + * @return test result status - PASSED, FAILED or ERROR + */ + public TestResult testOverlappingChordAndRectangleIntersectColorPaint(TestImage image, Graphics2D graphics2d) + { + // set fill color + CommonRenderingStyles.setFillColor(graphics2d); + // create area using intersect operator + Area area = CommonCAGOperations.createAreaFromOverlappingChordAndRectangleUsingIntersectOperator(image); + // fill the area + graphics2d.fill(area); + // test result + return TestResult.PASSED; + } + + /** + * Checks the process of creating and rendering new geometric shape + * constructed from a chord inside a rectangle using XOR operator. + * The shape is rendered using color fill. + * + * @param image + * image to which area is to be drawn + * @param graphics2d + * graphics canvas + * @return test result status - PASSED, FAILED or ERROR + */ + public TestResult testOverlappingChordAndRectangleXorColorPaint(TestImage image, Graphics2D graphics2d) + { + // set fill color + CommonRenderingStyles.setFillColor(graphics2d); + // create area using Xor operator + Area area = CommonCAGOperations.createAreaFromOverlappingChordAndRectangleUsingXorOperator(image); + // fill the area + graphics2d.fill(area); + // test result + return TestResult.PASSED; + } + + /** + * Checks the process of creating and rendering new geometric shape + * constructed from a chord inside a rectangle using union operator. The shape is + * rendered using radial gradient fill. + * + * @param image + * image to which area is to be drawn + * @param graphics2d + * graphics canvas + * @return test result status - PASSED, FAILED or ERROR + */ + public TestResult testOverlappingChordAndRectangleUnionRadialGradientPaint(TestImage image, Graphics2D graphics2d) + { + // set radial gradient fill + CommonRenderingStyles.setRadialGradientFill(image, graphics2d); + // create area using union operator + Area area = CommonCAGOperations.createAreaFromOverlappingChordAndRectangleUsingUnionOperator(image); + // fill the area + graphics2d.fill(area); + // test result + return TestResult.PASSED; + } + + /** + * Checks the process of creating and rendering new geometric shape + * constructed from a chord inside a rectangle using subtract operator. The shape is + * rendered using radial gradient fill. + * + * @param image + * image to which area is to be drawn + * @param graphics2d + * graphics canvas + * @return test result status - PASSED, FAILED or ERROR + */ + public TestResult testOverlappingChordAndRectangleSubtractRadialGradientPaint(TestImage image, Graphics2D graphics2d) + { + // set radial gradient fill + CommonRenderingStyles.setRadialGradientFill(image, graphics2d); + // create area using subtract operator + Area area = CommonCAGOperations.createAreaFromOverlappingChordAndRectangleUsingSubtractOperator(image); + // fill the area + graphics2d.fill(area); + // test result + return TestResult.PASSED; + } + + /** * Entry point to the test suite. * * @param args not used in this case From jvanek at redhat.com Fri Sep 5 12:45:12 2014 From: jvanek at redhat.com (Jiri Vanek) Date: Fri, 05 Sep 2014 14:45:12 +0200 Subject: docs generator - prereview In-Reply-To: <2127323249.558740.1409856933886.JavaMail.zimbra@redhat.com> References: <5405E4C0.9050909@redhat.com> <540882BB.5070100@redhat.com> <2127323249.558740.1409856933886.JavaMail.zimbra@redhat.com> Message-ID: <5409B058.4040809@redhat.com> On 09/04/2014 08:55 PM, Jie Kang wrote: > ----- Original Message ----- >> >> Hi! >> >> >> Proudly :) presenting... documentation generator for ITW. >> >> Lukas Dracz already seen the preversion, because we shares one peace of code >> - >> OptionsDefinitions.java - also he was trying to impelmetn first versions >> of this. >> >> Now his patch is built on top of this. >> >> Well, it does a lot of things >> - generates man pages and html doc* and palintext docs** >> - unified files declarations >> - unified options declarations >> >> * html docs >> - are usleless in offlien mode (maybe we can publish them on classapth >> org after each release - >> but are used (generated in runtime) in help dialogue - which is really really >> nice. >> >> ** plain text docs - even les susefull then html docs, but are used in >> runtime commandlinehel/and >> about - which removed all the duplicated string providers. >> >> Various files and properties are sorted in javaws pages, have theyrs defaults >> and for sure none is >> missing. >> >> So finally no duplicated texts in various "about" and "help"! >> >> The patch is missing localization - I'm going to do so in some next >> changeset, and I hope to get >> rid of RepalcingFormater and its @@ substitution. >> >> >> >> As for review - anybody, please be specially careful about the files >> declaration. I hope I did it >> error-less and complete :( >> >> >> The design is >> >> 1docprovider - have 2formater is providing 3output >> >> eg: >> 1 - itw, itw-settings, javaws... >> 2 - html, plain, man >> 3 - man pages (generated during build, loclaized), runtime help - both >> console and "nice" html one. >> The runtime help have evaluated varibales and properties >> >> >> For runtime help I had to refactor about dialog a bit - only make some parts >> singletons and added >> an tab.... >> >> >> make check, install, dist and install form dist and unnstall works. >> >> >> >> J. > > > Hello, > > This patch is really large, is there any way you can split this into smaller iterations? For example, maybe have one patch that moves all paths and files into the PathsAndFiles.java, then one patch for the net.sourceforge.jnlp.docprovider addition, and then another patch for the makefile changes to use the docprovider. As well as a patch for refactoring the 'about dialog'. Or something along those lines; Right now no. I wonted at first, but the individual changes are so wired together that I failed to separate. (not that it is impossible, but that it is too costly) Also - considering nature of patch, - immediately visible result - no soemhow at least a bit important part affected I'm very inclined to push it as it is, and tune on flow. Except the design itself, the only part needing careful review is the part refactoring the files. > > One thing as well when you look at doing the localization part. Right now Translator just delegates to JNLPRuntime. > > e.g: > public static String R(String message, Object... params) { > return JNLPRuntime.getMessage(message, params); > } > > I think we should move the translating parts from JNLPRuntime into Translator. Thoughts? Maybe? But not inside this already big chngeset :) J. From aazores at redhat.com Fri Sep 5 17:16:43 2014 From: aazores at redhat.com (Andrew Azores) Date: Fri, 05 Sep 2014 13:16:43 -0400 Subject: [rfc][icedtea-web] javaws.1 man page update In-Reply-To: <53F8D650.5090702@redhat.com> References: <53F8D650.5090702@redhat.com> Message-ID: <5409EFFB.8030504@redhat.com> On 08/23/2014 01:58 PM, Andrew Azores wrote: > Hi, > > I looked at `man javaws` for some reason yesterday - no idea what I was > looking for or why - and thought it could do with some minor > improvement. I've fixed a few minor typos, improved the phrasing in a > few areas, and made it more consistent with capitalizing acronyms such > as XML, HTML, and JNLP. > > Thanks, Since the generated man pages feature is finally shaping up and looks like it might actually be done soon(ish), I suppose this patch is obsoleted? Thanks, -- Andrew Azores From jvanek at redhat.com Fri Sep 5 20:43:04 2014 From: jvanek at redhat.com (Jiri Vanek) Date: Fri, 05 Sep 2014 22:43:04 +0200 Subject: [rfc][icedtea-web] javaws.1 man page update In-Reply-To: <5409EFFB.8030504@redhat.com> References: <53F8D650.5090702@redhat.com> <5409EFFB.8030504@redhat.com> Message-ID: <540A2058.2030304@redhat.com> On 09/05/2014 07:16 PM, Andrew Azores wrote: > On 08/23/2014 01:58 PM, Andrew Azores wrote: >> Hi, >> >> I looked at `man javaws` for some reason yesterday - no idea what I was >> looking for or why - and thought it could do with some minor >> improvement. I've fixed a few minor typos, improved the phrasing in a >> few areas, and made it more consistent with capitalizing acronyms such >> as XML, HTML, and JNLP. >> >> Thanks, > > Since the generated man pages feature is finally shaping up and looks like it might actually be done soon(ish), I suppose this patch is obsoleted? > > Thanks, > I hope so :) J. From jvanek at redhat.com Fri Sep 5 20:43:24 2014 From: jvanek at redhat.com (Jiri Vanek) Date: Fri, 05 Sep 2014 22:43:24 +0200 Subject: [rfc][icedtea-web] javaws.1 man page update In-Reply-To: <5409EFFB.8030504@redhat.com> References: <53F8D650.5090702@redhat.com> <5409EFFB.8030504@redhat.com> Message-ID: <540A206C.9000805@redhat.com> On 09/05/2014 07:16 PM, Andrew Azores wrote: > On 08/23/2014 01:58 PM, Andrew Azores wrote: >> Hi, >> >> I looked at `man javaws` for some reason yesterday - no idea what I was >> looking for or why - and thought it could do with some minor >> improvement. I've fixed a few minor typos, improved the phrasing in a >> few areas, and made it more consistent with capitalizing acronyms such >> as XML, HTML, and JNLP. >> >> Thanks, > > Since the generated man pages feature is finally shaping up and looks like it might actually be done soon(ish), I suppose this patch is obsoleted? > > Thanks, > But.. Isnt it valid for 1.5? From gitne at gmx.de Fri Sep 5 23:38:18 2014 From: gitne at gmx.de (Jacob Wisor) Date: Sat, 06 Sep 2014 01:38:18 +0200 Subject: [rfc][icedtea-web] TeeOutputStream Dependency Fix In-Reply-To: <674136995.453135.1409844683435.JavaMail.zimbra@redhat.com> References: <674136995.453135.1409844683435.JavaMail.zimbra@redhat.com> Message-ID: <540A496A.5050804@gmx.de> On 09/04/2014 at 05:31 PM, Jie Kang wrote: > Hello, > > This patch adds a logger dependency injection to TeeOutputStream so that the tests no longer require a protected function in order to run. > > Thoughts? I am not sure whether this approach makes the existing flaw better or worse. :-\ I am going to go with probably worse. Again, why cannot we use reflection here to get TeeOutputStream.byteArrayOutputStream and then monitor its flow during the test? Really, this is one reason why reflection has been introduced to Java. Jacob From gitne at gmx.de Fri Sep 5 23:47:13 2014 From: gitne at gmx.de (Jacob Wisor) Date: Sat, 06 Sep 2014 01:47:13 +0200 Subject: [rfc][icedtea-web] javaws.1 man page update In-Reply-To: <5409EFFB.8030504@redhat.com> References: <53F8D650.5090702@redhat.com> <5409EFFB.8030504@redhat.com> Message-ID: <540A4B81.4090306@gmx.de> On 09/05/2014 at 07:16 PM, Andrew Azores wrote: > On 08/23/2014 01:58 PM, Andrew Azores wrote: >> Hi, >> >> I looked at `man javaws` for some reason yesterday - no idea what I was >> looking for or why - and thought it could do with some minor >> improvement. I've fixed a few minor typos, improved the phrasing in a >> few areas, and made it more consistent with capitalizing acronyms such >> as XML, HTML, and JNLP. >> >> Thanks, > > Since the generated man pages feature is finally shaping up and looks like it > might actually be done soon(ish), I suppose this patch is obsoleted? Not really. Actually, you should probably check the generated documentation output against the improvements you have made in your patch. AFAICT, most of the stuff in your patch is about punctuation and formatting. So, since you seem to have a keen eye on this you could check the generated documentation output. ;-) From gitne at gmx.de Sat Sep 6 00:07:44 2014 From: gitne at gmx.de (Jacob Wisor) Date: Sat, 06 Sep 2014 02:07:44 +0200 Subject: docs generator - prereview In-Reply-To: <2127323249.558740.1409856933886.JavaMail.zimbra@redhat.com> References: <5405E4C0.9050909@redhat.com> <540882BB.5070100@redhat.com> <2127323249.558740.1409856933886.JavaMail.zimbra@redhat.com> Message-ID: <540A5050.2050706@gmx.de> W dniu 04.09.2014 20:55, Jie Kang pisze: > ----- Original Message ----- >> >> Hi! >> >> >> Proudly :) presenting... documentation generator for ITW. >> >> Lukas Dracz already seen the preversion, because we shares one peace of code >> - >> OptionsDefinitions.java - also he was trying to impelmetn first versions >> of this. >> >> Now his patch is built on top of this. >> >> Well, it does a lot of things >> - generates man pages and html doc* and palintext docs** >> - unified files declarations >> - unified options declarations >> >> * html docs >> - are usleless in offlien mode (maybe we can publish them on classapth >> org after each release - >> but are used (generated in runtime) in help dialogue - which is really really >> nice. >> >> ** plain text docs - even les susefull then html docs, but are used in >> runtime commandlinehel/and >> about - which removed all the duplicated string providers. >> >> Various files and properties are sorted in javaws pages, have theyrs defaults >> and for sure none is >> missing. >> >> So finally no duplicated texts in various "about" and "help"! >> >> The patch is missing localization - I'm going to do so in some next >> changeset, and I hope to get >> rid of RepalcingFormater and its @@ substitution. >> >> >> >> As for review - anybody, please be specially careful about the files >> declaration. I hope I did it >> error-less and complete :( >> >> >> The design is >> >> 1docprovider - have 2formater is providing 3output >> >> eg: >> 1 - itw, itw-settings, javaws... >> 2 - html, plain, man >> 3 - man pages (generated during build, loclaized), runtime help - both >> console and "nice" html one. >> The runtime help have evaluated varibales and properties >> >> >> For runtime help I had to refactor about dialog a bit - only make some parts >> singletons and added >> an tab.... >> >> >> make check, install, dist and install form dist and unnstall works. >> >> >> >> J. > > > Hello, > > This patch is really large, is there any way you can split this into smaller iterations? For example, maybe have one patch that moves all paths and files into the PathsAndFiles.java, then one patch for the net.sourceforge.jnlp.docprovider addition, and then another patch for the makefile changes to use the docprovider. As well as a patch for refactoring the 'about dialog'. Or something along those lines; Yeah, this patch is really big. Smaller logical chucks would be better. But, I admit it may become difficult or even impossible to split up due to its interdependent nature. > One thing as well when you look at doing the localization part. Right now Translator just delegates to JNLPRuntime. > > e.g: > public static String R(String message, Object... params) { > return JNLPRuntime.getMessage(message, params); > } > > I think we should move the translating parts from JNLPRuntime into Translator. Thoughts? Without taking a close look at this, I would say so too. From gitne at gmx.de Sat Sep 6 00:14:17 2014 From: gitne at gmx.de (Jacob Wisor) Date: Sat, 06 Sep 2014 02:14:17 +0200 Subject: Fwd: docs generator - prereview In-Reply-To: <540882BB.5070100@redhat.com> References: <5405E4C0.9050909@redhat.com> <540882BB.5070100@redhat.com> Message-ID: <540A51D9.8070503@gmx.de> On 09/04/2014 at 05:18 PM, Jiri Vanek wrote: > > Hi! > > > Proudly :) presenting... documentation generator for ITW. > > Lukas Dracz already seen the preversion, because we shares one peace of code - > OptionsDefinitions.java - also he was trying to impelmetn first versions of > this. > > Now his patch is built on top of this. > > Well, it does a lot of things > - generates man pages and html doc* and palintext docs** > - unified files declarations > - unified options declarations > > * html docs > - are usleless in offlien mode (maybe we can publish them on classapth org > after each release - > but are used (generated in runtime) in help dialogue - which is really really nice. > > ** plain text docs - even les susefull then html docs, but are used in runtime > commandlinehel/and about - which removed all the duplicated string providers. > > Various files and properties are sorted in javaws pages, have theyrs defaults > and for sure none is > missing. > > So finally no duplicated texts in various "about" and "help"! > > The patch is missing localization - I'm going to do so in some next > changeset, and I hope to get > rid of RepalcingFormater and its @@ substitution. > > > > As for review - anybody, please be specially careful about the files > declaration. I hope I did it error-less and complete :( > > > The design is > > 1docprovider - have 2formater is providing 3output > > eg: > 1 - itw, itw-settings, javaws... > 2 - html, plain, man > 3 - man pages (generated during build, loclaized), runtime help - both console > and "nice" html one. > The runtime help have evaluated varibales and properties > > > For runtime help I had to refactor about dialog a bit - only make some parts > singletons and added > an tab.... > > > make check, install, dist and install form dist and unnstall works. This is a *lot* of text. :-o I am going to require some time to digest it, so please do not expect any qualitative comment on this patch from me any time soon. Anyway, I appreciate that you have finally come to embark on this problem. :-) Jacob From bugzilla-daemon at icedtea.classpath.org Sat Sep 6 09:06:13 2014 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Sat, 06 Sep 2014 09:06:13 +0000 Subject: [Bug 1984] New: My eclipse interrupted acciently... Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1984 Bug ID: 1984 Summary: My eclipse interrupted acciently... Product: IcedTea Version: 6-1.13.4 Hardware: x86_64 OS: Linux Status: NEW Severity: enhancement Priority: P5 Component: IcedTea Assignee: gnu.andrew at redhat.com Reporter: zhehua_xiao at 163.com CC: unassigned at icedtea.classpath.org Created attachment 1161 --> http://icedtea.classpath.org/bugzilla/attachment.cgi?id=1161&action=edit Automatically It occurs very time I run it. -- You are receiving this mail because: You are on the CC list for the bug. -------------- next part -------------- An HTML attachment was scrubbed... URL: From helpcrypto at gmail.com Mon Sep 8 06:59:50 2014 From: helpcrypto at gmail.com (helpcrypto helpcrypto) Date: Mon, 8 Sep 2014 08:59:50 +0200 Subject: [rfc][icedtea-web][itweb-settings] Improve Icedtea-Web cache disk space In-Reply-To: <809710797.550417.1409855988786.JavaMail.zimbra@redhat.com> References: <319590383.4051363.1404829211485.JavaMail.zimbra@redhat.com> <540180DB.4050109@gmx.de> <54071A8A.9050202@gmx.de>

$(PLUGIN_VERSION) docs:

$(PLUGIN_VERSION) docs: