[rfc][icedtea-web] Option Parser
Omair Majid
omajid at redhat.com
Thu Sep 4 18:18:31 UTC 2014
* Lukasz Dracz <ldracz at redhat.com> [2014-09-04 11:15]:
> I looked into what was using this and it was ParserSettings so I redid
> the method to accept two booleans instead of args which it would then
> look for the "-strict" and "-xml" tags inside of. This also meant
> changing the ParserSettingsTest which in my opinion don't make sense
> in their current state. I plan on looking into Parser and
> ParserSetting in the future and see how they are used and if it makes
> sense for them to be changed to incorporate the OptionParser.
Looking quickly through the code, I am a little surprised. It seems like
the simple/obvious thing to do is to create a new ParserSettings object
based on settings to use for the parser (like, `ParserSettings(boolean
strict)`), not from program arguments. I will be perfectly happy if you
modified the ParserSettings class to move in this direction.
It's fine to do it in a separate patch.
Thanks,
Omair
--
PGP Key: 66484681 (http://pgp.mit.edu/)
Fingerprint = F072 555B 0A17 3957 4E95 0056 F286 F14F 6648 4681
More information about the distro-pkg-dev
mailing list