[rfc][icedtea-web] TeeOutputStream Dependency Fix

Jacob Wisor gitne at gmx.de
Fri Sep 5 23:38:18 UTC 2014


On 09/04/2014 at 05:31 PM, Jie Kang wrote:
> Hello,
>
> This patch adds a logger dependency injection to TeeOutputStream so that the tests no longer require a protected function in order to run.
>
> Thoughts?

I am not sure whether this approach makes the existing flaw better or worse. :-\
I am going to go with probably worse. Again, why cannot we use reflection here 
to get TeeOutputStream.byteArrayOutputStream and then monitor its flow during 
the test? Really, this is one reason why reflection has been introduced to Java.

Jacob


More information about the distro-pkg-dev mailing list