[rfc][icedtea-web] TeeOutputStream Dependency Fix
Omair Majid
omajid at redhat.com
Tue Sep 9 15:15:08 UTC 2014
* Jiri Vanek <jvanek at redhat.com> [2014-09-09 11:03]:
> Unluckily, yes, this have spread in ITW a lot. The api is being dirty by
> non-private utility methods which
> - should be private
> - should be tested
Can you give some examples of this? If it's really, really private,
maybe it shouldn't be tested?
> I would probably like to set some kind of rule for this to future. To test
> such private methods via reflection stub. It will move test "api" issues
> from compile time to runtime, but by retrospective look, it is probably
> worthy.
Working in a language with static types, the type system can be a great
friend, not only finding and helping fix errors before they can happen
at runtime, but also helping discover things (for example, all pieces of
code that invoke a certain method). Reflection can work against static
typing and make things more difficult to see and figure out. Please be
really, really sure you need to use reflection before you decide to use
it (or worse, mandate it).
Thanks,
Omair
--
PGP Key: 66484681 (http://pgp.mit.edu/)
Fingerprint = F072 555B 0A17 3957 4E95 0056 F286 F14F 6648 4681
More information about the distro-pkg-dev
mailing list