[rfc][icedtea-web] Cache LRU Wrapper Locking and Unit Tests

[Jiri Vanek]

On 09/09/2014 10:36 PM, Jie Kang wrote:
> Hello,
>
> This patch modifies the locking system for the CacheLRUWrapper in order to use the locking provided by PropertiesFile (which was introduced in the CacheEntry Locking Fix)[1]. Both CacheEntry and CacheLRUWrapper use a PropertiesFile and the locking mechanism is the same. Tests have also been added to more thoroughly test the CacheLRUWrapper class.
>
> [1]http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2014-August/029093.html
>
> Reproducers and manual testing have been performed in order to ensure no regressions.
>
> Thoughts?
>
>
...
> -        return cacheOrder.contains(key);
> -    }
> +    public synchronized boolean containsKey(String key) { return cacheOrder.containsKey(key); }
> +
> +    public synchronized boolean containsValue(String value) { return cacheOrder.containsValue(value); }
>

Please expand those to three (At least) liens each.

Otherwise ok to go.

>       /**
>        * Generate a key given the path to file. May or may not generate the same
...