patch: some initial fixes
Jiri Vanek
jvanek at redhat.com
Thu Sep 11 09:27:08 UTC 2014
Hi Zdenek,
Thank you for contribution. Unluckily I advised you bad list. This belongs to
thermostat at icedtea.classpath.org.
Few minor notes
The subject should be more descriptive and with heading:
[rfc][thermostatQA] making thermostat QA buildable again.
On 09/11/2014 11:19 AM, Zdeněk Žamberský wrote:
> 2014-09-10 Zdenek Zambersky <zzambers at redhat.com>
>
Summary is missing here - it should be similar to subject.
> * Makefile: Removed references to non-existing classes IconCut and PatternDefinitionsGenerator,
> which prevented from successful build.
> * src/org/thermostat/qa/common/Configuration.java(readAllProperties):
> Fixed problem with paths not ending with separator. Added method getPathProperty.
> * patterns/1.1.0/AA/MainWindow/host_icon_with_arrow.png: Added missing files needed by
> DBGuiHeapDumpTest. (Copied from patterns/1.1.0/noAA/MainWindow.)
> * patterns/1.1.0/AA/MainWindow/vm_icon_blue2.png: same
> * patterns/1.1.0/AA/MainWindow/vm_icon_whiteblue.png: same
> * .hgignore: Excludes files generated (by makefile, tests, ...) from being tracked.
> * scripts/mongoPortNumber.txt: removed
> * scripts/run_thermostat_shell_with_commands.sh: removed
> Removed files. These are generated by tests.
>
> ThermostatQA-initial-fixes.diff
>
>
> diff -r 5abf85c4d3ba .hgignore
> --- /dev/null Thu Jan 01 00:00:00 1970 +0000
> +++ b/.hgignore Thu Sep 11 10:49:44 2014 +0200
> @@ -0,0 +1,24 @@
> +syntax:glob
> +
> +bin/** # compiled classes
> +thermostat/** # thermostat tested
> +apache-tomcat/** # tomcat used for testing
I'm not sure if thermostat and apache-tomcat should be there. They sould be compeltly awayand path
to them should be .. somewhere specified.
> +logs/** # logs from tests
> +reports/** # reports from tests
> +screenshots/** # screenshots from tests
> +manifest.mf # generated by build phase
> +.attach_pid* # created by tests
> +prototype.flotr-0.2.0-alpha.zip # downloaded by makefile
> +
> +# auto-generated scripts and text files
> +scripts/webStorage_*.sh
> +scripts/thermostatPingHost.sh
> +scripts/thermostatListVms.sh
> +scripts/thermostatDumpHeap.sh
> +scripts/xvfb*.sh
> +scripts/guitests-cleanOneTest.sh
> +scripts/run_thermostat_shell_with_commands.sh
> +scripts/run_mongo_shell_with_commands.sh
> +scripts/mongoPortNumber.txt
> +scripts/dblogin.txt
> +
> diff -r 5abf85c4d3ba Makefile
> --- a/Makefile Mon Apr 28 16:13:20 2014 +0200
> +++ b/Makefile Thu Sep 11 10:49:44 2014 +0200
> @@ -82,8 +82,6 @@
> $(BUILD_DIR)/$(FRAMEWORK_PACKAGE)/ThermostatOutputTextsGenerator.class \
> $(BUILD_DIR)/$(FRAMEWORK_PACKAGE)/GuiRobot.class \
> $(BUILD_DIR)/$(FRAMEWORK_PACKAGE)/Patterns.class \
> - $(BUILD_DIR)/$(FRAMEWORK_PACKAGE)/IconCut.class \
> - $(BUILD_DIR)/$(FRAMEWORK_PACKAGE)/PatternDefinitionsGenerator.class \
> $(BUILD_DIR)/$(TEST_PACKAGE)/AgentTest.class \
> $(BUILD_DIR)/$(TEST_PACKAGE)/CliClientSmokeTest.class \
> $(BUILD_DIR)/$(TEST_PACKAGE)/GuiClientSmokeTest.class \
> diff -r 5abf85c4d3ba patterns/1.1.0/AA/MainWindow/host_icon_with_arrow.png
> Binary file patterns/1.1.0/AA/MainWindow/host_icon_with_arrow.png has changed
> diff -r 5abf85c4d3ba patterns/1.1.0/AA/MainWindow/vm_icon_blue2.png
> Binary file patterns/1.1.0/AA/MainWindow/vm_icon_blue2.png has changed
> diff -r 5abf85c4d3ba patterns/1.1.0/AA/MainWindow/vm_icon_whiteblue.png
> Binary file patterns/1.1.0/AA/MainWindow/vm_icon_whiteblue.png has changed
> diff -r 5abf85c4d3ba scripts/mongoPortNumber.txt
Well the handling of images by duplicating them is not hte best way:(. But fix of this is beyond
scope of this patch.
After agreed above minors, I think it will be ok to push.
Ty for your first contribution!
J:)
More information about the distro-pkg-dev
mailing list