[rfc][icedtea-web] localizable files and icedtea-web about page

[Jie Kang]

Hello,

Looks nice! A few nits:

+        for (int x=1 ; x<=7 ; x++){
+            p1.append(getFormatter().getOption(Translator.R("ITWdescO"+x+"title"), Translator.R("ITWdescO"+x+"text")));
+        }

Can you comment here why it goes from 1 to 7? Something like : pulls from Message.properties [(ITWdesc01title, ITWdesc01text), ...]
Just to make understanding faster :)


    @Override
    public String getIntroduction() {
        return super.getIntroduction()
                + getFormatter().wrapParagraph(
                        Translator.R("ITWintroL1",getFormatter().getBold(getId() + " "))
                        + getFormatter().getNewLine() + getFormatter().getNewLine()
                        + Translator.R("ITWintroL2")
                        + getFormatter().getNewLine()
                        + Translator.R("ITWintroL3", getId(), getFormatter().getUrl("http://www.java.com/en/download/testjava.jsp", Translator.R("ITWintroUrlCaption")))
           minor             + getFormatter().getNewLine()
                        + getFormatter().getOption("",Translator.R("BFileInfoAuthors"))
                        + getFormatter().getOption("",Translator.R("BFileInfoCopying"))
                        + getFormatter().getOption("",Translator.R("BFileInfoNews"))
                        + getFormatter().getNewLine() + getFormatter().getNewLine());

    }

for the multiple getFormatter().getNewLine() do you think it would be neat to have a function like:
getNewLine(int num) : Returns 'num' new line characters.



String header = getFormatter().getBold("Features of NetX: ") + getFormatter().getNewLine();

"Features of NetX: "   This string should probably be localized


+ITWintroL1={0}provides a Free Software web browser plugin running applets written in the Java programming language and an implementation of Java Web Start, originally based on the NetX project.

Do you think the "Free Software" should be changed to "Free Open Source Software"?

+ITWintroL3={0} also includes a plugin to {1} within web browsers.

For this message I see in the english man page:
icedtea-web also includes a plugin to http://www.java.com/en/download/testjava.jsp within web browsers.

Is this replacement of {1} with http://... supposed to happen? It doesn't really make sense to me.





In the english man page for Description I see:
Features of NetX:

       Modular     Easily add JNLP capabilities to an application.

       Saves Memory
                   Launch programs in a shared JVM.

       Fast startup
                   Runs applications from a cache for fast starting.

       Security    Run any application in a sandbox or log its activities.

       Auto-Update Applications can auto-update without special code.

       Network Deployment
                   Deploy to the internet, not with installers.

Can you make the format consistent by making the text part always on a new line? E.g:
   Security    Run any application in a sandbox or log its activities.
becomes
   Security    
       Run any application in a sandbox or log its activities.





Also the text here (from english man page) has very weird spacing: 

Visit    the    http://icedtea.classpath.org/wiki/Main_Page   or   specifically   the   http://icedtea.class‐
       path.org/wiki/IcedTea-Web pages for more information.
       Help with common issues with  IcedTea-Web  can  be  found  http://icedtea.classpath.org/wiki/IcedTea-Web#Com‐
       mon_Issues .

I think this has to do with the formatting? I am not sure.




Regards,

----- Original Message -----
> ssia
> 
> First of patches moving the individual liens to properties. Fixes to
> individual sentences welcomed.
> 
> J.
> 

-- 

Jie Kang