[fyi] [icedtea-web]failing unittest testSetFileNull

[Jie Kang]

No objections from me. Can you check what the behaviour is if an NPE get's thrown? Does the program crash? or does it chain up somewhere and get dealt with safely?

If necessary maybe a new patch should make sure it can't crash from this null file behaviour. I think it's been coded so null file should never reach those locations but safeguards should still be put in place.


Regards,

----- Original Message -----
> On 09/11/2014 04:35 PM, Lukasz Dracz wrote:
> > Hello,
> >
> >> No removal.
> >>
> >>
> >> Ensure that it works correctly even with null parameter.
> >>
> >>
> >> There is no similar test.
> >>
> >> J.
> >>
> >
> > Okay, I made a check to see whether file was set to null. Also added two
> > tests that test the methods that use file and check that they throw
> > NullPointerExceptions when file is set to null.
> >
> > Regards,
> > Lukasz Dracz
> >
> Sounds ok to me. But ping also Jie if he is ok with that.
> 
> 
> Thanx!
> 
> J.
> 

-- 

Jie Kang