[rfc][icedtea-web] localizable files and icedtea-web about page
Jiri Vanek
jvanek at redhat.com
Mon Sep 15 15:16:29 UTC 2014
On 09/15/2014 05:12 PM, Jie Kang wrote:
>
>
> ----- Original Message -----
>> On 09/11/2014 05:41 PM, Jie Kang wrote:
>>> Hello,
>>>
>>> Looks nice! A few nits:
>>>
>>> + for (int x=1 ; x<=7 ; x++){
>>> +
>>> p1.append(getFormatter().getOption(Translator.R("ITWdescO"+x+"title"),
>>> Translator.R("ITWdescO"+x+"text")));
>>> + }
>>>
>>> Can you comment here why it goes from 1 to 7? Something like : pulls from
>>> Message.properties [(ITWdesc01title, ITWdesc01text), ...]
>>> Just to make understanding faster :)
>>>
>>
>> done.
>>
>>>
>>> @Override
>>> public String getIntroduction() {
>>> return super.getIntroduction()
>>> + getFormatter().wrapParagraph(
>>> Translator.R("ITWintroL1",getFormatter().getBold(getId()
>>> + " "))
>>> + getFormatter().getNewLine() +
>>> getFormatter().getNewLine()
>>> + Translator.R("ITWintroL2")
>>> + getFormatter().getNewLine()
>>> + Translator.R("ITWintroL3", getId(),
>>> getFormatter().getUrl("http://www.java.com/en/download/testjava.jsp",
>>> Translator.R("ITWintroUrlCaption")))
>>> minor + getFormatter().getNewLine()
>>> +
>>> getFormatter().getOption("",Translator.R("BFileInfoAuthors"))
>>> +
>>> getFormatter().getOption("",Translator.R("BFileInfoCopying"))
>>> +
>>> getFormatter().getOption("",Translator.R("BFileInfoNews"))
>>> + getFormatter().getNewLine() +
>>> getFormatter().getNewLine());
>>>
>>> }
>>>
>>> for the multiple getFormatter().getNewLine() do you think it would be neat
>>> to have a function like:
>>> getNewLine(int num) : Returns 'num' new line characters.
>>
>> I was thinking about it since beginning. Fixed, and added some tests. Hurray
>> - firs tunittests for
>> this thing O:(
>>>
>>>
>>>
>>> String header = getFormatter().getBold("Features of NetX: ") +
>>> getFormatter().getNewLine();
>>>
>>> "Features of NetX: " This string should probably be localized
>>
>> overlooked! Fixed, and reworded as Jacob suggested.
>>
>>>
>>>
>>> +ITWintroL1={0}provides a Free Software web browser plugin running applets
>>> written in the Java programming language and an implementation of Java Web
>>> Start, originally based on the NetX project.
>>>
>>> Do you think the "Free Software" should be changed to "Free Open Source
>>> Software"?
>>
>> Not fixed - as Jacob suggested.
>>>
>>> +ITWintroL3={0} also includes a plugin to {1} within web browsers.
>>>
>>> For this message I see in the english man page:
>>> icedtea-web also includes a plugin to
>>> http://www.java.com/en/download/testjava.jsp within web browsers.
>>>
>>> Is this replacement of {1} with http://... supposed to happen? It doesn't
>>> really make sense to me.
>>>
>>
>> Well. This is not easy task to fix.
>>
>> In HTML you have readable text-> hidden link. plaintext nor man support
>> similar thing.
>>
>> So I Implemented the man/plain foramtters to simply ignore the human readable
>> part, as the url is
>> the real keeper of information.
>>
>> If this is going to be subject of change, I'm for. I have jsut lack of ideas.
>> Anyway this will be different changeset, as it affects whole documentation
>>
>> Right now I have this foramting for plain texts urls in mind:
>> human readable title (url)
>>
>> Thoughts?
>
> Hello,
>
> I think the format of 'human readable title : (url)' works fine!
>
> As for the other things, yeah different changeset. After your patches are reviewed + applied, I will look into the formatting issues with man and see if I can come up with something;
>
> Also, can you double-check the text file for icedtea-web (plain.../en/icedteaweb.txt)
> I see on the very first line:
> *** icedtea-web P_TAIL ***
>
If you look to previous changeset, you can see that it was fixxed here (missing double ddoalr in
shell variable instead $$TP_TAIL was there only $TP_TAIL
> I'm not sure what this is for;;
>
> Apart from that looks good to me :)
>
Ok. I will push once Jacob approves. TY!
>
> Regards,
>
>
>>
>>>
>>>
>>>
>>>
>>> In the english man page for Description I see:
>>> Features of NetX:
>>>
>>> Modular Easily add JNLP capabilities to an application.
>>>
>>> Saves Memory
>>> Launch programs in a shared JVM.
>>>
>>> Fast startup
>>> Runs applications from a cache for fast starting.
>>>
>>> Security Run any application in a sandbox or log its activities.
>>>
>>> Auto-Update Applications can auto-update without special code.
>>>
>>> Network Deployment
>>> Deploy to the internet, not with installers.
>>>
>>> Can you make the format consistent by making the text part always on a new
>>> line? E.g:
>>
>> I cant! This is how program man is formatting TP command. I got this TP thing
>> from our original
>> pages (actually my results were 1:1 copies of those on non added lines)
>>
>> So - We may change to different formatting for parameters then TP, currently
>> I dont know of any more
>> suitable:(
>>
>> The TP do what it is supposed to do. It do some kind of two columns table,
>> where second column have
>> fixed starting point (it is declared by the number, in our case 12 everywhere
>> [12 everywhere was
>> also in original man pages)
>> So if you look at it, you will see, that the record is put to second line,
>> only where the first
>> column is longer then expected width (in our case 12)
>>
>> Anyway.. different changeset. Suggestions welcomed!
>>> Security Run any application in a sandbox or log its activities.
>>> becomes
>>> Security
>>> Run any application in a sandbox or log its activities.
>>>
>>>
>>>
>>>
>>>
>>> Also the text here (from english man page) has very weird spacing:
>>>
>>> Visit the http://icedtea.classpath.org/wiki/Main_Page or
>>> specifically the http://icedtea.class‐
>>> path.org/wiki/IcedTea-Web pages for more information.
>>> Help with common issues with IcedTea-Web can be found
>>> http://icedtea.classpath.org/wiki/IcedTea-Web#Com‐
>>> mon_Issues .
>>>
>>> I think this has to do with the formatting? I am not sure.
>>>
>>
>> This is nearly the same issue as TP. This is what program man is doing. It
>> formats the paragraphs
>> to fit your terminal width, and it is trying to align justifiably both left
>> and righ, but enlarging
>> spaces where suitable.
>>
>> so "hell ouu a friend" on 4 chars wide terminall will become similar to:
>> "hell"
>> " ouu"
>> " a"
>> "frie"
>> "nd"
>>
>> Afaik absolutely no op here.
>>>
>>>
>>> Regards,
>>>
>>> ----- Original Message -----
>>>> ssia
>>>>
>>>> First of patches moving the individual liens to properties. Fixes to
>>>> individual sentences welcomed.
>>>>
>>>> J.
>>>>
>>>
>>
>>
>> Thanx both of yo for check!
>>
>>
>> J.
>>
>
More information about the distro-pkg-dev
mailing list