[rfc][icedtea-web] Makefile Reproducer Tests Patch

Jie Kang jkang at redhat.com
Wed Sep 17 12:54:24 UTC 2014



----- Original Message -----
> On 09/16/2014 10:36 PM, Jie Kang wrote:
> > Hello,
> >
> >
> > This patch modifies the makefile and causes it to only process (compile,
> > copy, etc.) tests in the whitelist.
> >
> > This feature is greatly beneficial when running say
> >
> > 'make run-netx-dist-tests'
> >
> > which uses the whitelist to only run tests in the whitelist. Prior to this
> > patch, though the tests ran were filtered by the whitelist, all tests were
> > processed (compiled, resources moved, etc.). This wastes a large amount of
> > time processing tests that aren't run.
> >
> > Thoughts?
> >
> >
> > Regards.
> >
> 
> By doing so, the dependences of reproducer may not be compiled and installed.
> Is it what you wont?

Hello,


If a reproducer depends on another reproducer than I think it should be up to the dev to deal with that appropriately through documentation, etc. In the best-case scenario, no test, including reproducers, should have any dependency on another test.

Maybe we can add this functionality as a separate option? Then test-runner can choose to compile+install all tests, or compile+install only tests in the whitelist. This might be a good compromise.


Regards?


> 
> J.
> 

-- 

Jie Kang


More information about the distro-pkg-dev mailing list