[Bug 2009] [IcedTea7] Checksum of policy JAR files changes on every build

[bugzilla-daemon at icedtea.classpath.org]

http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=2009

JiriVanek <jvanek at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jvanek at redhat.com

--- Comment #2 from JiriVanek <jvanek at redhat.com> ---
Hi!

Thank you for handling this
Few nits (applicable for all hunks):

    1.63 +        $(TEMPDIR_LIMITED)/META-INF/MANIFEST.MF
    1.64 +    $(prep-target)
    1.65 +    $(CP) policy/limited/default_local.policy            \
    1.66 +        $(TEMPDIR_LIMITED)
    1.67 +    $(CP) policy/limited/exempt_local.policy            \

I think that the files should be handled in bulk -  copy content of limited
foldr perhaps?

    1.68 +        $(TEMPDIR_LIMITED)
    1.69 +    $(TOUCH) -r $(TEMPDIR_LIMITED)/META-INF                \
    1.70 +        $(TEMPDIR_LIMITED)/default_local.policy
    1.71 +    $(TOUCH) -r $(TEMPDIR_LIMITED)/META-INF                \

And same here. Instead of individual touches some bulk change. 

Well both those nits are probably valid only if there is slightest possibility
that any change amy come.
Then would be nice to actually not modify this code, but expect that the cp and
touch will be applied.

    1.72 +        $(TEMPDIR_LIMITED)/exempt_local.policy
    1.73 +    ( $(CD) $(TEMPDIR_UNLIMITED) && $(ZIPEXE) -Xr $@ META-INF    \
    1.74 +        default_local.policy exempt_local.policy )

Last nit  - why 1.1. 1980? It is not star of epoch nor anything I know. I would
probably vote fo today - the date of actual change...


And as final - are you sure, that custom manifest and zip instead of jar may
not cause any harm in future?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20140919/4c3255b9/attachment.html>