[Bug 2009] [IcedTea7] Checksum of policy JAR files changes on every build
bugzilla-daemon at icedtea.classpath.org
bugzilla-daemon at icedtea.classpath.org
Fri Sep 19 18:11:45 UTC 2014
http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=2009
--- Comment #4 from Andrew John Hughes <gnu.andrew at redhat.com> ---
I see your point about using the whole directory, but I went with individual
files because they are explicitly mentioned as dependencies in the Makefile
rules and were explicitly referenced in creating the JAR files originally. So,
the original version would have suffered from the same issue too if new files
were added. Additionally, the downside of using the whole directory is we might
equally pick up something we don't want...
I also wrote the unlimited versions (the ones we actually use) first, so the
limited one ended up being copy and paste ;)
1/1/1980 is the epoch for ZIP files (based on MS-DOS I presume). I use 1/1/1970
(the UNIX epoch) initially and it became 1/1/1980. Using the current date would
make the policy file newer than it already is (2010, I think), so I used the
epoch as that's using what's used if the date is "don't know" (tar files with
no timestamps use 1-1-1970, for instance).
I can't see it causing any harm. Looking at the code that uses this, the
manifest is never used, as far as I can see. I think the only reason it's in a
JAR file at all is because Oracle sign their versions. If it wasn't for this,
the original text file could have just been used, without all these issues.
--
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20140919/ae25d06c/attachment.html>
More information about the distro-pkg-dev
mailing list