[rfc][icedtea-web] localizable Plugin+settings+fix+cleanup
Jiri Vanek
jvanek at redhat.com
Mon Sep 22 12:55:56 UTC 2014
>>
>>> Typos shouldn't be a worry since we should in theory never accept things
>>> with typos.
>>
>> Really not agreed here. How exactly are we supposed to detect, let alone
>> even decide on accepting, what is a typo when attempting to create a
>> directory given only its name? To me this is a ludicrous proposition.
>> It's completely context dependent. You can try to deem a location as
>> being a "typo" if its parents don't yet exist and the -p switch isn't in
>> use, but this is not actually equivalent to being a typo. It's just a
>> weak-ish heuristic for it.
>>
>> It's one thing to simply assume that there aren't typos but that isn't
>> the same as asserting that typos will be rejected.
>
> You misunderstood me. I meant we ourselves shouldn't write typos and push them into the repo. Since we're in direct control of the directory name we shouldn't be making typos and so the -p issue shouldn't be a worry. I didn't mean the code should check for typos.
>
>
Imho he did not. W should not do typos, reviewer should check typos, we should hire human
spellchecker.... no metter how this list is long,there is no guarantee that no typo sneak through...
I can simply imagine scenario like - patch approved, so I prepare to push, final check on chnages,
and some unlucky key press just before closing editor and sin is done. So yes. Typoless ideall world
will be really great, but is ...(not nearly, but utterly) impossible.
So the -p can be dangerous anyway.
J.
More information about the distro-pkg-dev
mailing list