[rfc][icedtea-web] possible class cast exception in splashcontroler

[Jiri Vanek]

On 09/19/2014 07:51 PM, Jie Kang wrote:
>
>
> ----- Original Message -----
>> Some applets, may not be using the original apllet-viewer-pane, but rather
>> *detach*, and are in
>> separate window.
>>
>> If such an applet fails, the error screen can not be drawn, because the
>> applications frame is not
>> SpalshController.
>>
>> As splash logic can live happily with null splashcontoloere (==not work, and
>> silently exit) , the
>> class cast exception is unnecessary.
>>
>> There is nothing to be done to save the application as it already died, but
>> the error is imho really
>> unnecessary.
>
> Hello,
>
>
> Can you fix the type in:
> getSplashControler()
> to
> getSplashController()


Done.
>
> Could you also see if a test/reproducer can be added to make sure that a null return value is okay? (Can be another changeset) I looked through the code and it should be fine but a test to make sure would be great.
>
> Apart from that the patch looks fine.
>

Added small test to check null values do not throw NPEs.


Pushing to head. I would like to push it also to 1.5. ok?

Ty for check!

  J.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: splashCastFix2.patch
Type: text/x-patch
Size: 2158 bytes
Desc: not available
URL: <http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20140922/55a827f8/splashCastFix2.patch>