/hg/icedtea-web: 2 new changesets

Tue Apr 14 12:41:40 UTC 2015

----- Original Message -----
> Hi! jie!
> 
> 
> Isnt jnlp_href  declared in "wrong way" ?

I'm not sure what you mean by "wrong way".

> 
> New tests: 8
> testJnlpHrefAttributeDoesNotWork - epiphany (passing)
> testJnlpHrefAttributeDoesNotWork - firefox (faling)
> testJnlpHrefAttributeDoesNotWork - midori (passing)
> testJnlpHrefAttributeDoesNotWork - opera (faling)
> testJnlpHrefAttributeWorks - epiphany (faling)
> testJnlpHrefAttributeWorks - firefox (passing)
> testJnlpHrefAttributeWorks - midori (faling)
> testJnlpHrefAttributeWorks - opera (passing)

These results are expected.

testJnlpHrefAttributeDoesNotWork : passes if the applet fails to launch and is targeted at epiphany and midori
    @TestInBrowsers(testIn = { Browsers.midori, Browsers.epiphany})

  I guess you could have them fail and then mark with @KnownToFail instead of this way.

testJnlpHrefAttributeWorks : passes if the applet successfully launches and is targeted at firefox and opera
    @TestInBrowsers(testIn = { Browsers.firefox, Browsers.opera})

I'm not sure why it's running the tests for all browsers...

Regards,

> 
> Looking to http://icedtea.classpath.org/hg/icedtea-web/rev/aaea16216604 ..
> definitely is :)
> 
> On 04/13/2015 04:40 PM, jkang at icedtea.classpath.org wrote:
> > changeset a5e268a5b6dd in /hg/icedtea-web
> > details:
> > http://icedtea.classpath.org/hg/icedtea-web?cmd=changeset;node=a5e268a5b6dd
> > author: Jie Kang <jkang at redhat.com>
> > date: Mon Apr 13 10:32:57 2015 -0400
> >
> > 	Add reproducers for jnlp_href attribute
> >
> > 	2015-04-13  Jie Kang  <jkang at redhat.com>
> > 	    Add reproducers for jnlp_href attribute
> > 	    *
> > 	    tests/reproducers/simple/JnlpHrefAttribute/resources/JnlpHrefAttribute.html:
> > 	    *
> > 	    tests/reproducers/simple/JnlpHrefAttribute/resources/JnlpHrefAttribute.jnlp:
> > 	    *
> > 	    tests/reproducers/simple/JnlpHrefAttribute/srcs/JnlpHrefAttribute.java:
> > 	    *
> > 	    tests/reproducers/simple/JnlpHrefAttribute/testcases/JnlpHrefAttributeTest.java:
> > 	    Added test for firefox/opera that succeeds with attribute and test for
> > 	    midori/epiphany that fails with attribute
> >
> >
> .....
> 
> >   if ENABLE_PLUGIN
> > diff -r ebcd2aaa59c7 -r 0488d15d3f0e
> > tests/reproducers/simple/JnlpHrefAttribute/resources/JnlpHrefAttribute.html
> > --- /dev/null	Thu Jan 01 00:00:00 1970 +0000
> > +++
> > b/tests/reproducers/simple/JnlpHrefAttribute/resources/JnlpHrefAttribute.html
> > 	Mon Apr 13 10:38:15 2015 -0400
> > @@ -0,0 +1,15 @@
> > +<!DOCTYPE html>
> > +<html>
> > +<head lang="en">
> > +    <meta charset="UTF-8">
> > +    <title></title>
> > +</head>
> > +<body>
> > +<applet id='applet' code='JnlpHrefAttribute'
> > +        jnlp_href="JnlpHrefAttribute.jnlp"
> > +        width=640 height=480 MAYSCRIPT
> > +        scriptable=true>
> > +</applet>
> > +
> > +</body>
> > +</html>
> > \ No newline at end of file
> > diff -r ebcd2aaa59c7 -r 0488d15d3f0e
> > tests/reproducers/simple/JnlpHrefAttribute/resources/JnlpHrefAttribute.jnlp
> > --- /dev/null	Thu Jan 01 00:00:00 1970 +0000
> > +++
> > b/tests/reproducers/simple/JnlpHrefAttribute/resources/JnlpHrefAttribute.jnlp
> > 	Mon Apr 13 10:38:15 2015 -0400
> > @@ -0,0 +1,51 @@
> > +<?xml version="1.0" encoding="utf-8"?>
> > +<jnlp spec="1.0" href="JnlpHrefAttribute.jnlp">
> > +  <information>
> > +    <title>simple application</title>
> > +    <vendor>IcedTea</vendor>
> > +    <homepage
> > href="http://icedtea.classpath.org/wiki/IcedTea-Web#Testing_IcedTea-Web"/>
> > +  </information>
> > +  <resources>
> > +    <j2se version="1.6+"/>
> > +    <jar href="JnlpHrefAttribute.jar"/>
> > +  </resources>
> > +  <applet-desc main-class="JnlpHrefAttribute">
> > +  </applet-desc>
> > +</jnlp>
> > +
> 
> 

-- 

Jie Kang

OpenJDK Team - Software Engineering Intern