[rf][icedtea-web] fix xdgTests again

Jiri Vanek jvanek at redhat.com
Tue Apr 21 15:39:18 UTC 2015


So the xdgtest startet to faila again.

Mainly because of change in ignorance of attributes from true/false to enum.
To this the change in XDGspecificationTests is related (rest is small java7 liek refactoring).

However,it appeared that this is not enough, that setupable InfrastrucureDescriptors did it small 
evil hit there.
They caused, that DeploymentConfiguration singleton was created suddnely in the middle of 
files/directories move. That means, that it was created *before* deployment.properties were moved, 
co it actually caused lost of this data. The fix was obvious, move moving of deployment.properties 
to the begginig. So it moves, and then singleton can be created any time... later.

Thats  v1.patch.

Then I realized, that what if legacy deployment.properties contains some custom values, they are 
actually lost anyway. So I started to write v2.patch monstrosity
It is based on (good idea) to load DeploymentConfiguration legacy  deployment configuration as first 
step, and then use that getFullPath(differentConfig) mechanism. All went fine and worked, except 
fact, that the custom files actually dont need to be handled like that!
Because once they are custom-set  they do not need to be migrated. DeploymentConfiguration (loaded 
from copied deployment.configuration) will find them correctly.

So I reverted most the changes in  DeploymentConfiguration, but kept few nioce refactorings which 
were result of v2. So v3 is v1 + few refactorngs which I conisdered as ok.

So v3 is the one which I wont to push.

But.... During this email, I started to feel like v2 approach really cold be the best one. But 
considering that no one should be running on itw1.4 now, I would like to touch this code as few as 
possible. Everybody should be already on XDG and I relly do not won to spam users by the warning 
that both legacy and new config exists together.

Thanx for bringing me out of this maze!

-------------- next part --------------
A non-text attachment was scrubbed...
Name: fixXDGtests-v1.patch
Type: text/x-patch
Size: 9594 bytes
Desc: not available
URL: <http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20150421/810c163b/fixXDGtests-v1-0001.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fixXDGtests-v2.patch
Type: text/x-patch
Size: 28870 bytes
Desc: not available
URL: <http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20150421/810c163b/fixXDGtests-v2-0001.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fixXDGtests-v3.patch
Type: text/x-patch
Size: 22868 bytes
Desc: not available
URL: <http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20150421/810c163b/fixXDGtests-v3-0001.patch>

More information about the distro-pkg-dev mailing list