[rfc][icedtea-web] intorduce MultipleDeploymentPropertiesModifier
Jie Kang
jkang at redhat.com
Thu Apr 23 14:45:42 UTC 2015
Hello,
My objections from the previous threads are still here.
I would prefer simply modifying DeploymentPropertiesModifier to be able to deal with multiple properties. It's PropertiesModifier, not PropertyModifier after all.
At the very least, MultipleDeploymentPropertiesModifier should be it's own class with it's own test class. As well, please split the tests up similar to how they're split for the DeploymentPropertiesModifier tests. One for setting, one for resetting, etc.
Regards,
----- Original Message -----
> small class able to gather several DeploymentPropertiesModifiers and
> apply/revert themin bulk.
>
> J.
>
--
Jie Kang
OpenJDK Team - Software Engineering Intern
More information about the distro-pkg-dev
mailing list