[rfc] [icedtea-web] actualization of readme
Lukasz Dracz
ldracz at redhat.com
Mon Apr 27 15:06:01 UTC 2015
Hello,
----- Original Message -----
> From: "Jiri Vanek" <jvanek at redhat.com>
> To: "IcedTea Distro List" <distro-pkg-dev at openjdk.java.net>
> Sent: Monday, April 27, 2015 6:50:00 AM
> Subject: [rfc] [icedtea-web] actualization of readme
>
> Only minor accurateness. I would vote for removal it all and keeping just
> link to web... (but no..
> this minimalist file, if accurate, save it purpose)
>
>
> J.
>
The patch looks good, just a few small nits
+package, whole implementation is still in this package, NetX is kept referenced
+but whole icedtea-web as comlex, have now only few lines of code shared with
+original implementation.
but as a whole icedtea-web is complex, has now only a few lines of code shared with
the original implementation.
+In addition It also provides full desktop integration, offline run, own appletviwer,
appletviewer,
+* --with-jdk-home and --with-jre-home are your best friends.
+if you are using jdk without jre, it may force you to use both those switches
New sentence therefore should start with capital letter, if -> If
+junit tests and for reproducer. For plugin fake binary is created. and used.
For plugin a fake binary is created and used.
(Take away the period after created and add the 'a' I think it sounds better)
+Whether make check is tunning PAC tests and unittests, make run-netx-dist-tests
tunning -> running
+Whether make check is tunning PAC tests and unittests, make run-netx-dist-tests
+is running reproducers suite
Sorry also, I don't think whether is the best word to use here.
I think this below, would sound better:
Where make check is running PAC tests and unittests, make run-netx-dist-tests
runs the reproducers suite.
+is running reproducers suite. It expects you to have ITW installed (if you wont it
+to your personal space, use --prefix to specify final path)
(if you want to use it in your personal space, use --prefix ...)
+set to 'true'. It also starts the debug server on port 8787. If you set it to
+suspend java will wait for debugger to join before lunching main class.
lunching -> launching
Patch looks good :) ! Fix these changes and its good for a push,
unless you don't agree or want to discuss the changes :)
Thank you,
Lukasz Dracz
More information about the distro-pkg-dev
mailing list