[rfc][icedtea-web] fix jdk9 jre recognition

[Jiri Vanek]

On 04/27/2015 05:14 PM, Omair Majid wrote:
> * Jiri Vanek <jvanek at redhat.com> [2015-04-27 10:26]:
>> Now, when one is building itw with jdk9, he have to specify jre. It is pretty simple by something like:
>> ./configure --prefix=/home/jvanek/icedtea-web-image --with-firefox=no
>> --with-jdk-home=/usr/lib/jvm/java-1.9.0-openjdk
>> --with-jre-home=/usr/lib/jvm/java-1.9.0-openjdk
>>
>> But you really have to specify them both. As jdk9 do noth ave jre direcotry.
>>
>> This change should happily do it.
>
> I think this needs a bit more time to be baked.
>
>> +++ b/acinclude.m4	Mon Apr 27 16:21:37 2015 +0200
>
>> +    AC_MSG_RESULT(${SYSTEM_JDK_DIR} (readlink to ${READ}))
>
> Also, s/readlink/link/
>
>> +    SYSTEM_JRE_DIR8="${SYSTEM_JDK_DIR}/jre"
>
> This is true for 7 and 6 as well. Consider renaming the variable?
>
>> +    # try jdk7 or 8 coomliant
>
> Typo.
>
>> +    if [[ -d "${SYSTEM_JRE_DIR8}" -a -e "${SYSTEM_JRE_DIR8}/bin/java" -a -e "${SYSTEM_JRE_DIR8}/lib/rt.jar" ]]; then
>
> This is m4: [ and ] quote a string. You should use `test` explicitly,
> like in the code a few lines above this.
>
> Thanks,
> Omair
>

Better?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: betterJdk9Recognition2.patch
Type: text/x-patch
Size: 1787 bytes
Desc: not available
URL: <http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20150427/c9b1d1c1/betterJdk9Recognition2.patch>