[rfc][icedtea-web] PolicyEditor sorted entries list

Jiri Vanek jvanek at redhat.com
Wed Aug 19 12:27:31 UTC 2015

>> Well ths one looks scary :D
>> I would change changelog a bit, as this method do not implement compare.
>> Also  I woudl rename it - like comapreComaprable() ?-)
> What do you mean... ? This patch makes it so that PolicyIdentifier implements
> Comparable<PolicyIdentifier> and this 'int compareTo(PolicyIdentifier policyIdentifier)' is there to
> fulfill that contract. The static helper method 'compare(T a, T b)' is just there to simplify
> null-checking and comparison of two Comparables, like codebases and signedBys.
> The first part of it is just guaranteeing that ALL_APPLETS_IDENTIFIER is always less than any other
> PolicyIdentifier, other than itself. The following parts just sort the identifiers normally with
> codebase being the primary sort attribute, then signedBy, and finally principals.

Yes I got that.  Please rename the static method. Ok to push then.


More information about the distro-pkg-dev mailing list