ITW to build with jdk9 post b41

Jiri Vanek jvanek at redhat.com
Thu Feb 5 15:17:03 UTC 2015


On 02/02/2015 02:04 PM, Fridrich Strba wrote:
> Hello,
>
> I realized that we were creating classpaths in quite a non-robust way.
> That is why I created two make subfunctions: joinsegments (to convert a
> space separated string of path segments to one that is colon separated)
> and composeclasspath (which uses joinsegments and if its result is not
> empty, prepends "-classpath" to it).
>
> The reason of this change was that the build was running/breaking
> depending on whether the tagsoup was present or not. This simplifies
> some checks in the Makefile.am, since we can use the raw TAGSOUP_JAR
> variable without checking for it being empty. The same works for
> different other runtimes.
>
> Attached the patch including these changes and some little changes in
> the code itself to account for the existence of Java 9.
>
> Cheers
>
> Fridrich
>
> On 02/02/15 13:11, Jiri Vanek wrote:
>> Yes. I will split this changeset to two parts - removal of boostreap
>> dir( I wonted to do it looooong ago [kick myself]) . With some luck it
>> will be only needed thing to adapt to modular jdk.
>>
>> Second part will be the rest of this patch.
>
Hi!

Your patch was missing few usages of jointsegment I had added it. Also I had dropped emma targets. 
They are dead anyway. With my fixes also the codecoverage works.

I had tested it on openjdk 6.7.8 - looks ok!

Recently new variable JUNIT_RUNTIME was added. I had adapted it to follow your usecases. May you 
please doublecheck I did ti as you intendid? If you find this patch ok, feel free to push. Otherwise 
I'm looking for another round of review.


TyVM!

J.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: icedtea-web-java9_2.patch
Type: text/x-patch
Size: 40078 bytes
Desc: not available
URL: <http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20150205/7b430915/icedtea-web-java9_2-0001.patch>


More information about the distro-pkg-dev mailing list