[rfc][icedtea-web] install also icon

[Jiri Vanek]

On 02/05/2015 04:27 PM, Jie Kang wrote:
>
>
> ----- Original Message -----
>> On 02/02/2015 03:24 PM, Jiri Vanek wrote:
>>> Desktop icons (since 1.3) are using javaws as default icon (if no jnlp's
>>> one exists)
>>>
>>> However this icon, although presented in sources, is not installed now.
>>>
>>> In fedora spec I'm installing it manually -
>>> http://pkgs.fedoraproject.org/cgit/icedtea-web.git/tree/icedtea-web.spec#n105
>>>
>>> thoughts?
>>
>> Crap. It melded together with another patch.
>>
>> Anyway - will push it tomorrow if no reaction occures
>
> Hello,
>
> Patch looks fine.
>

Thank you!

> Can I push my patches without review if there are no reviews for 3 days??

No yo can't.


Also - I'm not aware of any patch from you awaiting review. All have been replied and are waiting 
for new version of patch. If there is something you are missing. Please ping!

Also I do not remember any of your patches being harmless one-liner[1]. All yours are pretty complex.


[1]http://icedtea.classpath.org/wiki/CommitPolicy