ITW to build with jdk9 post b41

[Jiri Vanek]

On 02/06/2015 11:29 AM, Fridrich Strba wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Hello, Jiří,
>
> I went through your patch and ported included the changes I did not
> have in mine. I am attaching the result.
>
> Looking at what remains, I am wondering whether one should not get
> somehow rid of the EMMA_SUFFIX and EMMA_BACKUP_SUFFIX either. I left
> it as it is, since you will know better.
>
> Cheers
>
> Fridrich
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v2
>
> iEYEARECAAYFAlTUl3wACgkQu9a1imXPdA8LWQCfZPxjp7xtNKBQvEEvHfBGydt1
> lukAmwXSxXA96SbB5QqKseWrdUeXcyO9
> =MGDE
> -----END PGP SIGNATURE-----
>

Hi!

There is one typo:

instead of
+export JACOCO_OPERATOR_EXEC=$(SYSTEM_JRE_DIR)/bin/java $(COVERAGE_JAVA_ARGS) -cp 
$(JACOCO_OPERATOR_DIR):$(JACOCO_CLASSPATH):. org.jacoco.operator.Main

you have

+export JACOCO_OPERATOR_EXEC=$(SYSTEM_JRE_DIR)/bin/java $(EMMA_JAVA_ARGS) -cp 
$(JACOCO_OPERATOR_DIR):$(JACOCO_CLASSPATH):. org.jacoco.operator.Main

Please fix.

Also one thing to think about -

you changed my:
+JUNIT_RUNTIME:=$(JUNIT_JAR) $(HAMCREST_JAR)
...
(eg) + 	  $(call composeclasspath, $(JUNIT_RUNTIME) $(TEST_EXTENSIONS_DIR)) \

to

+	  $(call composeclasspath, $(JUNIT_JAR) $(HAMCREST_JAR) $(TEST_EXTENSIONS_DIR)) \


I'm wondering what is better.

I would vote for my approach - as you specify junit_runtime once. If junit runtime will be redefined 
again,  the the change will be needed only on one space.

In your approach it will be needed on many  place, but it is since beginning clear that those are 
segments of classapth (unlike in my approach)

btw - your joinsegments is really cool :) I never realized this approach! ty!


As for emma - I wonted to remove those two vars too, but then I noted that those are also hardcoded 
in several (remaining) targets, and was lazy to doublecheck  it all again.


Please fix the issue with  $(COVERAGE_JAVA_ARGS) x $(EMMA_JAVA_ARGS)
Although I preffere "my junit_runtim" approach, I'mnot going to force you. Feel free to use which 
you think is better.


After rhose solved, ok for head (actually - considering release date of jdk9 - only head, oook?)

Do you wont to get push access or are you ok with me pushing for you?


Thank you!


J.