[rfc][icedtea-web] make threads in ResourceTracker's ExecutorService daemon
Jie Kang
jkang at redhat.com
Mon Feb 23 13:49:27 UTC 2015
----- Original Message -----
>
>
> ----- Original Message -----
> >
> > Sorry for delay. I sent it yesterday to wrong list!
> >
> > -------- Forwarded Message --------
> > Subject: [rfc][icedtea-web] make threads in ResourceTracker's
> > ExecutorService daemon
> > Date: Thu, 19 Feb 2015 16:28:03 +0100
> > From: Jiri Vanek <jvanek at redhat.com>
> > To: Discussion of RPM packaging standards and practices for Fedora
> > <packaging at lists.fedoraproject.org>
> >
> > As described in
> > http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2015-February/030792.html
> > (long thread) javaws do not close. The reason is that the trheads in
> > ExecutorService are never shut
> > down.
> >
> > One solution is to make them daemon (attached)
>
> Hello,
>
>
> One minor nit:
>
> + private static class DefaultThreadFactory implements ThreadFactory {
>
> I think the name could be more informative to what it does. Maybe call it
> "DaemonThreadFactory"?
>
>
> Apart from that it'd be nice to get the opinion of others on this patch. :|
Just to clarify, after this one nit, I'm okay for it to be pushed, just reluctant.
>
>
> Regards,
>
>
> >
> > I prefer this solution above others described in the thread.
> >
> > J.
> >
> >
> >
> >
>
> --
>
> Jie Kang
>
> OpenJDK Team - Software Engineering Intern
>
--
Jie Kang
OpenJDK Team - Software Engineering Intern
More information about the distro-pkg-dev
mailing list