[rfc][icedtea-web] Use temporary cache in PluginBridge unit tests

Jiri Vanek jvanek at redhat.com
Tue Feb 24 14:45:05 UTC 2015


Well, maybe.. but do you swear to  modify it to new approach later?

If so feel free to push and include in next iteration of "Allow cache directory to be changed during 
runtime" fixes for it.

J.
On 02/23/2015 03:59 PM, Jie Kang wrote:
>
>
> ----- Original Message -----
>>
>>
>> ----- Original Message -----
>>> Hello,
>>>
>>> Some changes to PluginBridge caused a few of the unit tests in
>>> PluginBridgeTest to create entries in the cache. This patch adds a setup
>>> and
>>> teardown to the class in order to use a temporary cache location as opposed
>>> to the user's cache.
>>>
>>> This patch relies on the 'Allow cache directory to be changed during
>>> runtime'
>>> patch:
>>> http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2015-January/030291.html
>>>
>>> Thoughts?
>>
>> Hello,
>>
>> The patch relied on is still under review. Attached is a patch that doesn't
>> rely on it.
>
> The patch had a mistake, the new methods should have been static. Fixed version attached.
>
>>
>>
>> How does it look? Okay to push?
>>
>>
>> Regards,
>>
>>>
>>>
>>> Regards,
>>>
>>> --
>>>
>>> Jie Kang
>>
>> --
>>
>> Jie Kang
>>
>> OpenJDK Team - Software Engineering Intern
>>
>



More information about the distro-pkg-dev mailing list