[rfc][icedtea-web] Allow cache directory to be changed during runtime
Andrew Azores
aazores at redhat.com
Thu Jan 15 18:16:57 UTC 2015
On 01/05/2015 02:49 PM, Jie Kang wrote:
> Hello,
>
> This patch consolidates the cacheDir instance to a single place and allows us to change it during run-time. It also modifies a unit test to use this new feature. This feature is aimed mainly at unit tests that need the cache, but do not want to modify the icedtea-web's user cache.
>
> Thoughts? Okay to push?
>
>
> Regards,
>
I think this looks generally ok. Maybe as a separate enhancement
changeset, but since you're working in here anyway, could you look at
doing some refactoring to store the cache directory as something better
than a String? As a File, or using Java 7's nio2 stuff, a Path maybe?
Thanks,
--
Andrew Azores
More information about the distro-pkg-dev
mailing list