[rfc][icedtea-web] Fix accessing Java array elements from Javascript

Jie Kang jkang at redhat.com
Mon Jan 26 15:17:17 UTC 2015


Hello,

Marcin Cieslak has taken the time to create a fix for a long-standing problem in Icedtea-Web where attempting to set/get Java array elements from Javascript fails. [1]

[1] http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1298


The reproducers relevant to this fix are:

simple/JToJSString

These reproducers tests on F21 with OpenJDK 7 and HEAD patched are now passing for me. These aren't in 1.5.x


simple/JSToJSet

These reproducers are still failing. On further investigation, the reproducer itself is not working correctly. A fix is needed here and work is in progress.

I have created a simple reproducer that mimics AppletJSToJSet_intArrayElement_Test and it passes. This is attached as: itw-js-int-array-test-1.patch. This reproducer passes on both 1.5 and HEAD.


I think a backport to 1.5.x would also be great. The two patches for HEAD and 1.5 are attached as: itw-js-array-HEAD-1.patch and itw-js-array-1.5-1.patch.

Thoughts?


Thank you again Marcin!


Regards,

-- 

Jie Kang

OpenJDK Team - Software Engineering Intern
-------------- next part --------------
A non-text attachment was scrubbed...
Name: itw-js-array-1.5-1.patch
Type: text/x-patch
Size: 1611 bytes
Desc: not available
URL: <http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20150126/9c20e792/itw-js-array-1.5-1-0001.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: itw-js-int-array-test-1.patch
Type: text/x-patch
Size: 10032 bytes
Desc: not available
URL: <http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20150126/9c20e792/itw-js-int-array-test-1-0001.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: itw-js-array-HEAD-1.patch
Type: text/x-patch
Size: 1871 bytes
Desc: not available
URL: <http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20150126/9c20e792/itw-js-array-HEAD-1-0001.patch>


More information about the distro-pkg-dev mailing list