[rfc][icedtea-web] Fix accessing Java array elements from Javascript

[Jiri Vanek]

On 01/26/2015 04:17 PM, Jie Kang wrote:
> Hello,
>
> Marcin Cieslak has taken the time to create a fix for a long-standing problem in Icedtea-Web where attempting to set/get Java array elements from Javascript fails. [1]
>
> [1] http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1298
>
>
> The reproducers relevant to this fix are:
>
> simple/JToJSString
>
> These reproducers tests on F21 with OpenJDK 7 and HEAD patched are now passing for me. These aren't in 1.5.x
>
>
> simple/JSToJSet
>
> These reproducers are still failing. On further investigation, the reproducer itself is not working correctly. A fix is needed here and work is in progress.
>
> I have created a simple reproducer that mimics AppletJSToJSet_intArrayElement_Test and it passes. This is attached as: itw-js-int-array-test-1.patch. This reproducer passes on both 1.5 and HEAD.
>
>
> I think a backport to 1.5.x would also be great. The two patches for HEAD and 1.5 are attached as: itw-js-array-HEAD-1.patch and itw-js-array-1.5-1.patch.
>
> Thoughts?
>
>
> Thank you again Marcin!
>
>

The code of fix is ok AFAICS. Thank you both!

For fixes: Please include  NEWS entry and add Marcin to authors.

For thests:  SimpleJNLP.html  and SimpleJNLP.jnlp have missing license headers
              SimpleJNLPTest.java - can it be reworked to work with default ClosingListeners?


Please turn one more round of review before push.

Thank you both!
   J.