[rfc][icedtea-web] PolicyEditor Parser patch

[Jiri Vanek]

On 07/23/2015 05:55 PM, Andrew Azores wrote:
> Hi,
>
> Attached is the PolicyEditor Parser patch from a few months ago, updated to apply to current HEAD as
> of today. I also made one small modification so that re-opening a "new" file which is actually the
> same file does not count as a change made.
>

Hi, thanx.

Please before push reconsider following bugs:
  lunch policy editor
   do some changes
   save them
   close

File is not saved (do not ecven exists as empty)

open file like policyeditor [-file] filename
apply [confirmation changes saved appear]
close, file is again nto saved (but at least file exists, an comment //generated, timestamp, do not 
edit// is present


So maybe those "not saved" have cause in some invalid entries aI'm putting in.  But no exception 
occures, and even iof so, not saving at all and simply close and discard all is bad.


So actually I was not able to make some "load" nor "selector" testing. Becasue I never get the 
content saved. I woudl storngl recommad one more iteration with above fixed.


If you wont go on and push and fix it as another changset (but please do!)
Few another things should be fixed as  additional changesets.
  - when you open policyeditor with filenameArgument of -file filename then the file is always 
created. Even if not saved
  - when crating rule you can have codebase empty, when editing, you can not
  - I'm not saying that current modify schema is wrong, but maybe the modify dialogue same as 
creation dialogue for all fields in one would be nice. (but I dont know the usecase here, so your 
current mpl may be more correct)

J.