[rfc][icedtea-web] PolicyEditor Parser patch

[Andrew Azores]

On 27/07/15 08:53 AM, Jiri Vanek wrote:
> On 07/23/2015 05:55 PM, Andrew Azores wrote:
>> Hi,
>>
>> Attached is the PolicyEditor Parser patch from a few months ago, 
>> updated to apply to current HEAD as
>> of today. I also made one small modification so that re-opening a 
>> "new" file which is actually the
>> same file does not count as a change made.
>>
>
> Hi, thanx.
>
> Please before push reconsider following bugs:
>  lunch policy editor
>   do some changes
>   save them
>   close
>
> File is not saved (do not ecven exists as empty)
>
> open file like policyeditor [-file] filename
> apply [confirmation changes saved appear]
> close, file is again nto saved (but at least file exists, an comment 
> //generated, timestamp, do not edit// is present
>
>
> So maybe those "not saved" have cause in some invalid entries aI'm 
> putting in.  But no exception occures, and even iof so, not saving at 
> all and simply close and discard all is bad.
>
>
> So actually I was not able to make some "load" nor "selector" testing. 
> Becasue I never get the content saved. I woudl storngl recommad one 
> more iteration with above fixed.
>

I believe I've fixed all of the above.

>
> If you wont go on and push and fix it as another changset (but please 
> do!)
> Few another things should be fixed as  additional changesets.
>  - when you open policyeditor with filenameArgument of -file filename 
> then the file is always created. Even if not saved

Also fixed.

>  - when crating rule you can have codebase empty, when editing, you 
> can not

Ah, nice catch, thank you. Fixed.

>  - I'm not saying that current modify schema is wrong, but maybe the 
> modify dialogue same as creation dialogue for all fields in one would 
> be nice. (but I dont know the usecase here, so your current mpl may be 
> more correct)
>
> J.

Sure, I suppose. I like the more granular implementation as it is 
because it really works nicely with keyboard shortcuts, since for 
codebase and signedBy there's only one thing to edit and so when you 
bring up the edit dialog with a keyboard shortcut, there's only one text 
field and it's pre-selected, so you can just type the replacement and 
hit Enter/Return. But I can see that it might be a little clearer if the 
Edit options were merged and presented the same as the New Entry dialog. 
I'll think about it and look at submitting a patch for this later on.

-- 
Thanks,

Andrew Azores

-------------- next part --------------
A non-text attachment was scrubbed...
Name: policyeditor-parser-2.patch
Type: text/x-patch
Size: 483099 bytes
Desc: not available
URL: <http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20150727/edf9ee6f/policyeditor-parser-2-0001.patch>