[rfc][icedtea-web] exctrat "rember deccision" panel so it canbe reused

Jiri Vanek jvanek at redhat.com
Mon Jun 1 12:45:25 UTC 2015


On 06/01/2015 02:31 PM, Jiri Vanek wrote:
> On 05/21/2015 03:57 PM, Jiri Vanek wrote:
>> hi!
>>
>> I wont to introduce global solution for various dialogues, so they can be checked by user, and will
>> not show again.
>>
>> Some of dialogues already have this feature, but some have not.  The user0interaction part is alrady
>> avaiable in those who had it (and are not certificate based).
>>
>> This patch extracted this aprt to few classes in separate package.
>>
>>
>> I hope I will later reuse this "RememberPanel.java" in some of  current dialogues whcih also deserve
>> this feature. (Ialready have global solution in mind)
>>
>
> This hunk is going to be removed in huge patch I will post later today for prereview as
> proof-of-concept.
>
> Pushing.


Forgot to say - iit is broking to unittests. But those are going to be fixed in th e"big following 
patch" too.
>> Except hunk:
>> //in this moment, panel is placed on some dialogue
>> +                Container p = RememberPanel.this.getParent();
>> +                while (p != null) {
>> +                    if (p instanceof SecurityDialog) {
>> +                        ((SecurityDialog) p).setValue(action);
>> +                        ((SecurityDialog) p).dispose();
>> +                        break;
>> +                    }
>> +                    p = p.getParent();
>> +                }
>>
>> The whole patch is really an refactroing.
>
>
>>
>>
>> J.
>



More information about the distro-pkg-dev mailing list