Fwd: [rfc][icedtea-web] small bugs in desktop(2) and both desktop and menu (1) generation

Andrew Azores aazores at redhat.com
Thu Jun 4 14:21:17 UTC 2015


On 04/06/15 02:26 AM, Jiri Vanek wrote:
> Probably it is worthy to remove also redundatn  usage of
> getDesktopIconName() + ".desktop"
> SO I iwll extract it to getDesktopIconFileName()

Will you include this change in the next version of this patch or as a 
separate changeset? I think it can just be rolled in with the changes 
you already have here, no?

> -------- Forwarded Message --------
> Subject: [rfc][icedtea-web] small bugs in desktop(2) and both desktop 
> and menu (1) generation
> Date: Wed, 03 Jun 2015 18:27:42 +0200
> From: Jiri Vanek <jvanek at redhat.com>
> To: IcedTea Distro List <distro-pkg-dev at openjdk.java.net>
> First, longer one is casued by -html. If one launches application via 
> -html, its desktop shortcut
> then do not contains -html and so dont work.
> Second - the name of desktop shortcut is may be wrong. (if it is long) 
> so even if you create it ITW
> keep asking if you wont to create it again.
> Second should go to 1.6 as it is.
> First shoudl go to 1.6 too. Just in minimalistic form.
> thoughts?

I'm probably just missing some context here but can you explain why the 
FileUtils.sanitizeFileName call was removed? Are you saying that this 
doesn't work for longer shortcut filenames?


Andrew A

More information about the distro-pkg-dev mailing list