[rfc][icedtea-web] moving

Andrew Azores aazores at redhat.com
Thu Jun 4 14:31:25 UTC 2015

On 04/06/15 04:18 AM, Jiri Vanek wrote:
> AppletSecurityActions and ExecuteAppletAction (and test) from 
> appletextendedsecurity to dialogs.remember. From future perspektive 
> they will belong here.
> Also I delegated logic which is creating SecurityDialogPanel for 
> SecurityDialog so it is more clear.
> All refactorings only,so the fututre changes will be more visible.
> J.

Generally looks alright to me. In this method here:

> +    private static SecurityDialogPanel getPanel(SecurityDialog sd) {
> +        SecurityDialogPanel lpanel = null;
> +        if (sd.dialogType == DialogType.CERT_WARNING) {

if somehow the 'sd' has a DialogType other than the ones you've 
enumerated, then this method just returns null. I haven't looked deeply 
enough to verify but I'm assuming there's no valid use case for calling 
this method and expecting a null return? In that case, could you add an 
'else' clause and within it throw some kind of runtime exception, 
perhaps? Rather than simply passing back null and then having the 
failure appear as an NPE somewhere else completely.


Andrew Azores

More information about the distro-pkg-dev mailing list