[rfc][icedtea-web] rememberable dialogues general solution - impl part 1 - safe types returned from getUserResponse

Andrew Azores aazores at redhat.com
Tue Jun 9 16:42:11 UTC 2015

On 09/06/15 12:30 PM, Jiri Vanek wrote:
> On 06/09/2015 11:15 AM, Jiri Vanek wrote:
>> On 06/08/2015 10:11 PM, Andrew Azores wrote:
>>> Is there a reason you can't do both? "YesNo" still looks like 
>>> "YesNo" in the source, even if it
>>> implements DialogResult.
>>> static YesNoDialogResult promptUser()
>> Well AccessWarningPaneComplexReturn have also "return" in name. so I 
>> guess yes.
>> if you insists (and you seems to be) then why not - I will change 
>> them to *DialogResutl as you wish,
>> and also AccessWarningPaneComplexReturn will change to 
>> AccessWarningDialogResult
> When I was writing changelog, i realized - this class implements 
> DialogResult, is in package dialogresults. Are you sure you wont also 
> suffix to most of the classes in this packages - suffix DialogResult ?
> If I was "does not metter' this morning, I'm against right now ;(
> J.

Well, I just think that "Yes" and "YesNo" aren't the greatest names. If 
you really want to leave them as is then go ahead.


Andrew Azores

More information about the distro-pkg-dev mailing list