[rfc][icedtea-web] Generate Bash Completion file

[Andrew Azores]

On 12/06/15 11:30 AM, Lukasz Dracz wrote:
> Hello,
>
> ----- Original Message -----
>> From: "Andrew Azores" <aazores at redhat.com>
>> To: "Lukasz Dracz" <ldracz at redhat.com>, "IcedTea Distro List" <distro-pkg-dev at openjdk.java.net>
>> Sent: Friday, June 12, 2015 11:22:48 AM
>> Subject: Re: [rfc][icedtea-web] Generate Bash Completion file
>>
>> On 12/06/15 11:16 AM, Lukasz Dracz wrote:
>>> Hello,
>>>
>>> This patch uses a main method in OptionsDefinitions to generate the
>>> bash-completion file. The main method is called within the Makefile. The
>>> icedteaweb-completion file is then moved to /etc/bash_completion.d/ for
>>> use by the user.
>>> The old icedtea-web completion file is removed in this patch.
>>>
>>> Thank you,
>>> Lukasz Dracz
>>> -	mkdir -p stamps && \
>>> +	mkdir -p tamps/generate-docs.stamptamps && \
>> Hmm? Accidental?
> Yes, thank you for spotting this.
> Here is the updated patch.
>
>> --
>> Thanks,
>>
>> Andrew Azores
>>
>>
> Regards,
> Lukasz Dracz

I won't comment on the actual bash completion part (so the files 
actually being generated) since I have never looked into how this works, 
but there are some more improvements that I think can be made to the 
Makefile. Rather than the generate target also installing the files via 
'sudo mv', could you instead have the generate target simply create the 
files and put them into some "local" (within the build directory) 
subdirectory, and then install them later on in the existing 
install-data-local stamp? Perhaps you could even have your new 
bash-completions target added as a dependency for generate-docs - I'm 
not 100% sure that this makes more sense than having it standalone as 
you do now, though.

-- 
Thanks,

Andrew Azores