[rfc][icedtea-web] headless dialogues -tech preview
Jiri Vanek
jvanek at redhat.com
Sun Jun 14 18:04:53 UTC 2015
Hi!
the dialog subsytem in itw is wrong.
In last few and in a lot of future patches I'm trying to replace it.
When I was doing the remeberable solution, I noted that headless uspport is completly wrong, and no worlaround may fix it.
Th eonly correct reaction is to print dialog to stdou, and request user to type answer. +1 from me, her eis implementation :)
It consist 9again) from little bit more work, soI will push it in parts.
This patch add the headless logic, and have few advantages:
- no aditional text hanling. The dialogs can prints themselves based on current ui!
- no aditional input chekcing. With strong types, each can read itslef perfectly as it is already done!
- it encapsualtes a lot of suplicated code - eg the if (!sahouldAskUser)...if (trustAll) .. If9trustNone).,... and more. So there is much more removed code then added :)
So the patch itself is quite good, isnt it? :)
Few drawbacks
- stdin get broken if underlying application creates new VM. Currently I dont know how to workaround it. But it may be surviable.
- it do nto work without X....
yah the last sentence is pitfall. It is casued by EVERYTHING in itw expects SecurityDialogue to be existing. And new Window() is on the blacklist in headless mode.
But I have some ideas how to ix it....
J.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: headlessDialogues.patch
Type: text/x-patch
Size: 51109 bytes
Desc: not available
URL: <http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20150614/2a41f632/headlessDialogues-0001.patch>
More information about the distro-pkg-dev
mailing list