[rfc][icedtea-web] Fix DeadLockTest reproducers

Jie Kang jkang at redhat.com
Tue Mar 3 13:50:28 UTC 2015


Hello,

The asserts in DeadLockTestTest contain a division by two which results in failure. 

E.g.

testSimpletest1lunchFork:
  Assert.assertEquals("launched JVMs must be exactly 2, was " + (during.size() - before.size()) / 2, 2, (during.size() - before.size()) / 2);

This test launches two applets forked (in separate JVMs). during == 3, before == 1, so it correctly launches two JVMs, however the assert divides this by 2 for some reason, (3 - 1) / 2 == 1 != 2.

These divisions don't make sense and have been removed.

Thoughts? Okay to push?


Regards,

-- 

Jie Kang

OpenJDK Team - Software Engineering Intern
-------------- next part --------------
A non-text attachment was scrubbed...
Name: itw-deadlocktest-1.patch
Type: text/x-patch
Size: 1454 bytes
Desc: not available
URL: <http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20150303/cd5c255b/itw-deadlocktest-1-0001.patch>


More information about the distro-pkg-dev mailing list