[rfc][icedtea-web] fixing CacheReproducerTest and improving VersionedJarTest

[Jie Kang]

----- Original Message -----
> >>
> >> Well please fix this as soon as possible.
> >>
> >
> > sure. Probably today.
> >
> >> Please make sure to get both use-cases below:
> >>
> >> 1) user changes cachedir to custom location using itweb-settings : this is
> >> broken with your patch (bug in PathsAndFiles?)
> >
> > Sure!
> 
> Hmm. Looking to it now, it stopepd to gave sense to me.
> 
> The cahe si already selectable via XDG variables. Why to make it more
> complicated by completly custom value?
> 
> Same is valid for logging.
> 
> Is the chengable target of those two really desirable?

Are you suggesting to remove the ability for users to customize their icedtea-web cache location? Sorry, I didn't fully understand your sentence.

XDG variables are used by more than just icedtea-web, no?

How does a user select a different cache via XDG variables?


Regards,


> 
> J.
> >
> >>
> >> 2) for unit tests : we need to be able to set cache to a temporary
> >> location : CacheUtil unit tests need to test caching functions
> >> (clearCache, etc.), but not in user's cache.
> >
> > I thought you were working on this? I guess I made this a bit more
> > complicated now...
> >
> > I'm not sure if this feature is desirable, however Most easy solution will
> > be to create false CacheLruWrapper, or not? (Now I guess You know why it s
> > probably better to not copy its value into static field...)
> > J.
> 
> 

-- 

Jie Kang

OpenJDK Team - Software Engineering Intern