[rfc][icedteaweb] Add comments about permission attributes not being checked in reproducers
Lukasz Dracz
ldracz at redhat.com
Wed Mar 4 21:00:29 UTC 2015
Hello,
I have been looking into why certain reproducers are failing. For the following tests
testPartiallySignedAppletWithSandboxPermissionsInManifestLaunchWithSignedHTMLApp
testPartiallySignedJNLPAppletWithSandboxPermissionsInManifestLaunchWithSignedApp
testSignedAppletWithSandboxPermissionsInManifestHtml
testSignedAppletWithSandboxPermissionsInManifestHtmlJnlpHref
testSignedAppletWithSandboxPermissionsInManifestJnlpApplet
testSignedAppletWithSandboxPermissionsInManifestJnlpApplication
I found that changeset 1129:0284eb954ebc is reason.
The reason why is that the permissions attributes check has been moved from always being checked into an if statement
where they are only checked when deployment.manifest.attributes.check is set to true. I have tested and found the tests to pass when this deployment.manifest.attributes.check is set to true.
This patch just adds comments to the tests for reference to help explain to anyone in the future looking at the tests. At the moment I don't have a solution, does anyone have an idea on how to properly fix this or handle this ?
I had tried to set the property to true for the tests and revert it back after to no avail. I will try to think more on this problem.
Thank you,
Lukasz Dracz
-------------- next part --------------
A non-text attachment was scrubbed...
Name: add-comment-about-permission-attributes.patch
Type: text/x-patch
Size: 2227 bytes
Desc: not available
URL: <http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20150304/2f9529a4/add-comment-about-permission-attributes.patch>
More information about the distro-pkg-dev
mailing list