[rfc][icedtea-web] fixing locales reproducers

Jiri Vanek jvanek at redhat.com
Mon Mar 9 13:36:06 UTC 2015


On 03/09/2015 02:33 PM, Jie Kang wrote:
>
>
> ----- Original Message -----
>> This minor line minifix fixes 11 reproducers.
>
> Hello,
>
>  From what I see, the key should be:
>
> BOHelp1
>
> instead of
>
> BOHelp
>
> Removing it means that this key is no longer checked in the test to exist in all properties files, which may make the test pass, but may not be the best path. I think the purpose of this test should be to check the keys that all the properties files 'must' have to run IT-W properly.
>
> If you think that it's okay for the key to not be tested to exist in all properties files, sure, you can push it. Otherwise changing it to BOHelp1 should also make it pass as this is in every property file we have now. There was a patch (IcedTea-Web settings made to use OptionParser) that renamed BOHelp -> BOHelp1, and added BOHelp2 to the english properties files.
>
>

The keys were moreover randomly selected during creation of the test.

Fact that the bohelp1 is currently only in main properties, makes it necessary to be removed.

It will not be missed :)
> Regards,
>
>>
>> J.
>>
>



More information about the distro-pkg-dev mailing list