[rfc][icedtea-web] fix some nastyness in reproducers

Jie Kang jkang at redhat.com
Mon Mar 9 13:42:51 UTC 2015



----- Original Message -----
> Hello!
> 

Hello,

Patch seems fine.

> During todays debugging I found few nasty things in reproducers:
> - invlalid (useless) urls
>    - please do not wont me to fix the new line \> - I was just sedding those

Hahah... I was going to say, fix the new lines, till I read this. Still, is it that hard? I don't even see that many... Can I push a fix for the new lines if you don't want to do it?

>    jnlps....
> - "" codebases (sigh!)

>From [1] 'Best Practices' section, I think it is better for us to use empty/no codebase instead of "." codebase. What are the benefits of changing them all to use "."? Afaict, the tests all work.

[1] http://docs.oracle.com/javase/7/docs/technotes/guides/jweb/applet/codebase_determination.html

> - and JS tests with disabled opera. It seems to me like opera have improved,
> and most of the tests is now not failing.

Sure. When you say 'most' can you be more specific? Do you know which reproducers still fail on opera and which don't?


Regards,

> 
> 
> J.
> 

-- 

Jie Kang

OpenJDK Team - Software Engineering Intern


More information about the distro-pkg-dev mailing list